Skip to content

SimplifyArmIdentity only for locals with the same type - #66870

Merged
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:simplify-ty
Dec 1, 2019
Merged

SimplifyArmIdentity only for locals with the same type#66870
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:simplify-ty

Conversation

@tmiasko

@tmiaskotmiasko commented Nov 29, 2019•
edited by Centril
Loading

Copy link
Copy Markdown
Contributor

Fixes#66856
Fixes#66851

@rust-highfive

rust-highfive commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2019
@tmiasko

tmiasko commented Nov 29, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @Centril

Centril
Centril reviewed Nov 29, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you beat me to it... ;)
I had some additional stuff that would be good to add.

Comment threadsrc/librustc_mir/transform/simplify_try.rs Outdated
Comment threadsrc/librustc_mir/transform/simplify_try.rs Outdated
Comment threadsrc/librustc_mir/transform/simplify_try.rs Outdated
Comment threadsrc/test/ui/issues/issue-66851.rs Outdated
Comment threadsrc/test/ui/issues/issue-66856.rs Outdated
@Centril

Centril commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

r? @oli-obk

@rust-highfiverust-highfive assigned oli-obk and unassigned CentrilNov 29, 2019
@tmiasko@Centril
SimplifyArmIdentity only for locals with the same type
45c4e11
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@oli-obk

oli-obk commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 45c4e11 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2019
@bors

bors commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 45c4e11 with merge f6c902286ac4d2599508c5e302d4317ff03cf760...

@rust-highfive

rust-highfive commented Nov 30, 2019

Copy link
Copy Markdown
Contributor

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-30T02:00:08.4647697Z SYSTEM_TEAMPROJECTID=e71b0ddf-dd27-435a-873c-e30f86eea377
2019-11-30T02:00:08.4647787Z SYSTEM_TIMELINEID=85c16726-9ec1-40e1-8c81-4ac0c89521c1
2019-11-30T02:00:08.4647850Z SYSTEM_TOTALJOBSINPHASE=16
2019-11-30T02:00:08.4647923Z SYSTEM_WORKFOLDER=D:\a
2019-11-30T02:00:08.4647996Z SimplifyArmIdentity only for locals with the same type
2019-11-30T02:00:08.4648139Z TEMP=/tmp
2019-11-30T02:00:08.4648205Z TERM=cygwin
2019-11-30T02:00:08.4648272Z TF_BUILD=True
2019-11-30T02:00:08.4648324Z TMP=/tmp
---
2019-11-30T02:01:11.8461215Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-11-30T02:01:11.8461429Z See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-11-30T02:01:11.8465784Z 2019-11-30T02:01:11.8470103Z Failures
2019-11-30T02:01:11.8480444Z - msys2 (exited 1) - msys2 not installed. An error occurred during installation:
2019-11-30T02:01:11.8480775Z The remote server returned an error: (503) Server Unavailable. Service Unavailable
2019-11-30T02:01:12.3410350Z 2019-11-30T02:01:12.3493201Z ##[error]Bash exited with code '1'.
2019-11-30T02:01:12.3684397Z ##[section]Starting: Checkout
2019-11-30T02:01:12.3836234Z ==============================================================================
2019-11-30T02:01:12.3836348Z Task : Get sources
2019-11-30T02:01:12.3836462Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

bors commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2019
@Centril

Centril commented Nov 30, 2019

Copy link
Copy Markdown
Contributor

@bors retry spurious

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 30, 2019
@Centril
Rollup merge ofrust-lang#66870- tmiasko:simplify-ty, r=oli-obk
472bee2
SimplifyArmIdentity only for locals with the same type
Fixesrust-lang#66856Fixesrust-lang#66851
@CentrilCentril mentioned this pull request Nov 30, 2019
Merged
bors added a commit that referenced this pull request Dec 1, 2019
@bors
Auto merge of#66908- Centril:rollup-26givp6, r=Centril
135ccba
Rollup of 9 pull requests
Successful merges:
- #66612 (Initial implementation of or-pattern usefulness checking)
- #66705 (Atomic as_mut_ptr)
- #66759 (impl TrustedLen for vec::Drain)
- #66858 (Use LLVMAddAnalysisPasses instead of Rust's wrapper)
- #66870 (SimplifyArmIdentity only for locals with the same type)
- #66883 (rustc_typeck: gate AnonConst's generics on feature(const_generics).)
- #66889 (Make python-generated source files compatible with rustfmt)
- #66894 (Remove unneeded prelude imports in libcore tests)
- #66895 (Feature gating *declarations* => new crate `rustc_feature`)
Failed merges:
- #66905 (rustc_plugin: Remove some remaining plugin features)
r? @ghost
@bors
bors merged commit 45c4e11 into rust-lang:masterDec 1, 2019
@oli-obkoli-obk mentioned this pull request Dec 1, 2019
Closed
@tmiasko
tmiasko deleted the simplify-ty branch March 1, 2020 20:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE with mir-opt-level=2: store_with_flags: invalid ScalarPair layout Miscompilation with recent Nightlies

6 participants

@tmiasko@rust-highfive@Centril@oli-obk@bors@davidtwco