Skip to content

follow the convention in this file to use third-person singular verbs - #66619

Merged
bors merged 1 commit into
rust-lang:masterfrom
guanqun:use-third-person-singular-verb
Nov 23, 2019
Merged

follow the convention in this file to use third-person singular verbs#66619
bors merged 1 commit into
rust-lang:masterfrom
guanqun:use-third-person-singular-verb

Conversation

@guanqun

Copy link
Copy Markdown

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2019
@Centril

Copy link
Copy Markdown
Contributor

r? @Centril@bors r+ rollup

@bors

bors commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit da5539c has been approved by Centril

@rust-highfiverust-highfive assigned Centril and unassigned KodrAusNov 22, 2019
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 22, 2019
…erb, r=Centril
follow the convention in this file to use third-person singular verbs
@CentrilCentril mentioned this pull request Nov 22, 2019
bors added a commit that referenced this pull request Nov 22, 2019
Rollup of 8 pull requests
Successful merges:
- #66183 (*Syntactically* permit visibilities on trait items & enum variants)
- #66566 (Document pitfall with `impl PartialEq<B> for A`)
- #66575 (Remove pretty printing of specific nodes in AST)
- #66587 (Handle statics in MIR as const pointers)
- #66619 (follow the convention in this file to use third-person singular verbs)
- #66633 (Error code's long explanation cleanup)
- #66637 (fix reoccuring typo: dereferencable -> dereferenceable)
- #66639 (resolve: more declarative `fresh_binding`)
Failed merges:
r? @ghost
@bors
bors merged commit da5539c into rust-lang:masterNov 23, 2019
@guanqun
guanqun deleted the use-third-person-singular-verb branch November 23, 2019 06:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guanqun@rust-highfive@Centril@bors@KodrAus