Uh oh!
There was an error while loading. Please reload this page.
resolve: more declarative fresh_binding - #66639
Merged
Merged
Conversation
Centrilforce-pushed
the
simplify-fresh-binding
branch
from
November 22, 2019 18:33
d1ced46 to
94b7ea9Comparepetrochenkov
commented
Nov 22, 2019
Contributor
@bors r+ rollup |
bors
commented
Nov 22, 2019
Collaborator
📌 Commit 94b7ea9 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Nov 22, 2019
…etrochenkov resolve: more declarative `fresh_binding` Following up on rust-lang#64111, this PR redefines `fresh_binding` wrt. `already_bound_and` and `already_bound_or` in a more declarative and simplified fashion. cc rust-lang#54883 r? @petrochenkov
bors added a commit
that referenced
this pull request
Nov 22, 2019
Rollup of 8 pull requests Successful merges: - #66183 (*Syntactically* permit visibilities on trait items & enum variants) - #66566 (Document pitfall with `impl PartialEq<B> for A`) - #66575 (Remove pretty printing of specific nodes in AST) - #66587 (Handle statics in MIR as const pointers) - #66619 (follow the convention in this file to use third-person singular verbs) - #66633 (Error code's long explanation cleanup) - #66637 (fix reoccuring typo: dereferencable -> dereferenceable) - #66639 (resolve: more declarative `fresh_binding`) Failed merges: r? @ghost
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #64111, this PR redefines
fresh_bindingwrt.already_bound_andandalready_bound_orin a more declarative and simplified fashion.cc #54883
r? @petrochenkov