Uh oh!
There was an error while loading. Please reload this page.
Rollup of 2 pull requests - #67433
Closed
Centril wants to merge 26 commits into
Closed
Conversation
This code was added to avoid UB in LLVM 6 and earlier, but we no longer support those LLVM versions. Since https://reviews.llvm.org/D47807 (released in LLVM 7), uitofp does exactly what we need. Closesrust-lang#51872
Normalize ident Perform unicode normalization on identifiers. Resolving the first bullet point in rust-lang#55467.
…morse Remove a const-if-hack in RawVec r? @ecstatic-morse cc @Centril
…=varkor Use structured suggestion for disambiguating method calls Fixrust-lang#65635.
…xcrichton add string.insert benchmarks This adds benchmarks for `String::insert` and `String::insert_str`
…atthewjasper Remove now-redundant range check on u128 -> f32 casts This code was added to avoid UB in LLVM 6 and earlier, but we no longer support those LLVM versions. Since https://reviews.llvm.org/D47807 (released in LLVM 7), uitofp does exactly what we need. Closesrust-lang#51872
Fix unresolved type span inside async object Closesrust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Fix internal documentation typo r? @Centril
We were inserting *before* the existing newline, so we should prepend it not append it to our inserted string.
Rollup of 7 pull requests Successful merges: - rust-lang#66670 (Normalize ident) - rust-lang#66755 (Remove a const-if-hack in RawVec) - rust-lang#67127 (Use structured suggestion for disambiguating method calls) - rust-lang#67281 (add string.insert benchmarks) - rust-lang#67328 (Remove now-redundant range check on u128 -> f32 casts) - rust-lang#67392 (Fix unresolved type span inside async object) - rust-lang#67421 (Fix internal documentation typo) Failed merges: r? @ghost
…ntril Fix toolstate history format We were inserting *before* the existing newline, so we should prepend it not append it to our inserted string.
Centril
commented
Dec 19, 2019
ContributorAuthor
@bors r+ p=200 rollup=never |
bors
commented
Dec 19, 2019
Collaborator
📌 Commit 84d2918 has been approved by |
bors
commented
Dec 19, 2019
Collaborator
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
commented
Dec 19, 2019
Collaborator
⌛ Testing commit 84d2918 with merge 127fd8d2428ac850fe60cd415a8b4f853ff9c449... |
Centril
commented
Dec 19, 2019
ContributorAuthor
@bors r- retry |
rust-highfive
commented
Dec 19, 2019
Contributor
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Dec 19, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost