Suggest type param when encountering `_` in item signatures by estebank · Pull Request #67597 · rust-lang/rust

estebank · 2019-12-24T23:19:15Z

Fix#27435.

rust-highfive · 2019-12-24T23:19:19Z

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2019-12-24T23:59:00Z

was better before imo -- more obvious

davidtwco · 2019-12-25T19:02:03Z

r? @oli-obk

estebank · 2019-12-27T23:54:54Z

done

oli-obk · 2019-12-28T00:14:33Z

r=me with the comments resolved

estebank · 2019-12-28T03:24:19Z

@bors r=oli-obk

When encountering `_` type placeholder in fn arguments and return type, suggest using generic type parameters. Expand what counts as an inferable return type to slice, array and tuples of `_`.

…new one

estebank · 2019-12-30T19:49:26Z

@bors r=oli-obk

bors · 2019-12-30T19:49:27Z

📌 Commit 261b606 has been approved by oli-obk

bors · 2019-12-31T09:51:00Z

⌛ Testing commit 261b606 with merge 71bb0ff...

Suggest type param when encountering `_` in item signatures Fix#27435.

bors · 2019-12-31T12:58:03Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 71bb0ff to master...

Extend support of `_` in type parameters - Account for `impl Trait<_>`. - Provide a reasonable `Span` for empty `Generics` in `impl`s. - Account for `fn foo<_>(_: _) {}` to suggest `fn foo<T>(_: T) {}`. - Fixrust-lang#67995. Follow up to rust-lang#67597.

Account for bounds and asociated items when denying `_` Fixrust-lang#68801, rust-lang#69204. Follow up to rust-lang#67597 and rust-lang#68071. Output for the original ICE report: ``` Checking vinoteca v5.0.0 (/Users/ekuber/workspace/vinoteca) error[E0121]: the type placeholder `_` is not allowed within types on item signatures --> src/producers.rs:43:70 | 43 | pub fn top<Table: diesel::Table + diesel::query_dsl::InternalJoinDsl<_, diesel::query_source::joins::Inner, _>>(table: Table, limit: usize, connection: DbConn) -> RestResult<Vec<TopWineType>> { | ^ not allowed in type signatures ^ not allowed in type signatures error: aborting due to previous error ```

Account for bounds and asociated items when denying `_` Fix#68801, #69204. Follow up to #67597 and #68071. Output for the original ICE report: ``` Checking vinoteca v5.0.0 (/Users/ekuber/workspace/vinoteca) error[E0121]: the type placeholder `_` is not allowed within types on item signatures --> src/producers.rs:43:70 | 43 | pub fn top<Table: diesel::Table + diesel::query_dsl::InternalJoinDsl<_, diesel::query_source::joins::Inner, _>>(table: Table, limit: usize, connection: DbConn) -> RestResult<Vec<TopWineType>> { | ^ not allowed in type signatures ^ not allowed in type signatures error: aborting due to previous error ```

rust-highfive assigned davidtwco Dec 24, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2019

estebank commented Dec 24, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/astconv.rs Outdated

oli-obk reviewed Dec 24, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/collect.rs Outdated

oli-obk reviewed Dec 24, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/collect.rs Outdated

oli-obk reviewed Dec 24, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/collect.rs Outdated

oli-obk reviewed Dec 24, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/collect.rs Outdated

oli-obk reviewed Dec 24, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/collect.rs Outdated

Centril reviewed Dec 25, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

rust-highfive assigned oli-obk and unassigned davidtwco Dec 25, 2019

estebank force-pushed the placeholder-type branch from af2338d to 1c07fccCompare December 27, 2019 12:16

This comment has been minimized.
Sign in to view

estebank force-pushed the placeholder-type branch from 1c07fcc to 859fc20Compare December 27, 2019 19:21

This comment has been minimized.
Sign in to view

estebank commented Dec 27, 2019
View reviewed changes

Comment threadsrc/test/ui/typeck/typeck_type_placeholder_item.stderr Outdated

estebank commented Dec 27, 2019
View reviewed changes

Comment threadsrc/test/ui/typeck/typeck_type_placeholder_item.stderr Outdated

estebank force-pushed the placeholder-type branch from 859fc20 to 4b4a132Compare December 27, 2019 20:40

oli-obk requested changes Dec 27, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/collect.rs Outdated
Comment threadsrc/librustc_typeck/collect.rs Outdated
Comment threadsrc/librustc_typeck/collect.rs Outdated
Comment threadsrc/librustc_typeck/collect.rs Outdated

estebank force-pushed the placeholder-type branch from b3df95e to 63f3488Compare December 27, 2019 23:49

oli-obk reviewed Dec 28, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/check/mod.rs Outdated

oli-obk reviewed Dec 28, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/check/mod.rs Outdated

oli-obk reviewed Dec 28, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/collect.rs Outdated

estebank force-pushed the placeholder-type branch from 63f3488 to d3f79fcCompare December 28, 2019 02:22

This comment has been minimized.
Sign in to view

estebank added 8 commits December 29, 2019 19:11

Suggest type param when encountering _ in fn defs
8cb193a
When encountering `_` type placeholder in fn arguments and return type, suggest using generic type parameters. Expand what counts as an inferable return type to slice, array and tuples of `_`.

Account for all item kinds when collecting and gateing _ in item defs
6c8b2dc

Account for existing type params when suggesting replacing _ for a …
fb52883
…new one

Format and fix rebase
3a9c3f9

review comments
e843245

clean up logic
cfa0b07

review comments
8a3872e

review comments and fix rebase
261b606

estebank force-pushed the placeholder-type branch from d3f79fc to 261b606Compare December 30, 2019 19:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2019

bors added a commit that referenced this pull request Dec 31, 2019
Auto merge of#67597- estebank:placeholder-type, r=oli-obk
71bb0ff
Suggest type param when encountering `_` in item signatures Fix#27435.

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2019

bors merged commit 261b606 into rust-lang:masterDec 31, 2019

lqd mentioned this pull request Jan 9, 2020
ICE: Returning impl Trait with placeholder type parameter #67995
Closed

estebank mentioned this pull request Jan 9, 2020
Extend support of _ in type parameters #68071
Merged

hellow554 mentioned this pull request Jan 13, 2020
rustc internal compiler error: bad placeholder type #68162
Closed

This was referenced Feb 13, 2020
'index out of bounds: the len is 1 but the index is 1': libcore/slice/mod.rs #68801
Closed
Account for bounds and asociated items when denying _#69148
Merged

estebank deleted the placeholder-type branch November 9, 2023 05:17

Uh oh!

Uh oh!

Conversation

estebank commented Dec 24, 2019

Uh oh!

rust-highfive commented Dec 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CentrilDec 24, 2019

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

davidtwco commented Dec 25, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

estebank commented Dec 27, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Dec 28, 2019

Uh oh!

estebank commented Dec 28, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

estebank commented Dec 30, 2019

Uh oh!

bors commented Dec 30, 2019

Uh oh!

bors commented Dec 31, 2019

Uh oh!

bors commented Dec 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants