Account for bounds and asociated items when denying `_` by estebank · Pull Request #69148 · rust-lang/rust

estebank · 2020-02-13T21:36:37Z

Fix#68801, #69204. Follow up to #67597 and #68071.

Output for the original ICE report:

 Checking vinoteca v5.0.0 (/Users/ekuber/workspace/vinoteca)
error[E0121]: the type placeholder `_` is not allowed within types on item signatures
--> src/producers.rs:43:70
|
43 | pub fn top<Table: diesel::Table + diesel::query_dsl::InternalJoinDsl<_, diesel::query_source::joins::Inner, _>>(table: Table, limit: usize, connection: DbConn) -> RestResult<Vec<TopWineType>> {
| ^ not allowed in type signatures ^ not allowed in type signatures
error: aborting due to previous error

rust-highfive · 2020-02-13T21:36:41Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2020-02-13T21:42:46Z

r? @oli-obk

estebank · 2020-02-20T00:52:49Z

ping

pnkfelix · 2020-02-20T15:26:04Z

discussed at T-compiler meeting. declined for beta backport.

"current decision: no backport because too big, but let us know if you want us to revisit the question"

estebank · 2020-02-20T18:24:56Z

@pnkfelix saw the discussion, sounds fair. There's a very small fix that would cause duplicated output but would never ICE at the cost of the extra verbosity. Should I go ahead and do that?

estebank · 2020-02-20T18:40:09Z

@Centril @oli-obk is on vacation, could you take a look at this?

rust-lang#69148 has a proper fix, but it is too big to backport. This change avoids the ICE by actually emitting an appropriate error. The output will be duplicated in some cases, but that's better than the avoidable ICE.

Centril · 2020-02-24T19:04:45Z

@estebank Sorry, I don't think I have the time to invest into understanding this as well as I would want to to get to r+. :(

oli-obk · 2020-02-26T17:37:24Z

@bors r+

bors · 2020-02-26T17:37:25Z

📌 Commit d3ad814a276964dfcf293904f76f16494e54d4eb has been approved by oli-obk

estebank · 2020-02-26T22:35:22Z

@bors r-

@oli-obk I'll rebase and r+ this after the backportable PR #69324 lands.

@Centril

…ceholder-type, r=Centril Backport only: avoid ICE on bad placeholder type rust-lang#69148 has a proper fix, but it is too big to backport. This change avoids the ICE by actually emitting an appropriate error. The output will be duplicated in some cases, but that's better than the avoidable ICE. r? @Centril

bors · 2020-02-27T11:54:30Z

☔ The latest upstream changes (presumably #69507) made this pull request unmergeable. Please resolve the merge conflicts.

This reverts commit 1cb555a.

estebank · 2020-02-28T00:00:32Z

@bors r=oli-obk rebased on top of master with the other PR reverted

bors · 2020-02-28T00:00:34Z

📌 Commit c6cfcf9 has been approved by oli-obk

Account for bounds and asociated items when denying `_` Fixrust-lang#68801, rust-lang#69204. Follow up to rust-lang#67597 and rust-lang#68071. Output for the original ICE report: ``` Checking vinoteca v5.0.0 (/Users/ekuber/workspace/vinoteca) error[E0121]: the type placeholder `_` is not allowed within types on item signatures --> src/producers.rs:43:70 | 43 | pub fn top<Table: diesel::Table + diesel::query_dsl::InternalJoinDsl<_, diesel::query_source::joins::Inner, _>>(table: Table, limit: usize, connection: DbConn) -> RestResult<Vec<TopWineType>> { | ^ not allowed in type signatures ^ not allowed in type signatures error: aborting due to previous error ```

bors · 2020-02-28T14:25:04Z

⌛ Testing commit c6cfcf9 with merge eaa02f5...

bors · 2020-02-28T17:53:03Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing eaa02f5 to master...

…r=Centril Account for bad placeholder types in where clauses Fixrust-lang#70291. Follow up to rust-lang#69148.

estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 13, 2020

rust-highfive assigned cramertj Feb 13, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 13, 2020

rust-highfive assigned oli-obk and unassigned cramertj Feb 13, 2020

estebank changed the title ~~Account for bounds when denying _ in type parameters~~Account for bounds and asociated items when denying _ in type parametersFeb 17, 2020

estebank changed the title ~~Account for bounds and asociated items when denying _ in type parameters~~Account for bounds and asociated items when denying _Feb 17, 2020

estebank force-pushed the cold-as-ice branch from 4568dbf to d3ad814Compare February 17, 2020 20:08

estebank mentioned this pull request Feb 17, 2020
_ in associated types causes nightly and beta compiler to panic #69204
Closed

hellow554 mentioned this pull request Feb 18, 2020
'index out of bounds: the len is 1 but the index is 1': libcore/slice/mod.rs #68801
Closed

pnkfelix removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 20, 2020

estebank mentioned this pull request Feb 20, 2020
Backport only: avoid ICE on bad placeholder type #69324
Merged

estebank removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 20, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2020

estebank added 3 commits February 27, 2020 15:59

Revert "Backport only: avoid ICE on bad placeholder type"
e6c8596
This reverts commit 1cb555a.

Account for bounds when denying _ in type parameters
a7b727d

Account for associated items when denying _
c6cfcf9

estebank force-pushed the cold-as-ice branch from d3ad814 to c6cfcf9Compare February 27, 2020 23:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2020

Dylan-DPC-zz mentioned this pull request Feb 28, 2020
Rollup of 7 pull requests #69543
Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 28, 2020

bors merged commit eaa02f5 into rust-lang:masterFeb 28, 2020

estebank mentioned this pull request Mar 23, 2020
Account for bad placeholder types in where clauses #70294
Merged

Centril added a commit to Centril/rust that referenced this pull request Mar 23, 2020
Rollup merge ofrust-lang#70294- estebank:bad-placeholder-in-where, …
de1b094
…r=Centril Account for bad placeholder types in where clauses Fixrust-lang#70291. Follow up to rust-lang#69148.

Centril added a commit to Centril/rust that referenced this pull request Mar 23, 2020
Rollup merge ofrust-lang#70294- estebank:bad-placeholder-in-where, …
b07333c
…r=Centril Account for bad placeholder types in where clauses Fixrust-lang#70291. Follow up to rust-lang#69148.

Centril added a commit to Centril/rust that referenced this pull request Mar 23, 2020
Rollup merge ofrust-lang#70294- estebank:bad-placeholder-in-where, …
54db0cf
…r=Centril Account for bad placeholder types in where clauses Fixrust-lang#70291. Follow up to rust-lang#69148.

estebank mentioned this pull request Oct 3, 2020
Fix bad placeholder type error on certain consts and statics #77431
Closed

dwrensha mentioned this pull request Oct 14, 2021
thread 'rustc' panicked at 'index out of bounds: the len is 0 but the index is 0' #89868
Closed

estebank deleted the cold-as-ice branch November 9, 2023 05:17

Uh oh!

Uh oh!

Conversation

estebank commented Feb 13, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Feb 13, 2020

Uh oh!

Centril commented Feb 13, 2020

Uh oh!

estebank commented Feb 20, 2020

Uh oh!

pnkfelix commented Feb 20, 2020

Uh oh!

estebank commented Feb 20, 2020

Uh oh!

estebank commented Feb 20, 2020

Uh oh!

Centril commented Feb 24, 2020

Uh oh!

oli-obk commented Feb 26, 2020

Uh oh!

bors commented Feb 26, 2020

Uh oh!

estebank commented Feb 26, 2020

Uh oh!

bors commented Feb 27, 2020

Uh oh!

estebank commented Feb 28, 2020

Uh oh!

bors commented Feb 28, 2020

Uh oh!

bors commented Feb 28, 2020

Uh oh!

bors commented Feb 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

estebank commented Feb 13, 2020•
edited
Loading