Uh oh!
There was an error while loading. Please reload this page.
Less-than is asymmetric, not antisymmetric - #67736
Merged
Merged
Conversation
This has bothered me for a while. It's such a small nit, but...
rust-highfive
commented
Dec 30, 2019
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
sfackler
commented
Dec 31, 2019
Member
I believe the documentation is correct - less-than is an antisymmetric relation: https://en.wikipedia.org/wiki/Antisymmetric_relation. |
taralx
commented
Dec 31, 2019
ContributorAuthor
antisymmetric: if a <= b and b <= a, then a = b. asymmetric: if a < b then not b < a. |
sfackler
commented
Dec 31, 2019
Member
Ah right. @bors r+ rollup |
bors
commented
Dec 31, 2019
Collaborator
📌 Commit d935a26 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jan 1, 2020
Less-than is asymmetric, not antisymmetric This has bothered me for a while. It's such a small nit, but...
RalfJung
commented
Jan 2, 2020
Member
Asymmetry is a property of a single relation though, whereas really here we are talking about three related relations (heh). Not sure what the best terminology is there. But yeah, "asymmetric" seems to fit better than "antisymmetric". Cc #50230 |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 2, 2020
Less-than is asymmetric, not antisymmetric This has bothered me for a while. It's such a small nit, but...
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 2, 2020
Less-than is asymmetric, not antisymmetric This has bothered me for a while. It's such a small nit, but...
bors added a commit
that referenced
this pull request
Jan 2, 2020
Rollup of 5 pull requests Successful merges: - #67636 (allow rustfmt key in [build] section) - #67736 (Less-than is asymmetric, not antisymmetric) - #67762 (Add missing links for insecure_time) - #67777 (Use self profile infrastructure for -Z time and -Z time-passes) - #67807 (Use drop instead of the toilet closure `|_| ()`) Failed merges: r? @ghost
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 3, 2020
Less-than is asymmetric, not antisymmetric This has bothered me for a while. It's such a small nit, but...
bors added a commit
that referenced
this pull request
Jan 3, 2020
Rollup of 10 pull requests Successful merges: - #67450 (Allow for setting a ThinLTO import limit during bootstrap) - #67595 (Suggest adding a lifetime constraint for opaque type) - #67636 (allow rustfmt key in [build] section) - #67736 (Less-than is asymmetric, not antisymmetric) - #67762 (Add missing links for insecure_time) - #67783 (Warn for bindings named same as variants when matching against a borrow) - #67796 (Ensure that we process projections during MIR inlining) - #67807 (Use drop instead of the toilet closure `|_| ()`) - #67816 (Clean up err codes) - #67825 (Minor: change take() docs grammar to match other docs) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has bothered me for a while. It's such a small nit, but...