Uh oh!
There was an error while loading. Please reload this page.
Rollup of 10 pull requests - #67828
Merged
Merged
Conversation
…for "does not live long enough" error
This has bothered me for a while. It's such a small nit, but...
Fixesrust-lang#67710 Previously, we were not calling `super_place`, which resulted in us failing to update any local references that occur in ProjectionElem::Index. This caused the post-inlining MIR to contain a reference to a local ID from the inlined callee, leading to an ICE due to a type mismatch.
Co-authored-by: Centril <twingoow@gmail.com>
Co-authored-by: Centril <twingoow@gmail.com>
Eg. mem::replace()
…imit, r=Mark-Simulacrum Allow for setting a ThinLTO import limit during bootstrap The benchmarks in rust-lang#66625 have shown that a lower ThinLTO import limit can be a net win for bootstrap times. This PR: - exposes the setting to `config.toml`, - defaults to a lower limit if `incremental = true` in `config.toml`, and - sets a lower limit for `x86_64-gnu-llvm-7` CI image in order to make the jobs complete more quickly (which remains to be tested). This setting will affect how the compiler and it's tools are compiled. It will not affect the settings the compiler uses when compiling user code. r? @pietroalbini cc @rust-lang/infra
…long-enough, r=estebank Suggest adding a lifetime constraint for opaque type Fixesrust-lang#67577, where code like this: ``` struct List { data: Vec<String>, } impl List { fn started_with<'a>(&'a self, prefix: &'a str) -> impl Iterator<Item=&'a str> { self.data.iter().filter(|s| s.starts_with(prefix)).map(|s| s.as_ref()) } } ``` will show this error: ``` Compiling playground v0.0.1 (/playground) error[E0597]: `prefix` does not live long enough --> src/lib.rs:6:47 | 5 | fn started_with<'a>(&'a self, prefix: &'a str) -> impl Iterator<Item=&'a str> { | -- lifetime `'a` defined here --------------------------- opaque type requires that `prefix` is borrowed for `'a` ... ``` but without suggesting the lovely `help: you can add a constraint..`. r? @estebank
…imulacrum allow rustfmt key in [build] section Permit using `rustfmt` in `config.toml`. It will allow to not download `rustfmt` binary, which is not possible for at least some tiers-3 platforms. Fixes: rust-lang#67624 r? @Mark-Simulacrum
Less-than is asymmetric, not antisymmetric This has bothered me for a while. It's such a small nit, but...
…lett Add missing links for insecure_time
…, r=Centril Warn for bindings named same as variants when matching against a borrow Fixesrust-lang#67776
…sleywiser Ensure that we process projections during MIR inlining Fixesrust-lang#67710 Previously, we were not calling `super_place`, which resulted in us failing to update any local references that occur in ProjectionElem::Index. This caused the post-inlining MIR to contain a reference to a local ID from the inlined callee, leading to an ICE due to a type mismatch.
Use drop instead of the toilet closure `|_| ()`
…r=Dylan-DPC Clean up err codes r? @Dylan-DPC
…steveklabnik Minor: change take() docs grammar to match other docs Eg. mem::replace()
JohnTitor
commented
Jan 3, 2020
MemberAuthor
@bors r+ p=10 rollup=never |
bors
commented
Jan 3, 2020
Collaborator
📌 Commit 14c96ce has been approved by |
bors
commented
Jan 3, 2020
Collaborator
bors added a commit
that referenced
this pull request
Jan 3, 2020
Rollup of 10 pull requests Successful merges: - #67450 (Allow for setting a ThinLTO import limit during bootstrap) - #67595 (Suggest adding a lifetime constraint for opaque type) - #67636 (allow rustfmt key in [build] section) - #67736 (Less-than is asymmetric, not antisymmetric) - #67762 (Add missing links for insecure_time) - #67783 (Warn for bindings named same as variants when matching against a borrow) - #67796 (Ensure that we process projections during MIR inlining) - #67807 (Use drop instead of the toilet closure `|_| ()`) - #67816 (Clean up err codes) - #67825 (Minor: change take() docs grammar to match other docs) Failed merges: r? @ghost
bors
commented
Jan 3, 2020
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
|_| ()#67807 (Use drop instead of the toilet closure|_| ())Failed merges:
r? @ghost