Skip to content

Explain that associated types and consts can't be accessed directly on the trait's path - #67747

Merged
bors merged 2 commits into
rust-lang:masterfrom
estebank:bare-assoc-const
Jan 9, 2020
Merged

Explain that associated types and consts can't be accessed directly on the trait's path#67747
bors merged 2 commits into
rust-lang:masterfrom
estebank:bare-assoc-const

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Partially address #44539.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2019
@estebank

Copy link
Copy Markdown
ContributorAuthor

r? @Centril

@rust-highfiverust-highfive assigned Centril and unassigned eddybDec 31, 2019

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comment addressed.

Comment threadsrc/librustc/traits/error_reporting.rs Outdated
@estebank

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit b3b206f has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 8, 2020
Explain that associated types and consts can't be accessed directly on the trait's path
Partially address rust-lang#44539.
@CentrilCentril mentioned this pull request Jan 8, 2020
bors added a commit that referenced this pull request Jan 9, 2020
Rollup of 12 pull requests
Successful merges:
- #67630 (Treat extern statics just like statics in the "const pointer to static" representation)
- #67747 (Explain that associated types and consts can't be accessed directly on the trait's path)
- #67884 (Fix incremental builds of core by allowing unused attribute.)
- #67966 (Use matches macro in libcore and libstd)
- #67979 (Move `intravisit` => `rustc_hir` + misc cleanup)
- #67986 (Display more informative ICE)
- #67990 (slice patterns: harden match-based borrowck tests)
- #68005 (Improve E0184 explanation)
- #68009 (Spell check librustc_error_codes)
- #68023 (Fix issue #68008)
- #68024 (Remove `-Z continue-parse-after-error`)
- #68026 (Small improvements in lexical_region_resolve)
Failed merges:
r? @ghost
@bors
bors merged commit b3b206f into rust-lang:masterJan 9, 2020
@estebank
estebank deleted the bare-assoc-const branch November 9, 2023 05:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@estebank@rust-highfive@bors@Centril@eddyb