Uh oh!
There was an error while loading. Please reload this page.
Small improvements in lexical_region_resolve - #68026
Merged
Merged
Conversation
rust-highfive
commented
Jan 8, 2020
Contributor
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
Lonami
reviewed
Jan 8, 2020
Uh oh!
There was an error while loading. Please reload this page.
varkor
commented
Jan 8, 2020
Contributor
r=me after amending the fix. |
varkor
commented
Jan 8, 2020
Contributor
@llogiq: could you squash the changes into a single commit? |
llogiqforce-pushed
the
ch-ch-ch-ch-changes
branch
from
January 8, 2020 22:00
4806564 to
74ea108Comparellogiq
commented
Jan 8, 2020
ContributorAuthor
Done. |
varkor
commented
Jan 8, 2020
Contributor
@bors r+ rollup |
bors
commented
Jan 8, 2020
Collaborator
📌 Commit 74ea108 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jan 8, 2020
Small improvements in lexical_region_resolve This just replaces a trivial `if` condition with a `|=` in two places. I could even have used a `fold` in the first case, but I think it would be less readable.
bors added a commit
that referenced
this pull request
Jan 9, 2020
Rollup of 12 pull requests Successful merges: - #67630 (Treat extern statics just like statics in the "const pointer to static" representation) - #67747 (Explain that associated types and consts can't be accessed directly on the trait's path) - #67884 (Fix incremental builds of core by allowing unused attribute.) - #67966 (Use matches macro in libcore and libstd) - #67979 (Move `intravisit` => `rustc_hir` + misc cleanup) - #67986 (Display more informative ICE) - #67990 (slice patterns: harden match-based borrowck tests) - #68005 (Improve E0184 explanation) - #68009 (Spell check librustc_error_codes) - #68023 (Fix issue #68008) - #68024 (Remove `-Z continue-parse-after-error`) - #68026 (Small improvements in lexical_region_resolve) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just replaces a trivial
ifcondition with a|=in two places.I could even have used a
foldin the first case, but I think it would be less readable.