Skip to content

Make conflicting_repr_hints a deny-by-default c-future-compat lint - #68586

Merged
bors merged 1 commit into
rust-lang:masterfrom
Centril:repr-deny
Jan 29, 2020
Merged

Make conflicting_repr_hints a deny-by-default c-future-compat lint#68586
bors merged 1 commit into
rust-lang:masterfrom
Centril:repr-deny

Conversation

@Centril

@CentrilCentril commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2020
@CentrilCentril added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 28, 2020
@pnkfelix

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 28, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 979f5b4 has been approved by pnkfelix

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2020
@CentrilCentril mentioned this pull request Jan 28, 2020
@petrochenkov

Copy link
Copy Markdown
Contributor

r? @pnkfelix

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 29, 2020
Make conflicting_repr_hints a deny-by-default c-future-compat lint
Closesrust-lang#68428.
cc rust-lang#68585.
r? @petrochenkov@pnkfelix
@JohnTitorJohnTitor mentioned this pull request Jan 29, 2020
bors added a commit that referenced this pull request Jan 29, 2020
Rollup of 7 pull requests
Successful merges:
- #67722 (Minor: note how Any is an unsafe trait in SAFETY comments)
- #68586 (Make conflicting_repr_hints a deny-by-default c-future-compat lint)
- #68598 (Fix null synthetic_implementors error)
- #68603 (Changelog: Demonstrate final build-override syntax)
- #68609 (Set lld flavor for MSVC to link.exe)
- #68611 (Correct ICE caused by macros generating invalid spans.)
- #68627 (Document that write_all will not call write if given an empty buffer)
Failed merges:
r? @ghost
@bors
bors merged commit 979f5b4 into rust-lang:masterJan 29, 2020
@Centril
Centril deleted the repr-deny branch January 29, 2020 17:12
@CentrilCentril removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jan 29, 2020
@Mark-SimulacrumMark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 15, 2020
@Mark-Simulacrum

Copy link
Copy Markdown
Member

Re-adding beta-nomination, AFAICT this didn't get into beta.

error[E0566]: conflicting representation hints

Number of crates regressed: 2

Details

@pnkfelix

Copy link
Copy Markdown
Contributor

discussed at T-compiler meeting. Approved for beta backport.

@pnkfelixpnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 20, 2020
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 21, 2020
bors added a commit that referenced this pull request Feb 24, 2020
[beta] beta backports
This backports the following PRs:
* Revert "Remove `checked_add` in `Layout::repeat`" #69241
* Do not ICE when encountering `yield` inside `async` block #69175
* Fix MIR typeck soundness holes #69145
* Fix extra subslice lowering #69128
* Correct ICE caused by macros generating invalid spans. #68611
* Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Conflicting representations" warning became an error

6 participants

@Centril@pnkfelix@bors@petrochenkov@Mark-Simulacrum@rust-highfive