Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #68635
Merged
Merged
Conversation
Some types of Write instances have a semantic meaning associated with writing an empty buffer, such as sending an empty packet. This works when calling `write` directly, and supplying an empty buffer. However, calling `write_all` on an empty buffer will simply never call `write`, because `write_all` assumes it has no work to do. Document this behavior, to help prospective users of datagram-packet-style Write instances.
… r=Mark-Simulacrum Minor: note how Any is an unsafe trait in SAFETY comments Motivation: helpful to people like myself reading the standard library source to better understand how to use Any, especially if we do go ahead with rust-lang#67562 and make it an unsafe trait.
Make conflicting_repr_hints a deny-by-default c-future-compat lint Closesrust-lang#68428. cc rust-lang#68585. r? @petrochenkov@pnkfelix
…mplementors, r=ollie27 Fix null synthetic_implementors error Fixesrust-lang#68584. r? @ollie27 cc @kinnison
Changelog: Demonstrate final build-override syntax
Set lld flavor for MSVC to link.exe This enables linking with LLD on Windows with just `-C linker=rust-lld` instead of needing `-C linker=rust-lld -C linker-flavor=lld-link`.
Correct ICE caused by macros generating invalid spans. Closesrust-lang#68605
…n-DPC Document that write_all will not call write if given an empty buffer Some types of Write instances have a semantic meaning associated with writing an empty buffer, such as sending an empty packet. This works when calling `write` directly, and supplying an empty buffer. However, calling `write_all` on an empty buffer will simply never call `write`, because `write_all` assumes it has no work to do. Document this behavior, to help prospective users of datagram-packet-style Write instances.
JohnTitor
commented
Jan 29, 2020
MemberAuthor
@bors r+ p=7 rollup=never |
bors
commented
Jan 29, 2020
Collaborator
📌 Commit 50df788 has been approved by |
bors
commented
Jan 29, 2020
Collaborator
bors added a commit
that referenced
this pull request
Jan 29, 2020
Rollup of 7 pull requests Successful merges: - #67722 (Minor: note how Any is an unsafe trait in SAFETY comments) - #68586 (Make conflicting_repr_hints a deny-by-default c-future-compat lint) - #68598 (Fix null synthetic_implementors error) - #68603 (Changelog: Demonstrate final build-override syntax) - #68609 (Set lld flavor for MSVC to link.exe) - #68611 (Correct ICE caused by macros generating invalid spans.) - #68627 (Document that write_all will not call write if given an empty buffer) Failed merges: r? @ghost
bors
commented
Jan 29, 2020
Collaborator
☀️ Test successful - checks-azure |
rust-highfive
commented
Jan 29, 2020
Contributor
📣 Toolstate changed by #68635! Tested on commit eed12bc. 🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor@amanjeev@spastorino@mark-i-m, @rust-lang/infra). |
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jan 29, 2020
Tested on commit rust-lang/rust@eed12bc. Direct link to PR: <rust-lang/rust#68635> 🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor@amanjeev@spastorino@mark-i-m, @rust-lang/infra).
This was referenced Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost