Uh oh!
There was an error while loading. Please reload this page.
self-profile: Support arguments for generic_activities. - #68932
Merged
bors merged 1 commit intoFeb 11, 2020
Conversation
michaelwoerister
commented
Feb 7, 2020
MemberAuthor
Let's do a perf run in order to see if this breaks anything. @bors try @rust-timer queue |
rust-timer
commented
Feb 7, 2020
Collaborator
Awaiting bors try build completion |
bors
commented
Feb 7, 2020
Collaborator
bors added a commit
that referenced
this pull request
Feb 7, 2020
…-args, r=<try> self-profile: Support arguments for generic_activities. This PR adds support for recording arguments of "generic activities". The most notable use case is LLVM module names, which should be very interesting for `crox` profiles. In the future it might be interesting to add more fine-grained events for pre-query passes like macro expansion. I tried to judiciously de-duplicate existing self-profile events with `extra_verbose_generic_activity`, now that the latter also generates self-profile events. r? @wesleywiser
bors
commented
Feb 7, 2020
Collaborator
☀️ Try build successful - checks-azure |
rust-timer
commented
Feb 7, 2020
Collaborator
Queued ac48467 with parent b5e21db, future comparison URL. |
rust-timer
commented
Feb 7, 2020
Collaborator
Finished benchmarking try commit ac48467, comparison URL. |
wesleywiser
approved these changes
Feb 8, 2020
wesleywiser
left a comment
Member
There was a problem hiding this comment.
A few minor comments. r=me if you don't think they need to be addressed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
michaelwoeristerforce-pushed
the
self-profile-generic-activity-args
branch
from
February 10, 2020 14:47
223c7e5 to
81dccb1Comparemichaelwoerister
commented
Feb 10, 2020
MemberAuthor
|
wesleywiser
approved these changes
Feb 10, 2020
wesleywiser
commented
Feb 10, 2020
Member
@bors r+ |
bors
commented
Feb 10, 2020
Collaborator
📌 Commit 81dccb1 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 10, 2020
…ic-activity-args, r=wesleywiser self-profile: Support arguments for generic_activities. This PR adds support for recording arguments of "generic activities". The most notable use case is LLVM module names, which should be very interesting for `crox` profiles. In the future it might be interesting to add more fine-grained events for pre-query passes like macro expansion. I tried to judiciously de-duplicate existing self-profile events with `extra_verbose_generic_activity`, now that the latter also generates self-profile events. r? @wesleywiser
bors added a commit
that referenced
this pull request
Feb 10, 2020
Rollup of 6 pull requests Successful merges: - #68897 (clean up E0275 explanation) - #68908 (Add long error code explanation message for E0637 ) - #68932 (self-profile: Support arguments for generic_activities.) - #68986 (Make ASCII ctype functions unstably const ) - #69007 (Clean up E0283 explanation) - #69014 (change an instance of span_bug() to struct_span_err() to avoid ICE) Failed merges: r? @ghost
bors added a commit
that referenced
this pull request
Feb 10, 2020
Rollup of 6 pull requests Successful merges: - #68897 (clean up E0275 explanation) - #68908 (Add long error code explanation message for E0637 ) - #68932 (self-profile: Support arguments for generic_activities.) - #68986 (Make ASCII ctype functions unstably const ) - #69007 (Clean up E0283 explanation) - #69014 (change an instance of span_bug() to struct_span_err() to avoid ICE) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for recording arguments of "generic activities". The most notable use case is LLVM module names, which should be very interesting for
croxprofiles. In the future it might be interesting to add more fine-grained events for pre-query passes like macro expansion.I tried to judiciously de-duplicate existing self-profile events with
extra_verbose_generic_activity, now that the latter also generates self-profile events.r? @wesleywiser