Uh oh!
There was an error while loading. Please reload this page.
change an instance of span_bug() to struct_span_err() to avoid ICE - #69014
Merged
Conversation
rust-highfive
commented
Feb 10, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Centril
reviewed
Feb 10, 2020
| @@ -0,0 +1,4 @@ | |||
| enum e{A((?'a a+?+l))} | |||
Contributor
There was a problem hiding this comment.
A slightly simpler reproducer btw, type X = (?'a ?+l);.
Contributor
There was a problem hiding this comment.
Not necessary, yours is sufficiently minimal. ;)
Centril
commented
Feb 10, 2020
Contributor
bors
commented
Feb 10, 2020
Collaborator
📌 Commit 371060b has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 10, 2020
change an instance of span_bug() to struct_span_err() to avoid ICE After rust-lang#67148, the `span_bug()` in `parse_ty_tuple_or_parens()` is reachable because `parse_paren_comma_seq()` can return an `Ok()` even in cases where it encounters an error. This pull request prevents an ICE in such cases by replacing the `span_bug()` with `struct_span_error()`. Fixesrust-lang#68890.
bors added a commit
that referenced
this pull request
Feb 10, 2020
Rollup of 6 pull requests Successful merges: - #68897 (clean up E0275 explanation) - #68908 (Add long error code explanation message for E0637 ) - #68932 (self-profile: Support arguments for generic_activities.) - #68986 (Make ASCII ctype functions unstably const ) - #69007 (Clean up E0283 explanation) - #69014 (change an instance of span_bug() to struct_span_err() to avoid ICE) Failed merges: r? @ghost
bors added a commit
that referenced
this pull request
Feb 10, 2020
Rollup of 6 pull requests Successful merges: - #68897 (clean up E0275 explanation) - #68908 (Add long error code explanation message for E0637 ) - #68932 (self-profile: Support arguments for generic_activities.) - #68986 (Make ASCII ctype functions unstably const ) - #69007 (Clean up E0283 explanation) - #69014 (change an instance of span_bug() to struct_span_err() to avoid ICE) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #67148, the
span_bug()inparse_ty_tuple_or_parens()is reachable becauseparse_paren_comma_seq()can return anOk()even in cases where it encounters an error.This pull request prevents an ICE in such cases by replacing the
span_bug()withstruct_span_error().Fixes#68890.