Skip to content

Make num::NonZeroX::new an unstable const fn - #68976

Merged
bors merged 2 commits into
rust-lang:masterfrom
ecstatic-morse:const-non-zero
Feb 10, 2020
Merged

Make num::NonZeroX::new an unstable const fn#68976
bors merged 2 commits into
rust-lang:masterfrom
ecstatic-morse:const-non-zero

Conversation

@ecstatic-morse

@ecstatic-morseecstatic-morse commented Feb 9, 2020

Copy link
Copy Markdown
Contributor

cc #53718

These require #[feature(const_if_match)], meaning they must remain unstable for the time being.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2020
@dtolnay

Copy link
Copy Markdown
Member

r? @dtolnay

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 9, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 0755c41 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 10, 2020
…olnay
Make `num::NonZeroX::new` an unstable `const fn`
cc rust-lang#53718
These require `#[feature(const_if_match)]`, meaning they must remain unstable for the time being.
bors added a commit that referenced this pull request Feb 10, 2020
Rollup of 6 pull requests
Successful merges:
- #68694 (Reduce the number of `RefCell`s in `InferCtxt`.)
- #68966 (Improve performance of coherence checks)
- #68976 (Make `num::NonZeroX::new` an unstable `const fn`)
- #68992 (Correctly parse `mut a @ b`)
- #69005 (Small graphviz improvements for the new dataflow framework)
- #69006 (parser: Keep current and previous tokens precisely)
Failed merges:
r? @ghost
@bors
bors merged commit 0755c41 into rust-lang:masterFeb 10, 2020
@ecstatic-morse
ecstatic-morse deleted the const-non-zero branch October 6, 2020 01:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ecstatic-morse@rust-highfive@dtolnay@bors@alexcrichton@Centril