Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #69012
Merged
Merged
Conversation
Now the line for each statement will show the diff resulting from the combination of `before_statement_effect` and `statement_effect`. It's still possible to observe each in isolation via `borrowck_graphviz_format = "two_phase"`.
including their unnormalized forms. Add more documentation for them.
`InferCtxt` contains six structures within `RefCell`s. Every time we create and dispose of (commit or rollback) a snapshot we have to `borrow_mut` each one of them. This commit moves the six structures under a single `RefCell`, which gives significant speed-ups by reducing the number of `borrow_mut` calls. To avoid runtime errors I had to reduce the lifetimes of dynamic borrows in a couple of places.
This has negligible perf impact, but it does improve the code a bit. * Only query the specialization graph of any trait once instead of once per impl * Loop over impls only once, precomputing impl DefId and TraitRef
This was showing up in profiles. Also deduplicates the code to get just the impl header span.
This was previously a future-compat warning that has since been turned into hard error, but without actually removing all the code. Avoids a call to `traits::overlapping_impls`, which is expensive.
…rCtxt, r=varkor Reduce the number of `RefCell`s in `InferCtxt`. `InferCtxt` contains six structures within `RefCell`s. Every time we create and dispose of (commit or rollback) a snapshot we have to `borrow_mut` each one of them. This commit moves the six structures under a single `RefCell`, which gives significant speed-ups by reducing the number of `borrow_mut` calls. To avoid runtime errors I had to reduce the lifetimes of dynamic borrows in a couple of places. r? @varkor
…arkor Improve performance of coherence checks The biggest perf improvement in here is expected to come from the removal of the remaining rust-lang#43355 warning code since that effectively runs the expensive parts of coherence *twice*, which can even be visualized by obtaining a flamegraph: 
…olnay Make `num::NonZeroX::new` an unstable `const fn` cc rust-lang#53718 These require `#[feature(const_if_match)]`, meaning they must remain unstable for the time being.
… r=Centril Correctly parse `mut a @ b` r? @CentrilClosesrust-lang#67861Closesrust-lang#67926
…phviz, r=wesleywiser Small graphviz improvements for the new dataflow framework Split out from rust-lang#68241. This prints the correct effect diff for each line (the before-effect and the after-effect) and makes marginal improvements to the graphviz output for the new dataflow framework including using monospaced font and better line breaking. This will only be useful when rust-lang#68241 is merged and the graphviz output changes from this:  to this:  r? @wesleywiser
parser: Keep current and previous tokens precisely ...including their unnormalized forms. Add more documentation for them. Hopefully, this will help to eliminate footguns like rust-lang#68728 (comment). I'll try to address the FIXMEs in separate PRs during the next week. r? @Centril
Dylan-DPC-zz
commented
Feb 10, 2020
Author
@bors r+ rollup=never p=6 |
bors
commented
Feb 10, 2020
Collaborator
📌 Commit 18c6d39 has been approved by |
bors
commented
Feb 10, 2020
Collaborator
⌛ Testing commit 18c6d39 with merge c508e9f244f9d5f23ba0541e1c3b3b8381355fe7... |
bors
commented
Feb 10, 2020
Collaborator
💥 Test timed out |
Centril
commented
Feb 10, 2020
Contributor
@bors retry |
jonas-schievink
commented
Feb 10, 2020
Contributor
@bors retry queue's stuck? |
bors
commented
Feb 10, 2020
Collaborator
bors added a commit
that referenced
this pull request
Feb 10, 2020
Rollup of 6 pull requests Successful merges: - #68694 (Reduce the number of `RefCell`s in `InferCtxt`.) - #68966 (Improve performance of coherence checks) - #68976 (Make `num::NonZeroX::new` an unstable `const fn`) - #68992 (Correctly parse `mut a @ b`) - #69005 (Small graphviz improvements for the new dataflow framework) - #69006 (parser: Keep current and previous tokens precisely) Failed merges: r? @ghost
bors
commented
Feb 10, 2020
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
RefCells inInferCtxt. #68694 (Reduce the number ofRefCells inInferCtxt.)num::NonZeroX::newan unstableconst fn#68976 (Makenum::NonZeroX::newan unstableconst fn)mut a @ b#68992 (Correctly parsemut a @ b)Failed merges:
r? @ghost