Uh oh!
There was an error while loading. Please reload this page.
Add more regression tests - #69192
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
This looks suspicions... There's no default anywhere, yet logically, we have u64: Foo, hence where T: Foo is discharged, hence u64: Bar, hence T: Bar is discharged, and thus impl<T> Foo for T applies (and so we have overlap).
cc @jonas-schievink (I thought this had been fixed?)
cc @matthewjasper & @nikomatsakis
Centril
commented
Feb 15, 2020
Oops; didn't mean to approve this. Everything except the specialization looks fine modulo nits. |
Centril
commented
Feb 15, 2020
@JohnTitor If you want to get this merged sooner we could also drop the specialization bit and revisit once the discussion has settled. :) If so, r=me with that test removed or a FIXME noting the question added to the specialization test, either at your option. |
JohnTitor
commented
Feb 15, 2020
On my local, the test shows SIGSEGV with old nightly mentioned in that issue so I feel it's worth to add this test. I'll add a FIXME note. |
Centril
commented
Feb 15, 2020
@bors r+ |
bors
commented
Feb 15, 2020
📌 Commit 2f39ec2 has been approved by |
Add more regression tests Closesrust-lang#39618Closesrust-lang#51798Closesrust-lang#62894Closesrust-lang#63952Closesrust-lang#68653 r? @Centril
Add more regression tests Closesrust-lang#39618Closesrust-lang#51798Closesrust-lang#62894Closesrust-lang#63952Closesrust-lang#68653 r? @Centril
Closes#39618
Closes#51798
Closes#62894
Closes#63952
Closes#68653
r? @Centril