Skip to content

Add more regression tests - #69192

Merged
bors merged 6 commits into
rust-lang:masterfrom
JohnTitor:add-tests
Feb 18, 2020
Merged

Add more regression tests#69192
bors merged 6 commits into
rust-lang:masterfrom
JohnTitor:add-tests

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

Closes#39618
Closes#51798
Closes#62894
Closes#63952
Closes#68653

r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2020
Comment threadsrc/test/ui/generic-associated-types/issue-68653.rs Outdated
Comment threadsrc/test/ui/macros/issue-62894.rs Outdated
Comment on lines 14 to 22

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks suspicions... There's no default anywhere, yet logically, we have u64: Foo, hence where T: Foo is discharged, hence u64: Bar, hence T: Bar is discharged, and thus impl<T> Foo for T applies (and so we have overlap).

cc @jonas-schievink (I thought this had been fixed?)
cc @matthewjasper & @nikomatsakis

@Centril

Copy link
Copy Markdown
Contributor

Oops; didn't mean to approve this. Everything except the specialization looks fine modulo nits.

@Centril

Copy link
Copy Markdown
Contributor

@JohnTitor If you want to get this merged sooner we could also drop the specialization bit and revisit once the discussion has settled. :) If so, r=me with that test removed or a FIXME noting the question added to the specialization test, either at your option.

@JohnTitor

Copy link
Copy Markdown
MemberAuthor

If so, r=me with that test removed or a FIXME noting the question added to the specialization test, either at your option.

On my local, the test shows SIGSEGV with old nightly mentioned in that issue so I feel it's worth to add this test. I'll add a FIXME note.

@Centril

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2f39ec2 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2020
Centril added a commit to Centril/rust that referenced this pull request Feb 17, 2020
@CentrilCentril mentioned this pull request Feb 17, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 18, 2020
bors added a commit that referenced this pull request Feb 18, 2020
Rollup of 5 pull requests
Successful merges:
- #69181 (Change const eval to just return the value )
- #69192 (Add more regression tests)
- #69200 (Fix printing of `Yield` terminator)
- #69205 (Allow whitespaces in revision flags)
- #69233 (Clean up E0310 explanation)
Failed merges:
r? @ghost
@bors
bors merged commit 2f39ec2 into rust-lang:masterFeb 18, 2020
@JohnTitor
JohnTitor deleted the add-tests branch February 18, 2020 21:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

4 participants

@JohnTitor@Centril@bors@rust-highfive