Skip to content

Allow whitespaces in revision flags - #69205

Merged
bors merged 1 commit into
rust-lang:masterfrom
JohnTitor:allow-whitespaces
Feb 18, 2020
Merged

Allow whitespaces in revision flags#69205
bors merged 1 commit into
rust-lang:masterfrom
JohnTitor:allow-whitespaces

Conversation

@JohnTitor

@JohnTitorJohnTitor commented Feb 16, 2020•
edited by Mark-Simulacrum
Loading

Copy link
Copy Markdown
Member

Allow whitespaces in revision flags, like // [foo].

Fixes#69183

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2020
Mark-Simulacrum
Mark-Simulacrum reviewed Feb 16, 2020
View reviewed changes
Comment threadsrc/tools/compiletest/src/header.rs Outdated
@Mark-Simulacrum

Mark-Simulacrum commented Feb 16, 2020

Copy link
Copy Markdown
Member

@bors r+

This can be rolled up if CI passes, but it seems not impossible that it'll pick up a new revision somewhere so it might fail.

@bors

bors commented Feb 16, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d1a7ae7 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 16, 2020
@JohnTitor
Rollup merge ofrust-lang#69205- JohnTitor:allow-whitespaces, r=Mark…
c8a2b43
…-Simulacrum
Allow whitespaces in revision flags
Allow whitespaces in revision flags, like `// [foo]`.
Fixesrust-lang#69183
@JohnTitorJohnTitor mentioned this pull request Feb 16, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 18, 2020
@Dylan-DPC
Rollup merge ofrust-lang#69205- JohnTitor:allow-whitespaces, r=Mark…
bea18c7
…-Simulacrum
Allow whitespaces in revision flags
Allow whitespaces in revision flags, like `// [foo]`.
Fixesrust-lang#69183
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 18, 2020
Merged
bors added a commit that referenced this pull request Feb 18, 2020
@bors
Auto merge of#69262- Dylan-DPC:rollup-m6dt9cn, r=Dylan-DPC
e620d0f
Rollup of 5 pull requests
Successful merges:
- #69181 (Change const eval to just return the value )
- #69192 (Add more regression tests)
- #69200 (Fix printing of `Yield` terminator)
- #69205 (Allow whitespaces in revision flags)
- #69233 (Clean up E0310 explanation)
Failed merges:
r? @ghost
@bors
bors merged commit d1a7ae7 into rust-lang:masterFeb 18, 2020
@JohnTitor
JohnTitor deleted the allow-whitespaces branch February 18, 2020 21:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

compiletest: revision-dependent compile-flags are space-sensitive

4 participants

@JohnTitor@Mark-Simulacrum@bors@rust-highfive