Skip to content

Querify object_safety_violations. - #69242

Merged
bors merged 2 commits into
rust-lang:masterfrom
cjgillot:object_violations
Feb 22, 2020
Merged

Querify object_safety_violations.#69242
bors merged 2 commits into
rust-lang:masterfrom
cjgillot:object_violations

Conversation

@cjgillot

@cjgillotcjgillot commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

Split from #69076

r? @Zoxc

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2020
@Zoxc

Zoxc commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Feb 17, 2020

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Feb 17, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 6e15faf with merge 5ed36c19ab9a38b71b3346273fcacb2737750539...

@bors

bors commented Feb 17, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2020
@cjgillot

cjgillot commented Feb 18, 2020

Copy link
Copy Markdown
ContributorAuthor

Failure seems spurious.

@Zoxc

Zoxc commented Feb 18, 2020

Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 6e15faf with merge 4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec...

@bors

bors commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-azure
Build commit: 4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec (4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec)

@rust-timer

rust-timer commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

Queued 4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec with parent 6317721, future comparison URL.

@jonas-schievink

jonas-schievink commented Feb 18, 2020

Copy link
Copy Markdown
Contributor

The is_object_safe query can probably be removed then, and replaced with a method on TyCtxt

@rust-timer

rust-timer commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit 4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec, comparison URL.

@cjgillot

cjgillot commented Feb 19, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Perf seems good. Do we try with is_object_safe removed?

@Zoxc

Zoxc commented Feb 19, 2020

Copy link
Copy Markdown
Contributor

Yes we can probably make is_object_safe a method calling object_safety_violations now.

@cjgillot

cjgillot commented Feb 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Added a commit doing that.

@Zoxc

Zoxc commented Feb 21, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 21, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 310f470 has been approved by Zoxc

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 21, 2020
@bors

bors commented Feb 21, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 310f470 with merge 1d7e818...

@bors

bors commented Feb 22, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing 1d7e818 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Feb 22, 2020
@bors
bors merged commit 1d7e818 into rust-lang:masterFeb 22, 2020
@borsbors mentioned this pull request Feb 22, 2020
Merged
@cjgillot
cjgillot deleted the object_violations branch February 22, 2020 09:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ZoxcZoxc

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjgillot@Zoxc@rust-timer@bors@jonas-schievink@rust-highfive