Uh oh!
There was an error while loading. Please reload this page.
Updates links in various Compiler Error Index entries - #69372
Conversation
rust-highfive
commented
Feb 22, 2020
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
commented
Feb 22, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Feb 22, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
varkor
left a comment
There was a problem hiding this comment.
Could you please squash your commits into one? Thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
yawpitch
commented
Feb 23, 2020
All your suggestions committed and everything squashed. |
rust-highfive
commented
Feb 23, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Formatting fixes Now that I can actually run `python x.py test src/tools/tidy` locally ... my god it takes a long time to compile when you're on a cellular connection. Removing unnecessary whitespaces Updates src/test/ui/json-short.stderr golden test file Fixes test failure by updating the golden file for changes in src/librustc_error_codes/error_codes/E0601.md Update src/librustc_error_codes/error_codes/E0080.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0080.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0080.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0154.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0154.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0661.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0662.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0663.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0664.md Co-Authored-By: varkor <github@varkor.com> Update src/test/ui/json-short.stderr Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0260.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0154.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0260.md Co-Authored-By: varkor <github@varkor.com> Apply suggestions from code review Co-Authored-By: varkor <github@varkor.com> Fixing 1 character over 80 cascade
varkor
commented
Feb 23, 2020
bors
commented
Feb 23, 2020
📌 Commit c103a16 has been approved by |
Updates links in various Compiler Error Index entries Currently many of the links in the online https://doc.rust-lang.org/error-index.html are not clickable, and many of them don't resolve correctly as they point to older versions of rustbyexample and the reference.
Rollup of 5 pull requests Successful merges: - #69372 (Updates links in various Compiler Error Index entries) - #69385 (Relax str::get_unchecked precondition to permit empty slicing) - #69386 (Fix minor error in `MaybeUninit::get_mut()` doc example) - #69394 (Clean up E0367 explanation) - #69405 (docs: Stdin::read_line: mention the appending) Failed merges: r? @ghost
Currently many of the links in the online https://doc.rust-lang.org/error-index.html are not clickable, and many of them don't resolve correctly as they point to older versions of rustbyexample and the reference.