Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #69424
Merged
Merged
Conversation
Prior to this commit, `str` documented that `get_unchecked` had the precondition that "`begin` must come before `end`". This would appear to prohibit empty slices (i.e. begin == end). In practice, get_unchecked is called often with empty slices. Let's relax the precondition so as to allow them.
Suggested by @ametisf in rust-lang#65948 (comment) Co-Authored-By: Frantisek Fladung <fladufra@fel.cvut.cz>
Formatting fixes Now that I can actually run `python x.py test src/tools/tidy` locally ... my god it takes a long time to compile when you're on a cellular connection. Removing unnecessary whitespaces Updates src/test/ui/json-short.stderr golden test file Fixes test failure by updating the golden file for changes in src/librustc_error_codes/error_codes/E0601.md Update src/librustc_error_codes/error_codes/E0080.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0080.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0080.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0154.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0154.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0661.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0662.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0663.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0664.md Co-Authored-By: varkor <github@varkor.com> Update src/test/ui/json-short.stderr Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0260.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0154.md Co-Authored-By: varkor <github@varkor.com> Update src/librustc_error_codes/error_codes/E0260.md Co-Authored-By: varkor <github@varkor.com> Apply suggestions from code review Co-Authored-By: varkor <github@varkor.com> Fixing 1 character over 80 cascade
Updates links in various Compiler Error Index entries Currently many of the links in the online https://doc.rust-lang.org/error-index.html are not clickable, and many of them don't resolve correctly as they point to older versions of rustbyexample and the reference.
… r=nagisa Relax str::get_unchecked precondition to permit empty slicing Prior to this commit, `str` documented that `get_unchecked` had the precondition that "`begin` must come before `end`". This would appear to prohibit empty slices (i.e. begin == end). In practice, get_unchecked is called often with empty slices. Let's relax the precondition so as to allow them.
…cs_replace_chunk_with_windows, r=Dylan-DPC Fix minor error in `MaybeUninit::get_mut()` doc example In the `MaybeUninit::get_mut()` example I wanted to assert that the slice was sorted and mistakenly used `.chunks(2)` rather than `.windows(2)` to assert it, as @ametisf pointed out in rust-lang#65948 (comment) . This fixes it.
…an-DPC Clean up E0367 explanation r? @Dylan-DPC
…=joshtriplett docs: Stdin::read_line: mention the appending The fact that `stdin().read_line()` is an [unpleasant](https://twitter.com/Michcioperz/status/1231646797661167617?s=20) [footgun](https://rustbattle.net/battle/straight-finch-8-e4f4). Let's make it clearer in the documentation.
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors p=1100 Bypass the treeclosed. |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors try |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors r+ |
bors
commented
Feb 24, 2020
Collaborator
📌 Commit ba3fee6 has been approved by |
bors
commented
Feb 24, 2020
Collaborator
⌛ Testing commit ba3fee6 with merge ff9231a9cf2adb0b616aee7250314f3263bf0b73... |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors try- |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors r- |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors retry |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors r+ p=1100 |
bors
commented
Feb 24, 2020
Collaborator
📌 Commit ba3fee6 has been approved by |
bors
commented
Feb 24, 2020
Collaborator
⌛ Testing commit ba3fee6 with merge 9eee1528a08b2ce0ac3ca4ffe5813ec3b9e1b4b2... |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors r- retry RCS is not up to date. |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors r+ p=1100 |
bors
commented
Feb 24, 2020
Collaborator
📌 Commit ba3fee6 has been approved by |
Collaborator
⌛ Testing commit ba3fee6 with merge 1926a697a2d7e610bd0ca7363854f1bb38dc33cf... |
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors retry |
bors
commented
Feb 24, 2020
Collaborator
emilyalbini
commented
Feb 24, 2020
MemberAuthor
@bors treeclosed- |
bors
commented
Feb 24, 2020
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
MaybeUninit::get_mut()doc example #69386 (Fix minor error inMaybeUninit::get_mut()doc example)Failed merges:
r? @ghost