Make error message clearer about creating new module by kornelski · Pull Request #69520 · rust-lang/rust

kornelski · 2020-02-27T16:29:56Z

This is a partial improvement for #69492

rust-highfive · 2020-02-27T16:30:00Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2020-02-27T16:47:56Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-27T16:30:30.8869384Z ========================== Starting Command Output ===========================
2020-02-27T16:30:30.8873430Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/facc7d7a-4c9d-4351-a2b9-7322dd38115f.sh
2020-02-27T16:30:30.8874280Z 2020-02-27T16:30:30.8879664Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-27T16:30:30.8897168Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69520/merge to s
2020-02-27T16:30:30.8900070Z Task : Get sources
2020-02-27T16:30:30.8900300Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-27T16:30:30.8900571Z Version : 1.0.0
2020-02-27T16:30:30.8900880Z Author : Microsoft
---
2020-02-27T16:30:32.1732279Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-27T16:30:32.1738686Z ##[command]git config gc.auto 0
2020-02-27T16:30:32.1742020Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-27T16:30:32.1745101Z ##[command]git config --get-all http.proxy
2020-02-27T16:30:32.1752114Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69520/merge:refs/remotes/pull/69520/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

cramertj · 2020-02-27T18:26:31Z

r=me with travis fixed up.

kornelski · 2020-03-04T18:16:19Z

@cramertj it's ready

cramertj · 2020-03-04T22:34:35Z

@bors r+

bors · 2020-03-04T22:34:37Z

📌 Commit 96b3261 has been approved by cramertj

Make error message clearer about creating new module This is a partial improvement for rust-lang#69492

@ghost

Rollup of 10 pull requests Successful merges: - #69520 (Make error message clearer about creating new module) - #69589 (ast: `Mac`/`Macro` -> `MacCall`) - #69614 (`delay_span_bug` when codegen cannot select obligation) - #69641 (Update books) - #69674 (Rename DefKind::Method and TraitItemKind::Method ) - #69697 (Add explanation for E0380) - #69698 (Use associated constants of integer types) - #69705 (Toolstate: remove redundant beta-week check.) - #69711 (Update macros.rs: fix documentation typo.) - #69713 (more clippy cleanups) Failed merges: r? @ghost

bors · 2020-03-05T10:19:05Z

⌛ Testing commit 96b3261 with merge 452aa16a0c003085036b35612322d8c188fe56e9...

rust-highfive · 2020-03-05T10:26:49Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-03-05T10:27:01Z

💔 Test failed - checks-azure

JohnTitor · 2020-03-05T10:28:49Z

Seems spurious.
@bors retry

bors · 2020-03-05T10:33:02Z

⌛ Testing commit 96b3261 with merge 846b743f0826716f1b90bface26638ac8d3f4095...

Make error message clearer about creating new module This is a partial improvement for rust-lang#69492

JohnTitor · 2020-03-05T10:46:38Z

@bors retry rolled up

bors · 2020-03-05T10:51:04Z

⌛ Testing commit 96b3261 with merge 1e3ca884da0cdf0cab620bc98f6c85a50d776733...

JohnTitor · 2020-03-05T10:56:10Z

Sorry for the noise...
@bors retry rolled up

JohnTitor · 2020-03-05T13:50:15Z

Failed in #69730 (comment)
@bors r-

kornelski · 2020-03-07T12:09:44Z

I've rebased it on master just in case

kornelski · 2020-03-07T12:12:31Z

Ahh, it needed message for Windows-only test that "bless" has skipped. I've fixed that.

cramertj · 2020-03-09T21:39:11Z

@bors r+

bors · 2020-03-09T21:39:12Z

📌 Commit 8de1ec9 has been approved by cramertj

bors · 2020-03-09T21:39:13Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@ghost

Rollup of 7 pull requests Successful merges: - #67335 (Refactor the `Qualif` trait) - #69122 (Backtrace Debug tweaks) - #69520 (Make error message clearer about creating new module) - #69738 (More Method -> AssocFn renaming) - #69867 (Add long error explanation for E0628 ) - #69989 (resolve/hygiene: `macro_rules` are not "legacy") - #70036 (Make article_and_description primarily use def_kind) Failed merges: r? @ghost

rust-highfive assigned cramertj Feb 27, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2020

kornelski force-pushed the e69492 branch from cf15005 to 96b3261Compare March 1, 2020 13:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2020

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
Rollup merge ofrust-lang#69520- kornelski:e69492, r=cramertj
91d521e
Make error message clearer about creating new module This is a partial improvement for rust-lang#69492

JohnTitor mentioned this pull request Mar 5, 2020
Rollup of 10 pull requests #69724
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
Rollup merge ofrust-lang#69520- kornelski:e69492, r=cramertj
bb126e1
Make error message clearer about creating new module This is a partial improvement for rust-lang#69492

JohnTitor mentioned this pull request Mar 5, 2020
Rollup of 8 pull requests #69730
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2020

kornelski force-pushed the e69492 branch from 96b3261 to 945d5b0Compare March 7, 2020 12:08

Make error message clearer about creating new module
8de1ec9

kornelski force-pushed the e69492 branch from 945d5b0 to 8de1ec9Compare March 7, 2020 12:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2020

Dylan-DPC-zz mentioned this pull request Mar 16, 2020
Rollup of 7 pull requests #70040
Merged

bors merged commit 1685264 into rust-lang:masterMar 16, 2020

kornelski deleted the e69492 branch March 16, 2020 18:04

Uh oh!

Uh oh!

Conversation

kornelski commented Feb 27, 2020

Uh oh!

rust-highfive commented Feb 27, 2020

Uh oh!

rust-highfive commented Feb 27, 2020

Uh oh!

cramertj commented Feb 27, 2020

Uh oh!

kornelski commented Mar 4, 2020

Uh oh!

cramertj commented Mar 4, 2020

Uh oh!

bors commented Mar 4, 2020

Uh oh!

bors commented Mar 5, 2020

Uh oh!

rust-highfive commented Mar 5, 2020

Uh oh!

bors commented Mar 5, 2020

Uh oh!

JohnTitor commented Mar 5, 2020

Uh oh!

bors commented Mar 5, 2020

Uh oh!

JohnTitor commented Mar 5, 2020

Uh oh!

bors commented Mar 5, 2020

Uh oh!

JohnTitor commented Mar 5, 2020

Uh oh!

JohnTitor commented Mar 5, 2020

Uh oh!

kornelski commented Mar 7, 2020

Uh oh!

kornelski commented Mar 7, 2020

Uh oh!

cramertj commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants