Uh oh!
There was an error while loading. Please reload this page.
Rename DefKind::Method and TraitItemKind::Method - #69674
Merged
Merged
Conversation
Centril
commented
Mar 3, 2020
Contributor
bors
commented
Mar 3, 2020
Collaborator
📌 Commit 3aeb9f0 has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 5, 2020
Rename DefKind::Method and TraitItemKind::Method r? @eddyb, @Centril, or @matthewjasper cc rust-lang#69498rust-lang#60163
eddyb
reviewed
Mar 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
eddyb
reviewed
Mar 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
eddyb
reviewed
Mar 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
eddyb
reviewed
Mar 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
bors added a commit
that referenced
this pull request
Mar 5, 2020
Rollup of 10 pull requests Successful merges: - #69520 (Make error message clearer about creating new module) - #69589 (ast: `Mac`/`Macro` -> `MacCall`) - #69614 (`delay_span_bug` when codegen cannot select obligation) - #69641 (Update books) - #69674 (Rename DefKind::Method and TraitItemKind::Method ) - #69697 (Add explanation for E0380) - #69698 (Use associated constants of integer types) - #69705 (Toolstate: remove redundant beta-week check.) - #69711 (Update macros.rs: fix documentation typo.) - #69713 (more clippy cleanups) Failed merges: r? @ghost
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 5, 2020
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 6, 2020
Rename DefKind::Method and TraitItemKind::Method r? @eddyb, @Centril, or @matthewjasper cc rust-lang#69498rust-lang#60163
bors added a commit
that referenced
this pull request
Mar 6, 2020
Rollup of 6 pull requests Successful merges: - #69656 (Use .next() instead of .nth(0) on iterators.) - #69674 (Rename DefKind::Method and TraitItemKind::Method ) - #69676 (Pass correct place to `discriminant_switch_effect`) - #69706 (Use subslice patterns in slice methods) - #69714 (Make PlaceRef take just one lifetime) - #69727 (Avoid using `unwrap()` in suggestions) Failed merges: - #69589 (ast: `Mac`/`Macro` -> `MacCall`) - #69680 (rustc_expand: Factor out `Annotatable::into_tokens` to a separate method) r? @ghost
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 6, 2020
Rename DefKind::Method and TraitItemKind::Method r? @eddyb, @Centril, or @matthewjasper cc rust-lang#69498rust-lang#60163
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 7, 2020
Rename DefKind::Method and TraitItemKind::Method r? @eddyb, @Centril, or @matthewjasper cc rust-lang#69498rust-lang#60163
Centril
commented
Mar 7, 2020
Contributor
Failed in #69795 (comment) due to toolstate week, @bors r- |
matthewjasper
commented
Mar 12, 2020
Contributor
toolstate week is over @bors r+ |
bors
commented
Mar 12, 2020
Collaborator
📌 Commit 3aeb9f0 has been approved by |
bors added a commit
that referenced
this pull request
Mar 12, 2020
Rollup of 10 pull requests Successful merges: - #68899 (Add Display and Error impls for proc_macro::LexError) - #69011 (Document unsafe blocks in core::fmt) - #69674 (Rename DefKind::Method and TraitItemKind::Method ) - #69705 (Toolstate: remove redundant beta-week check.) - #69722 (Tweak output for invalid negative impl AST errors) - #69747 (Rename rustc guide) - #69792 (Implement Error for TryReserveError) - #69830 (miri: ICE on invalid terminators) - #69921 (rustdoc: remove unused import) - #69945 (update outdated comment) Failed merges: r? @ghost
JohnTitor added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Mar 12, 2020
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Mar 12, 2020
Rustup to rust-lang/rust#69674 changelog: none
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 12, 2020
Changes: ```` Rustup to rust-lang#69674 Use visit_place Check for mutation Only fires on temporaries Extend `redundant_clone` to the case that cloned value is not consumed add CR feedback Improve documentation Use `edition:2018` flag more widely Update tests/ui/needless_doc_main.rs Move links to the end of each chapter on adding_lints Move links to the end of each chapter on CONTRIBUTING Clean-up adding_lints.md Clean-up CONTRIBUTING.md needless_doc_main: only check rust code Use `node_type_opt` over `node_type` Fix doc Fix ICE with trivial_bounds feature clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy. update rust-lang.github.io to rustc-dev-guide.rust-lang.org Improve placeholder in map_unit_fn Fix match single binding when in a let stmt Improve error messages for {option,result}_map_unit_fn Mention the setup instructions in CONTRIBUTING redundant_pattern: take binding (ref, ref mut) into account in suggestion. check_pat: delay creation of the "normal" vec until we reach the branch where is is actually needed deps: bump itertools 0.8 -> 0.9 add lint on File::read_to_string and File::read_to_end transition rustc-guide to rustc-dev-guide Rename macro_use_import -> macro_use_imports warn on macro_use attr Fix deploy script for tag deploys ```` Fixesrust-lang#69957
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 14, 2020
More Method -> AssocFn renaming r? @Centril@eddyb cc rust-lang#60163 Blocked on rust-lang#69674
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 16, 2020
More Method -> AssocFn renaming r? @Centril@eddyb cc rust-lang#60163 Blocked on rust-lang#69674
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 23, 2020
Replace some desc logic in librustc_lint with article_and_desc r? @eddyb@Centril@matthewjasper Followup to rust-lang#69674 Blocked on rust-lang#69498
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 23, 2020
Replace some desc logic in librustc_lint with article_and_desc r? @eddyb@Centril@matthewjasper Followup to rust-lang#69674 Blocked on rust-lang#69498
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 23, 2020
Replace some desc logic in librustc_lint with article_and_desc r? @eddyb@Centril@matthewjasper Followup to rust-lang#69674 Blocked on rust-lang#69498
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Changes: ```` Rustup to rust-lang/rust#69674 Use visit_place Check for mutation Only fires on temporaries Extend `redundant_clone` to the case that cloned value is not consumed add CR feedback Improve documentation Use `edition:2018` flag more widely Update tests/ui/needless_doc_main.rs Move links to the end of each chapter on adding_lints Move links to the end of each chapter on CONTRIBUTING Clean-up adding_lints.md Clean-up CONTRIBUTING.md needless_doc_main: only check rust code Use `node_type_opt` over `node_type` Fix doc Fix ICE with trivial_bounds feature clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy. update rust-lang.github.io to rustc-dev-guide.rust-lang.org Improve placeholder in map_unit_fn Fix match single binding when in a let stmt Improve error messages for {option,result}_map_unit_fn Mention the setup instructions in CONTRIBUTING redundant_pattern: take binding (ref, ref mut) into account in suggestion. check_pat: delay creation of the "normal" vec until we reach the branch where is is actually needed deps: bump itertools 0.8 -> 0.9 add lint on File::read_to_string and File::read_to_end transition rustc-guide to rustc-dev-guide Rename macro_use_import -> macro_use_imports warn on macro_use attr Fix deploy script for tag deploys ```` Fixes #69957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @eddyb, @Centril, or @matthewjasper
cc #69498#60163