Uh oh!
There was an error while loading. Please reload this page.
use is_empty() instead of len() == x to determine if structs are empty. - #69551
Merged
Conversation
Mark-Simulacrum
left a comment
Member
There was a problem hiding this comment.
I almost want a "has_items()" but that seems like a pain to add, and shouldn't block this.
r=me with nit fixed
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
commented
Feb 28, 2020
Member
@bors r+ rollup |
bors
commented
Feb 28, 2020
Collaborator
📌 Commit 1622b6e has been approved by |
bors added a commit
that referenced
this pull request
Feb 29, 2020
Rollup of 6 pull requests Successful merges: - #69477 (docs: add mention of async blocks in move keyword docs) - #69504 (Use assert_ne in hash tests) - #69546 (use to_vec() instead of .iter().cloned().collect() to convert slices to vecs.) - #69551 (use is_empty() instead of len() == x to determine if structs are empty.) - #69563 (Fix no_std detection for target triples) - #69567 (use .to_string() instead of format!() macro to create strings) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.