Uh oh!
There was an error while loading. Please reload this page.
Use assert_ne in hash tests - #69504
Merged
Merged
Conversation
rust-highfive
commented
Feb 27, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
LukasKalbertodt
commented
Feb 28, 2020
Contributor
@bors r+ |
bors
commented
Feb 28, 2020
Collaborator
📌 Commit 290ed02 has been approved by |
Dylan-DPC-zz
commented
Feb 29, 2020
@bors rollup |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 29, 2020
…LukasKalbertodt Use assert_ne in hash tests The hash tests were written before the assert_ne macro was added to the standard library. The assert_ne macro provides better output in case of a failure.
bors added a commit
that referenced
this pull request
Feb 29, 2020
Rollup of 6 pull requests Successful merges: - #69477 (docs: add mention of async blocks in move keyword docs) - #69504 (Use assert_ne in hash tests) - #69546 (use to_vec() instead of .iter().cloned().collect() to convert slices to vecs.) - #69551 (use is_empty() instead of len() == x to determine if structs are empty.) - #69563 (Fix no_std detection for target triples) - #69567 (use .to_string() instead of format!() macro to create strings) Failed merges: r? @ghost
bors added a commit
that referenced
this pull request
Feb 29, 2020
Rollup of 7 pull requests Successful merges: - #69504 (Use assert_ne in hash tests) - #69571 (remove unneeded .as_ref() calls.) - #69572 (use .iter() instead of .into_iter() on references) - #69581 (fix aliasing violation in align_to_mut) - #69582 (improve transmute and Vec::from_raw_parts docs) - #69584 (Correct comment to match behavior) - #69587 (rustc_parse: Tweak the function parameter name check) Failed merges: r? @ghost
jonas-schievink
commented
Mar 1, 2020
Contributor
It looks like this was only partially merged in the rollup, 14495ed is still missing. Not sure how that happened. |
Dylan-DPC-zz
commented
Mar 1, 2020
yes the r+ just points to the first commit |
JohnTitor
commented
Mar 1, 2020
Member
@MichaelMcDonnell Could you rebase? |
MichaelMcDonnellforce-pushed
the
hash_assert_ne
branch
from
March 1, 2020 16:13
14495ed to
87327ebCompareMichaelMcDonnell
commented
Mar 1, 2020
ContributorAuthor
Ok @JohnTitor I've rebased. |
JohnTitor
commented
Mar 1, 2020
Member
Thanks! Let's check... |
bors
commented
Mar 1, 2020
Collaborator
📌 Commit 87327eb has been approved by |
bors added a commit
that referenced
this pull request
Mar 1, 2020
Rollup of 7 pull requests Successful merges: - #69504 (Use assert_ne in hash tests) - #69554 (Cleanup e0374) - #69568 (Clarify explanation of Vec<T> 'fn resize') - #69569 (simplify boolean expressions) - #69577 (Clean up E0375 explanation) - #69598 (rustdoc: HTML escape crate version) - #69607 (Clean up E0376 explanation) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash tests were written before the assert_ne macro was added to the standard library. The assert_ne macro provides better output in case of a failure.