Skip to content

fix aliasing violation in align_to_mut - #69581

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:align_to_mut
Feb 29, 2020
Merged

fix aliasing violation in align_to_mut#69581
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:align_to_mut

Conversation

@RalfJung

Copy link
Copy Markdown
Member

Fixes#68549

I decided to add the testcase here to make it all one PR, but if you prefer I can also add that test case in the Miri repo instead.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 29, 2020
@rust-highfive

This comment has been minimized.

@Centril

Copy link
Copy Markdown
Contributor

r? @Centril@bors r+

@bors

bors commented Feb 29, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit c34451f has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 29, 2020
@nagisa

Copy link
Copy Markdown
Member

Thanks for figuring this out @RalfJung

bors added a commit that referenced this pull request Feb 29, 2020
Rollup of 7 pull requests
Successful merges:
- #69504 (Use assert_ne in hash tests)
- #69571 (remove unneeded .as_ref() calls.)
- #69572 (use .iter() instead of .into_iter() on references)
- #69581 (fix aliasing violation in align_to_mut)
- #69582 (improve transmute and Vec::from_raw_parts docs)
- #69584 (Correct comment to match behavior)
- #69587 (rustc_parse: Tweak the function parameter name check)
Failed merges:
r? @ghost
@bors
bors merged commit 02381db into rust-lang:masterFeb 29, 2020
@RalfJung
RalfJung deleted the align_to_mut branch March 1, 2020 09:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

miri:error printing the return value of align_to_mut

6 participants

@RalfJung@rust-highfive@Centril@bors@nagisa@shepmaster