Skip to content

Rollup of 7 pull requests - #69612

Merged
bors merged 16 commits into
rust-lang:masterfrom
Dylan-DPC-zz:rollup-f180gcc
Mar 1, 2020
Merged

Rollup of 7 pull requests#69612
bors merged 16 commits into
rust-lang:masterfrom
Dylan-DPC-zz:rollup-f180gcc

Conversation

@Dylan-DPC-zz

Copy link
Copy Markdown

Successful merges:

Failed merges:

r? @ghost

JOE1994and others added 16 commits February 28, 2020 19:28
1. Clarified on what should implement 'Clone' trait.
2. Minor grammar fix:
to be able clone => to be able to clone
Following suggestion from @jonas-schievink
Co-Authored-By: Jonas Schievink <jonasschievink@gmail.com>
Removed trailing whitespace which caused to fail pretty-check
As `--crate-version` accepts arbitrary strings they need to be escaped.
…LukasKalbertodt
Use assert_ne in hash tests
The hash tests were written before the assert_ne macro was added to the standard library. The assert_ne macro provides better output in case of a failure.
Clarify explanation of Vec<T> 'fn resize'
1. Clarified on what should implement `Clone` trait.
2. Minor grammar fix:
to be able clone => to be able **to** clone
…e, r=GuillaumeGomez
rustdoc: HTML escape crate version
As `--crate-version` accepts arbitrary strings they need to be escaped.
r? @GuillaumeGomez
@Dylan-DPC-zz

Copy link
Copy Markdown
Author

@bors r+ rollup=never p=7

@bors

bors commented Mar 1, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d3a5a5d has been approved by Dylan-DPC

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 1, 2020
@Dylan-DPC-zzDylan-DPC-zz added the rollup A PR which is a rollup label Mar 1, 2020
@bors

bors commented Mar 1, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d3a5a5d with merge beac68a...

@bors

bors commented Mar 1, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing beac68a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 1, 2020
@bors
bors merged commit beac68a into rust-lang:masterMar 1, 2020
@borsbors mentioned this pull request Mar 1, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Dylan-DPC-zz@bors@JOE1994@matthiaskrgr@GuillaumeGomez@ollie27@MichaelMcDonnell@Dylan-DPC