Skip to content

Tweak output for invalid negative impl errors - #69649

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:negative-impl-span
Mar 23, 2020
Merged

Tweak output for invalid negative impl errors#69649
bors merged 1 commit into
rust-lang:masterfrom
estebank:negative-impl-span

Conversation

@estebank

@estebankestebank commented Mar 2, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up to #69722. Tweak negative impl errors emitted in the HIR:

error[E0192]: invalid negative impl
--> $DIR/E0192.rs:9:6
|
LL | impl !Trait for Foo { }
| ^^^^^^
|
= note: negative impls are only allowed for auto traits, like `Send` and `Sync`

@rust-highfive

rust-highfive commented Mar 2, 2020

Copy link
Copy Markdown
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril

Centril commented Mar 3, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

r? @Centril

High level reviewing notes before doing a deeper review:

  • Let's split this PR into two parts, one for AST and one for HIR -- I would like to review the HIR parts in isolation as well as making sure that they don't regress perf.
  • Please avoid changing random_field: _s in favor of .. when pattern matching records, especially when it comes to visitors. The use of random_field: _ is typically intentional to make sure that we are forced to handle new cases should we add more fields.
  • Please also add a PR description.

@estebank

estebank commented Mar 5, 2020

Copy link
Copy Markdown
ContributorAuthor

AST part in #69722

@CentrilCentril added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2020
@bors

This comment has been minimized.

Sign in to view
@Dylan-DPC-zz

This comment has been minimized.

Sign in to view
@Dylan-DPC-zzDylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 21, 2020
@estebank

estebank commented Mar 23, 2020

Copy link
Copy Markdown
ContributorAuthor

@Centril rebased on top of master and this PR only has the HIR changes.

@estebankestebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2020
Centril
Centril reviewed Mar 23, 2020
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with these comments addressed and clean perf.

Comment threadsrc/librustc_typeck/check/wfcheck.rs Outdated
Comment threadsrc/librustc_typeck/check/wfcheck.rs Outdated
@Centril

Centril commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 19d0186f3cead8ed2cc3741f6c2e2fbb180e81d2 with merge 12e42227516ca02418f6dbea278da1e4c0dd14b3...

@rust-highfive

This comment has been minimized.

Sign in to view
@bors

bors commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2020
@estebank

estebank commented Mar 23, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit b8f9866 with merge a7111c6f0c00e55b69e1eb62c1f04775705b4e0e...

@bors

bors commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-azure
Build commit: a7111c6f0c00e55b69e1eb62c1f04775705b4e0e (a7111c6f0c00e55b69e1eb62c1f04775705b4e0e)

@rust-timer

rust-timer commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

Queued a7111c6f0c00e55b69e1eb62c1f04775705b4e0e with parent e4b01c7, future comparison URL.

@rust-timer

rust-timer commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit a7111c6f0c00e55b69e1eb62c1f04775705b4e0e, comparison URL.

@Centril

Centril commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

Seems like noise, @bors r+

@bors

bors commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit b8f9866 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2020
@bors

bors commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b8f9866 with merge 8549cfe...

@bors

bors commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 8549cfe to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 23, 2020
@bors
bors merged commit 8549cfe into rust-lang:masterMar 23, 2020
@borsbors mentioned this pull request Mar 23, 2020
Merged
7 tasks
@estebank
estebank deleted the negative-impl-span branch November 9, 2023 05:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@estebank@rust-highfive@Centril@bors@Dylan-DPC-zz@rust-timer@ecstatic-morse