Skip to content

Tweak output for invalid negative impl AST errors - #69722

Merged
bors merged 7 commits into
rust-lang:masterfrom
estebank:negative-impl-span-ast
Mar 12, 2020
Merged

Tweak output for invalid negative impl AST errors#69722
bors merged 7 commits into
rust-lang:masterfrom
estebank:negative-impl-span-ast

Conversation

@estebank

@estebankestebank commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Use more accurate spans for negative impl errors.

r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2020
@estebankestebank mentioned this pull request Mar 5, 2020
Merged
Centril
Centril reviewed Mar 5, 2020
View reviewed changes
Comment threadsrc/librustc_ast_passes/ast_validation.rs
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_parse/parser/item.rs Outdated
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020
estebank
estebank commented Mar 5, 2020
View reviewed changes
Comment threadsrc/test/ui/syntax-trait-polarity.stderr Outdated
@estebankestebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2020
Centril
Centril reviewed Mar 6, 2020
View reviewed changes
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
@estebank
estebankforce-pushed the negative-impl-span-ast branch from 44dd91d to 53cfb23CompareMarch 6, 2020 19:45
@estebank
estebankforce-pushed the negative-impl-span-ast branch from 53cfb23 to f483032CompareMarch 6, 2020 19:59
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2020
@estebankestebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2020
Centril
Centril reviewed Mar 11, 2020
View reviewed changes
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
Comment threadsrc/librustc_ast_passes/ast_validation.rs Outdated
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2020
@estebankestebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2020
@Centril

Centril commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

Thanks, @bors r+

@bors

bors commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 7ee1b47 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2020
@Centril
Rollup merge ofrust-lang#69722- estebank:negative-impl-span-ast, r=…
3681df6
…Centril
Tweak output for invalid negative impl AST errors
Use more accurate spans for negative `impl` errors.
r? @Centril
@CentrilCentril mentioned this pull request Mar 11, 2020
Closed
@CentrilCentril mentioned this pull request Mar 12, 2020
Merged
bors added a commit that referenced this pull request Mar 12, 2020
@bors
Auto merge of#69950- Centril:rollup-xh0hmvx, r=Centril
54b7d21
Rollup of 10 pull requests
Successful merges:
- #68899 (Add Display and Error impls for proc_macro::LexError)
- #69011 (Document unsafe blocks in core::fmt)
- #69674 (Rename DefKind::Method and TraitItemKind::Method )
- #69705 (Toolstate: remove redundant beta-week check.)
- #69722 (Tweak output for invalid negative impl AST errors)
- #69747 (Rename rustc guide)
- #69792 (Implement Error for TryReserveError)
- #69830 (miri: ICE on invalid terminators)
- #69921 (rustdoc: remove unused import)
- #69945 (update outdated comment)
Failed merges:
r? @ghost
@bors
bors merged commit 4f7fc5a into rust-lang:masterMar 12, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2020
@bors
Auto merge ofrust-lang#69649- estebank:negative-impl-span, r=Centril
8549cfe
Tweak output for invalid negative impl errors
Follow up to rust-lang#69722. Tweak negative impl errors emitted in the HIR:
```
error[E0192]: invalid negative impl
--> $DIR/E0192.rs:9:6
|
LL | impl !Trait for Foo { }
| ^^^^^^
|
= note: negative impls are only allowed for auto traits, like `Send` and `Sync`
```
@estebank
estebank deleted the negative-impl-span-ast branch November 9, 2023 05:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estebank@Centril@bors@rust-highfive