Added doc on keyword Pub. · Pull Request #69723 · rust-lang/rust

ghost · 2020-03-05T00:17:30Z

Hi, this is my first pull request. I hope it's OK. Please let me know if it would benefit from any changes. Thank you.

Dylan-DPC-zz · 2020-03-05T00:26:18Z

Mark-Simulacrum · 2020-03-05T02:58:40Z

It looks like you accidentally created the file at the top-level directory, instead of editing the existing file at src/libstd/keyword_docs.rs. Could you try to move the new file atop the old one? Something like mv keywords_docs.rs src/libstd/keyword_docs.rs should do the right thing. Afterwards you'd commit and push to this branch.

Let me know if I can help further!

ghost · 2020-03-06T19:14:54Z

Hi,
Thank you for your feedback! I'm still getting used to git and I appreciate your patience.

rust-highfive · 2020-03-06T20:41:08Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-06T19:11:30.9352740Z ========================== Starting Command Output ===========================
2020-03-06T19:11:30.9355325Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/69915d2d-019f-45c9-9711-71c36d4623c5.sh
2020-03-06T19:11:30.9355613Z 2020-03-06T19:11:30.9358977Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-06T19:11:30.9378813Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-06T19:11:30.9382143Z Task : Get sources
2020-03-06T19:11:30.9382466Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-06T19:11:30.9382778Z Version : 1.0.0
2020-03-06T19:11:30.9382990Z Author : Microsoft
---
2020-03-06T19:11:31.9300275Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-06T19:11:31.9306173Z ##[command]git config gc.auto 0
2020-03-06T19:11:31.9309901Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-06T19:11:31.9313346Z ##[command]git config --get-all http.proxy
2020-03-06T19:11:31.9319745Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69723/merge:refs/remotes/pull/69723/merge
---
2020-03-06T20:09:51.5766263Z .................................................................................................... 1700/9732
2020-03-06T20:09:56.2176276Z .................................................................................................... 1800/9732
2020-03-06T20:10:08.0065054Z ..........................................................i......................................... 1900/9732
2020-03-06T20:10:15.5310367Z .................................................................................................... 2000/9732
2020-03-06T20:10:29.4827295Z ................................................iiiii............................................... 2100/9732
2020-03-06T20:10:39.7101479Z .................................................................................................... 2300/9732
2020-03-06T20:10:41.9974629Z .................................................................................................... 2400/9732
2020-03-06T20:10:45.4562491Z .................................................................................................... 2500/9732
2020-03-06T20:11:07.0195237Z .................................................................................................... 2600/9732
---
2020-03-06T20:13:48.1399185Z .........i...............i.......................................................................... 5000/9732
2020-03-06T20:13:57.8999767Z .................................................................................................... 5100/9732
2020-03-06T20:14:02.7184646Z ....................................................i............................................... 5200/9732
2020-03-06T20:14:10.9366767Z .................................................................................................... 5300/9732
2020-03-06T20:14:18.0654711Z ................................ii.ii........i...i.................................................. 5400/9732
2020-03-06T20:14:26.0442195Z .................................................................................................... 5600/9732
2020-03-06T20:14:35.2265729Z .................................................................................................... 5700/9732
2020-03-06T20:14:42.1388151Z .......................i............................................................................ 5800/9732
2020-03-06T20:14:47.6358294Z .................................................................................................... 5900/9732
2020-03-06T20:14:47.6358294Z .................................................................................................... 5900/9732
2020-03-06T20:14:58.5362909Z .................................................................................................... 6000/9732
2020-03-06T20:15:08.9894431Z ...............ii...i..ii...........i............................................................... 6100/9732
2020-03-06T20:15:25.4970977Z .................................................................................................... 6300/9732
2020-03-06T20:15:29.8888080Z .................................................................................................... 6400/9732
2020-03-06T20:15:40.9115238Z ..............................................i...ii................................................ 6500/9732
2020-03-06T20:15:48.7038095Z .................................................................................................... 6600/9732
---
2020-03-06T20:17:48.7249097Z .................................................................................................... 7700/9732
2020-03-06T20:17:53.8265902Z .................................................................................................... 7800/9732
2020-03-06T20:17:58.5688911Z .................................................................................................... 7900/9732
2020-03-06T20:18:06.8301345Z ..............i..................................................................................... 8000/9732
2020-03-06T20:18:15.3595902Z ...............................................................iiiiiiiii.i.......................... 8100/9732
2020-03-06T20:18:30.0746492Z ......i......i...................................................................................... 8300/9732
2020-03-06T20:18:35.2979806Z .................................................................................................... 8400/9732
2020-03-06T20:18:48.6471788Z .................................................................................................... 8500/9732
2020-03-06T20:18:57.9032248Z .................................................................................................... 8600/9732
---
2020-03-06T20:21:16.9142844Z finished in 7.169
2020-03-06T20:21:16.9337602Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-06T20:21:17.1376525Z 2020-03-06T20:21:17.1377613Z running 178 tests
2020-03-06T20:21:20.0552219Z iiii......i...........ii..iiii...i....i...........i............i..i..................i....i......... 100/178
2020-03-06T20:21:22.2817992Z ...i.i.i...iii..iiiiiiiiiiiiiiii.......................iii............ii......
2020-03-06T20:21:22.2824333Z 2020-03-06T20:21:22.2827974Z finished in 5.349
2020-03-06T20:21:22.3032200Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-06T20:21:22.4689329Z ---
2020-03-06T20:21:24.3656373Z finished in 2.062
2020-03-06T20:21:24.3856405Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-06T20:21:24.5445104Z 2020-03-06T20:21:24.5446584Z running 9 tests
2020-03-06T20:21:24.5447698Z iiiiiiiii
2020-03-06T20:21:24.5450333Z 2020-03-06T20:21:24.5450520Z finished in 0.159
2020-03-06T20:21:24.5658853Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-06T20:21:24.7553471Z ---
2020-03-06T20:21:44.5237394Z finished in 19.957
2020-03-06T20:21:44.5489099Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-06T20:21:44.7458830Z 2020-03-06T20:21:44.7459543Z running 116 tests
2020-03-06T20:21:57.6713732Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-03-06T20:21:59.5436565Z ....iiii.....ii.
2020-03-06T20:21:59.5437976Z 2020-03-06T20:21:59.5440042Z finished in 14.995
2020-03-06T20:21:59.5447250Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-06T20:21:59.5448202Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-03-06T20:34:17.5117772Z 2020-03-06T20:34:17.5126278Z Doc-tests core
2020-03-06T20:34:22.1145861Z 2020-03-06T20:34:22.1146661Z running 2480 tests
2020-03-06T20:34:30.8659147Z ......iiiii......................................................................................... 100/2480
2020-03-06T20:34:39.6011898Z ....................................................................................ii.............. 200/2480
2020-03-06T20:34:59.5227117Z ...................i................................................................................ 400/2480
2020-03-06T20:34:59.5227117Z ...................i................................................................................ 400/2480
2020-03-06T20:35:08.8578077Z ........................................................................i..i..................iiii.. 500/2480
2020-03-06T20:35:24.7731895Z .................................................................................................... 700/2480
2020-03-06T20:35:33.2796352Z .................................................................................................... 800/2480
2020-03-06T20:35:41.5786882Z .................................................................................................... 900/2480
2020-03-06T20:35:49.8267400Z .................................................................................................... 1000/2480
---
2020-03-06T20:39:19.7441294Z 2020-03-06T20:39:19.7441734Z running 1013 tests
2020-03-06T20:39:37.7126878Z i................................................................................................... 100/1013
2020-03-06T20:39:47.9740985Z .................................................................................................... 200/1013
2020-03-06T20:39:54.5607266Z ..................iii......i......i...i......i...................................................... 300/1013
2020-03-06T20:39:59.5190085Z .................................................................................................... 400/1013
2020-03-06T20:40:05.9530875Z ............................................i..i.....................FF..................ii......... 500/1013
2020-03-06T20:40:18.1858677Z .................................................................................................... 700/1013
2020-03-06T20:40:18.1858677Z .................................................................................................... 700/1013
2020-03-06T20:40:24.9131233Z .......................................iiii......................................................... 800/1013
2020-03-06T20:40:38.5701644Z .................................................................................................... 900/1013
2020-03-06T20:40:45.1924880Z .............................................................iiii................................... 1000/1013
2020-03-06T20:40:45.7019459Z failures:
2020-03-06T20:40:45.7021423Z 2020-03-06T20:40:45.7021423Z 2020-03-06T20:40:45.7022679Z ---- keyword_docs.rs - pub_keyword (line 931) stdout ----
2020-03-06T20:40:45.7023181Z error: expected item, found `;`
2020-03-06T20:40:45.7023814Z --> keyword_docs.rs:934:42
2020-03-06T20:40:45.7024831Z 6 | pub fn public_function() -> () {};
2020-03-06T20:40:45.7025394Z | ^ help: remove this semicolon
2020-03-06T20:40:45.7025843Z 2020-03-06T20:40:45.7025843Z 2020-03-06T20:40:45.7026248Z error: expected one of `<`, `where`, or `{`, found `;`
2020-03-06T20:40:45.7027352Z --> keyword_docs.rs:935:28
2020-03-06T20:40:45.7028374Z 7 | pub enum PublicEnum;
2020-03-06T20:40:45.7028374Z 7 | pub enum PublicEnum;
2020-03-06T20:40:45.7028851Z | ^ expected one of `<`, `where`, or `{`
2020-03-06T20:40:45.7029273Z 2020-03-06T20:40:45.7029672Z error: expected one of `!` or `::`, found `(`
2020-03-06T20:40:45.7030346Z --> keyword_docs.rs:938:46
2020-03-06T20:40:45.7031170Z 10 | other_mod::public_module::public_function();
2020-03-06T20:40:45.7031775Z | ^ expected one of `!` or `::`
2020-03-06T20:40:45.7032228Z 2020-03-06T20:40:45.7032598Z error: aborting due to 3 previous errors
2020-03-06T20:40:45.7032598Z error: aborting due to 3 previous errors
2020-03-06T20:40:45.7032939Z 2020-03-06T20:40:45.7033490Z Couldn't compile the test.
2020-03-06T20:40:45.7034172Z ---- keyword_docs.rs - pub_keyword (line 959) stdout ----
2020-03-06T20:40:45.7034658Z error: free function without a body
2020-03-06T20:40:45.7035280Z --> keyword_docs.rs:962:9
2020-03-06T20:40:45.7036254Z 6 | fn private_function() -> ();
2020-03-06T20:40:45.7036916Z | ^^^^^^^^^^^^^^^^^^^^^^^^^^^-
2020-03-06T20:40:45.7037382Z | |
2020-03-06T20:40:45.7037382Z | |
2020-03-06T20:40:45.7038103Z | help: provide a definition for the function: `{ <body> }`
2020-03-06T20:40:45.7038953Z error: aborting due to previous error
2020-03-06T20:40:45.7039290Z 2020-03-06T20:40:45.7039846Z Couldn't compile the test.
2020-03-06T20:40:45.7040183Z ---
2020-03-06T20:40:45.7195694Z local time: Fri Mar 6 20:40:45 UTC 2020
2020-03-06T20:40:45.8889599Z network time: Fri, 06 Mar 2020 20:40:45 GMT
2020-03-06T20:40:45.8896057Z == end clock drift check ==
2020-03-06T20:40:46.4164328Z 2020-03-06T20:40:46.4257178Z ##[error]Bash exited with code '1'.
2020-03-06T20:40:46.4272999Z ##[section]Finishing: Run build
2020-03-06T20:40:46.4324849Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-06T20:40:46.4330153Z Task : Get sources
2020-03-06T20:40:46.4330524Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-06T20:40:46.4330856Z Version : 1.0.0
2020-03-06T20:40:46.4331089Z Author : Microsoft
2020-03-06T20:40:46.4331089Z Author : Microsoft
2020-03-06T20:40:46.4331472Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-06T20:40:46.4331893Z ==============================================================================
2020-03-06T20:40:46.7761281Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-06T20:40:46.7804985Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-06T20:40:46.7900943Z Cleaning up task key
2020-03-06T20:40:46.7902314Z Start cleaning up orphan processes.
2020-03-06T20:40:46.8088548Z Terminate orphan process: pid (3333) (python)
2020-03-06T20:40:46.8329678Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-03-07T01:32:04Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-06T23:49:51.3456819Z ========================== Starting Command Output ===========================
2020-03-06T23:49:51.3460845Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/dab36ddb-8b8a-437f-aec8-0319a21b81cb.sh
2020-03-06T23:49:51.3461149Z 2020-03-06T23:49:51.3466011Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-06T23:49:51.3489067Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-06T23:49:51.3492837Z Task : Get sources
2020-03-06T23:49:51.3493189Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-06T23:49:51.3493505Z Version : 1.0.0
2020-03-06T23:49:51.3493724Z Author : Microsoft
---
2020-03-06T23:49:52.9228043Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-06T23:49:52.9234656Z ##[command]git config gc.auto 0
2020-03-06T23:49:52.9238375Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-06T23:49:52.9241734Z ##[command]git config --get-all http.proxy
2020-03-06T23:49:52.9249793Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69723/merge:refs/remotes/pull/69723/merge
---
2020-03-07T00:56:57.5569865Z .................................................................................................... 1700/9733
2020-03-07T00:57:02.6456358Z .................................................................................................... 1800/9733
2020-03-07T00:57:15.1745034Z ...........................................................i........................................ 1900/9733
2020-03-07T00:57:23.5272551Z .................................................................................................... 2000/9733
2020-03-07T00:57:38.9218289Z .................................................iiiii.............................................. 2100/9733
2020-03-07T00:57:49.7115257Z .................................................................................................... 2300/9733
2020-03-07T00:57:52.1373567Z .................................................................................................... 2400/9733
2020-03-07T00:57:55.6579623Z .................................................................................................... 2500/9733
2020-03-07T00:58:18.5593753Z .................................................................................................... 2600/9733
---
2020-03-07T01:01:07.7345867Z ..........i...............i......................................................................... 5000/9733
2020-03-07T01:01:18.2455580Z .................................................................................................... 5100/9733
2020-03-07T01:01:23.6926019Z .....................................................i.............................................. 5200/9733
2020-03-07T01:01:32.7509434Z .................................................................................................... 5300/9733
2020-03-07T01:01:40.7167952Z .................................ii.ii........i...i................................................. 5400/9733
2020-03-07T01:01:49.9097651Z .................................................................................................... 5600/9733
2020-03-07T01:02:00.1707379Z .................................................................................................... 5700/9733
2020-03-07T01:02:08.1611586Z ........................i........................................................................... 5800/9733
2020-03-07T01:02:14.3727231Z .................................................................................................... 5900/9733
2020-03-07T01:02:14.3727231Z .................................................................................................... 5900/9733
2020-03-07T01:02:26.5246383Z .................................................................................................... 6000/9733
2020-03-07T01:02:37.4007826Z ................ii...i..ii...........i.............................................................. 6100/9733
2020-03-07T01:02:55.3541694Z .................................................................................................... 6300/9733
2020-03-07T01:03:03.0938495Z .................................................................................................... 6400/9733
2020-03-07T01:03:03.0938495Z .................................................................................................... 6400/9733
2020-03-07T01:03:28.8513612Z ...............................................i..ii................................................ 6500/9733
2020-03-07T01:03:51.3423134Z .................................................................................................... 6700/9733
2020-03-07T01:03:53.6967452Z .......................................i............................................................ 6800/9733
2020-03-07T01:03:56.0349795Z .................................................................................................... 6900/9733
2020-03-07T01:03:58.5632379Z .....................................................................i.............................. 7000/9733
---
2020-03-07T01:05:49.6400696Z .................................................................................................... 7700/9733
2020-03-07T01:05:55.3873526Z .................................................................................................... 7800/9733
2020-03-07T01:06:00.5535279Z .................................................................................................... 7900/9733
2020-03-07T01:06:09.4532416Z ...............i.................................................................................... 8000/9733
2020-03-07T01:06:18.7315795Z ................................................................iiiiiiiii.i......................... 8100/9733
2020-03-07T01:06:35.0889350Z .......i......i..................................................................................... 8300/9733
2020-03-07T01:06:40.8157593Z .................................................................................................... 8400/9733
2020-03-07T01:06:55.3562265Z .................................................................................................... 8500/9733
2020-03-07T01:07:05.5724439Z .................................................................................................... 8600/9733
---
2020-03-07T01:09:42.4370283Z finished in 8.244
2020-03-07T01:09:42.4596282Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T01:09:42.7365415Z 2020-03-07T01:09:42.7366413Z running 178 tests
2020-03-07T01:09:46.0547035Z iiii......i...........ii..iiii...i....i...........i............i..i..................i....i......... 100/178
2020-03-07T01:09:48.7064705Z ...i.i..i..iii..iiiiiiiiiiiiiiii.......................iii............ii......
2020-03-07T01:09:48.7068659Z 2020-03-07T01:09:48.7074205Z finished in 6.248
2020-03-07T01:09:48.7292827Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T01:09:48.9104144Z ---
2020-03-07T01:09:51.1315318Z finished in 2.402
2020-03-07T01:09:51.1530378Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T01:09:51.3194273Z 2020-03-07T01:09:51.3194775Z running 9 tests
2020-03-07T01:09:51.3195960Z iiiiiiiii
2020-03-07T01:09:51.3197067Z 2020-03-07T01:09:51.3197222Z finished in 0.166
2020-03-07T01:09:51.3413627Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T01:09:51.5487631Z ---
2020-03-07T01:10:13.7774355Z finished in 22.435
2020-03-07T01:10:13.8015774Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T01:10:14.0120183Z 2020-03-07T01:10:14.0120596Z running 116 tests
2020-03-07T01:10:28.5648547Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-03-07T01:10:30.6409877Z ....iiii.....ii.
2020-03-07T01:10:30.6413363Z 2020-03-07T01:10:30.6413677Z finished in 16.840
2020-03-07T01:10:30.6421593Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T01:10:30.6422515Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-03-07T01:24:51.8753770Z 2020-03-07T01:24:51.8758127Z Doc-tests core
2020-03-07T01:24:56.8804957Z 2020-03-07T01:24:56.8805751Z running 2480 tests
2020-03-07T01:25:06.4957529Z ......iiiii......................................................................................... 100/2480
2020-03-07T01:25:16.2709884Z ....................................................................................ii.............. 200/2480
2020-03-07T01:25:37.9659766Z ...................i................................................................................ 400/2480
2020-03-07T01:25:37.9659766Z ...................i................................................................................ 400/2480
2020-03-07T01:25:48.3874009Z ........................................................................i..i..................iiii.. 500/2480
2020-03-07T01:26:06.9187351Z .................................................................................................... 700/2480
2020-03-07T01:26:16.2629973Z .................................................................................................... 800/2480
2020-03-07T01:26:26.0535241Z .................................................................................................... 900/2480
2020-03-07T01:26:34.6764165Z .................................................................................................... 1000/2480
---
2020-03-07T01:30:24.7458670Z 2020-03-07T01:30:24.7459072Z running 1013 tests
2020-03-07T01:30:44.1551636Z i................................................................................................... 100/1013
2020-03-07T01:30:54.9847446Z .................................................................................................... 200/1013
2020-03-07T01:31:02.5968592Z ..................iii......i......i...i......i...................................................... 300/1013
2020-03-07T01:31:08.1375622Z .................................................................................................... 400/1013
2020-03-07T01:31:15.2777550Z ............................................i..i....................F....................ii......... 500/1013
2020-03-07T01:31:28.6208877Z .................................................................................................... 700/1013
2020-03-07T01:31:28.6208877Z .................................................................................................... 700/1013
2020-03-07T01:31:36.1489489Z .......................................iiii......................................................... 800/1013
2020-03-07T01:31:51.0905260Z .................................................................................................... 900/1013
2020-03-07T01:31:58.6390673Z .............................................................iiii................................... 1000/1013
2020-03-07T01:31:59.1865721Z failures:
2020-03-07T01:31:59.1868822Z 2020-03-07T01:31:59.1868822Z 2020-03-07T01:31:59.1870432Z ---- keyword_docs.rs - pub_keyword (line 931) stdout ----
2020-03-07T01:31:59.1871133Z error: expected item, found keyword `let`
2020-03-07T01:31:59.1872094Z --> keyword_docs.rs:936:5
2020-03-07T01:31:59.1872319Z |
2020-03-07T01:31:59.1882558Z 8 | let emptyStruct = other_mod::public_module::PublicStruct;
2020-03-07T01:31:59.1883069Z 2020-03-07T01:31:59.1883275Z error: expected item, found `}`
2020-03-07T01:31:59.1884197Z --> keyword_docs.rs:938:1
2020-03-07T01:31:59.1884399Z |
---
2020-03-07T01:31:59.2085744Z local time: Sat Mar 7 01:31:59 UTC 2020
2020-03-07T01:31:59.5085513Z network time: Sat, 07 Mar 2020 01:31:59 GMT
2020-03-07T01:31:59.5094053Z == end clock drift check ==
2020-03-07T01:31:59.9215387Z 2020-03-07T01:31:59.9283314Z ##[error]Bash exited with code '1'.
2020-03-07T01:31:59.9298311Z ##[section]Finishing: Run build
2020-03-07T01:31:59.9406331Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-07T01:31:59.9411996Z Task : Get sources
2020-03-07T01:31:59.9412351Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-07T01:31:59.9412689Z Version : 1.0.0
2020-03-07T01:31:59.9412919Z Author : Microsoft
2020-03-07T01:31:59.9412919Z Author : Microsoft
2020-03-07T01:31:59.9413281Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-07T01:31:59.9413715Z ==============================================================================
2020-03-07T01:32:00.3236448Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-07T01:32:00.3290605Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-07T01:32:00.3415440Z Cleaning up task key
2020-03-07T01:32:00.3416972Z Start cleaning up orphan processes.
2020-03-07T01:32:00.3657449Z Terminate orphan process: pid (4639) (python)
2020-03-07T01:32:00.3852166Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-03-07T20:57:31Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-07T19:48:08.8373774Z ========================== Starting Command Output ===========================
2020-03-07T19:48:08.8376158Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/4de8caf7-12e3-44a4-a363-068ca5d4c03a.sh
2020-03-07T19:48:08.8376358Z 2020-03-07T19:48:08.8378994Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-07T19:48:08.8392178Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-07T19:48:08.8394572Z Task : Get sources
2020-03-07T19:48:08.8394792Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-07T19:48:08.8395018Z Version : 1.0.0
2020-03-07T19:48:08.8395162Z Author : Microsoft
---
2020-03-07T19:48:09.7172587Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-07T19:48:09.7176339Z ##[command]git config gc.auto 0
2020-03-07T19:48:09.7178844Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-07T19:48:09.7183163Z ##[command]git config --get-all http.proxy
2020-03-07T19:48:09.7187776Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69723/merge:refs/remotes/pull/69723/merge
---
2020-03-07T20:33:16.2175648Z .................................................................................................... 1700/9743
2020-03-07T20:33:19.5074913Z .................................................................................................... 1800/9743
2020-03-07T20:33:27.9407226Z ...........................................................i........................................ 1900/9743
2020-03-07T20:33:33.4547396Z .................................................................................................... 2000/9743
2020-03-07T20:33:43.7028864Z .................................................iiiii.............................................. 2100/9743
2020-03-07T20:33:51.3953331Z .................................................................................................... 2300/9743
2020-03-07T20:33:53.1520819Z .................................................................................................... 2400/9743
2020-03-07T20:33:55.6807448Z .................................................................................................... 2500/9743
2020-03-07T20:34:11.5456032Z .................................................................................................... 2600/9743
---
2020-03-07T20:36:09.6033741Z ..........i...............i......................................................................... 5000/9743
2020-03-07T20:36:16.9421662Z .................................................................................................... 5100/9743
2020-03-07T20:36:20.6773414Z .....................................................i.............................................. 5200/9743
2020-03-07T20:36:26.9383193Z .................................................................................................... 5300/9743
2020-03-07T20:36:33.9335334Z ..................................ii.ii........i...i................................................ 5400/9743
2020-03-07T20:36:39.7827521Z .................................................................................................... 5600/9743
2020-03-07T20:36:47.2296416Z .................................................................................................... 5700/9743
2020-03-07T20:36:52.6464930Z .........................i.......................................................................... 5800/9743
2020-03-07T20:36:57.0774829Z .................................................................................................... 5900/9743
2020-03-07T20:36:57.0774829Z .................................................................................................... 5900/9743
2020-03-07T20:37:05.8712374Z .................................................................................................... 6000/9743
2020-03-07T20:37:14.3392817Z .................ii...i..ii...........i............................................................. 6100/9743
2020-03-07T20:37:26.3153976Z .................................................................................................... 6300/9743
2020-03-07T20:37:29.0157375Z .................................................................................................... 6400/9743
2020-03-07T20:37:29.0157375Z .................................................................................................... 6400/9743
2020-03-07T20:37:37.2880798Z ................................................i..ii............................................... 6500/9743
2020-03-07T20:37:56.2496115Z .................................................................................................... 6700/9743
2020-03-07T20:37:58.2080188Z ..........................................i......................................................... 6800/9743
2020-03-07T20:38:00.0743814Z .................................................................................................... 6900/9743
2020-03-07T20:38:01.9007220Z .........................................................................i.......................... 7000/9743
---
2020-03-07T20:39:28.2246894Z .................................................................................................... 7700/9743
2020-03-07T20:39:32.1479247Z .................................................................................................... 7800/9743
2020-03-07T20:39:36.7604203Z .................................................................................................... 7900/9743
2020-03-07T20:39:43.6965101Z ........................i........................................................................... 8000/9743
2020-03-07T20:39:50.9283217Z .........................................................................iiiiiiiii.i................ 8100/9743
2020-03-07T20:40:04.7017756Z ................i......i............................................................................ 8300/9743
2020-03-07T20:40:09.3257137Z .................................................................................................... 8400/9743
2020-03-07T20:40:20.4517902Z .................................................................................................... 8500/9743
2020-03-07T20:40:29.0672000Z .................................................................................................... 8600/9743
---
2020-03-07T20:42:29.0132374Z finished in 6.222
2020-03-07T20:42:29.0303310Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T20:42:29.2148897Z 2020-03-07T20:42:29.2149266Z running 178 tests
2020-03-07T20:42:31.7166920Z iiii......i...........ii..iiii...i....i...........i............i..i..................i....i......... 100/178
2020-03-07T20:42:33.6942325Z ...i.i.i...iii..iiiiiiiiiiiiiiii.......................iii............ii......
2020-03-07T20:42:33.6945162Z 2020-03-07T20:42:33.6945379Z finished in 4.663
2020-03-07T20:42:33.7116097Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T20:42:33.8534173Z ---
2020-03-07T20:42:35.4724089Z finished in 1.761
2020-03-07T20:42:35.4912043Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T20:42:35.6299641Z 2020-03-07T20:42:35.6299950Z running 9 tests
2020-03-07T20:42:35.6301003Z iiiiiiiii
2020-03-07T20:42:35.6302075Z 2020-03-07T20:42:35.6302244Z finished in 0.140
2020-03-07T20:42:35.6472493Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T20:42:35.8110415Z ---
2020-03-07T20:42:52.8015719Z finished in 17.155
2020-03-07T20:42:52.8231252Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T20:42:52.9954128Z 2020-03-07T20:42:52.9954483Z running 116 tests
2020-03-07T20:43:05.1641526Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-03-07T20:43:06.8872671Z ....iiii.....ii.
2020-03-07T20:43:06.8873886Z 2020-03-07T20:43:06.8874086Z finished in 14.065
2020-03-07T20:43:06.8877810Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-07T20:43:06.8878554Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-03-07T20:52:34.3798825Z 2020-03-07T20:52:34.3800422Z Doc-tests core
2020-03-07T20:52:37.7753717Z 2020-03-07T20:52:37.7767592Z running 2480 tests
2020-03-07T20:52:44.4234859Z ......iiiii......................................................................................... 100/2480
2020-03-07T20:52:51.0208157Z ....................................................................................ii.............. 200/2480
2020-03-07T20:53:05.9852221Z ...................i................................................................................ 400/2480
2020-03-07T20:53:05.9852221Z ...................i................................................................................ 400/2480
2020-03-07T20:53:13.0862926Z ........................................................................i..i..................iiii.. 500/2480
2020-03-07T20:53:25.0915512Z .................................................................................................... 700/2480
2020-03-07T20:53:31.3648757Z .................................................................................................... 800/2480
2020-03-07T20:53:37.5882995Z .................................................................................................... 900/2480
2020-03-07T20:53:43.9177266Z .................................................................................................... 1000/2480
---
2020-03-07T20:56:11.2324731Z .................................................................................................... 500/760
2020-03-07T20:56:11.2587273Z .................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2741:22
2020-03-07T20:56:11.2598093Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2778:21
2020-03-07T20:56:11.2605279Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2766:17
2020-03-07T20:56:11.2620283Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2645:13
2020-03-07T20:56:11.5773178Z .............................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1997:22
2020-03-07T20:56:11.5782847Z ..thread '.<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2034:21
2020-03-07T20:56:11.5791660Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2022.:.17
2020-03-07T20:56:11.5799742Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1916:13
2020-03-07T20:56:13.6191971Z ...................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:633:13
2020-03-07T20:56:13.6204095Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:587:13
2020-03-07T20:56:13.6221849Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:563:13
2020-03-07T20:56:13.6237674Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:694:13
---
2020-03-07T20:56:22.3909373Z 2020-03-07T20:56:22.3914866Z running 1013 tests
2020-03-07T20:56:34.8804722Z i................................................................................................... 100/1013
2020-03-07T20:56:42.1796250Z .................................................................................................... 200/1013
2020-03-07T20:56:47.3120165Z ..................iii......i......i...i......i...................................................... 300/1013
2020-03-07T20:56:50.8804342Z .................................................................................................... 400/1013
2020-03-07T20:56:55.7361092Z ............................................i..i.....................F...................ii......... 500/1013
2020-03-07T20:57:04.9842887Z .................................................................................................... 700/1013
2020-03-07T20:57:04.9842887Z .................................................................................................... 700/1013
2020-03-07T20:57:10.0499519Z .......................................iiii......................................................... 800/1013
2020-03-07T20:57:20.6143693Z .................................................................................................... 900/1013
2020-03-07T20:57:25.4673958Z .............................................................iiii................................... 1000/1013
2020-03-07T20:57:25.8625963Z failures:
2020-03-07T20:57:25.8627494Z 2020-03-07T20:57:25.8627494Z 2020-03-07T20:57:25.8628466Z ---- keyword_docs.rs - pub_keyword (line 931) stdout ----
2020-03-07T20:57:25.8629197Z --> keyword_docs.rs:937:2
2020-03-07T20:57:25.8629327Z |
2020-03-07T20:57:25.8629450Z 3 | fn main() {
2020-03-07T20:57:25.8629814Z | - unclosed delimiter
2020-03-07T20:57:25.8629814Z | - unclosed delimiter
2020-03-07T20:57:25.8629966Z 4 | mod other_mod {
2020-03-07T20:57:25.8630125Z 5 | pub mod public_module {
2020-03-07T20:57:25.8630718Z 6 | pub struct PublicStruct;
2020-03-07T20:57:25.8631037Z 7 | }
2020-03-07T20:57:25.8631339Z | - ...as it matches this but it has different indentation
2020-03-07T20:57:25.8631339Z | - ...as it matches this but it has different indentation
2020-03-07T20:57:25.8631590Z 8 | let emptyStruct = other_mod::public_module::PublicStruct;
2020-03-07T20:57:25.8631889Z | ^
2020-03-07T20:57:25.8631965Z 2020-03-07T20:57:25.8632214Z error: expected item, found keyword `let`
2020-03-07T20:57:25.8632549Z --> keyword_docs.rs:936:5
2020-03-07T20:57:25.8632549Z --> keyword_docs.rs:936:5
2020-03-07T20:57:25.8632677Z |
2020-03-07T20:57:25.8632857Z 8 | let emptyStruct = other_mod::public_module::PublicStruct;
2020-03-07T20:57:25.8633174Z 2020-03-07T20:57:25.8633292Z error: expected item, found `}`
2020-03-07T20:57:25.8633561Z --> keyword_docs.rs:937:2
2020-03-07T20:57:25.8633700Z |
---
2020-03-07T20:57:25.8785858Z local time: Sat Mar 7 20:57:25 UTC 2020
2020-03-07T20:57:26.1476461Z network time: Sat, 07 Mar 2020 20:57:26 GMT
2020-03-07T20:57:26.1481208Z == end clock drift check ==
2020-03-07T20:57:26.5042154Z 2020-03-07T20:57:26.5113793Z ##[error]Bash exited with code '1'.
2020-03-07T20:57:26.5131185Z ##[section]Finishing: Run build
2020-03-07T20:57:26.5176947Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-07T20:57:26.5181632Z Task : Get sources
2020-03-07T20:57:26.5181961Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-07T20:57:26.5182255Z Version : 1.0.0
2020-03-07T20:57:26.5182472Z Author : Microsoft
2020-03-07T20:57:26.5182472Z Author : Microsoft
2020-03-07T20:57:26.5182816Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-07T20:57:26.5183192Z ==============================================================================
2020-03-07T20:57:26.7739999Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-07T20:57:26.7788783Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-07T20:57:26.7852688Z Cleaning up task key
2020-03-07T20:57:26.7853608Z Start cleaning up orphan processes.
2020-03-07T20:57:26.7972070Z Terminate orphan process: pid (3484) (python)
2020-03-07T20:57:26.8189814Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Mark-Simulacrum

Looking good. Some minor nits, let me know if I can help fix them.

ghost · 2020-03-09T21:00:59Z

Hi, Mark.
Thanks for your feedback! I've made the changes and added some further details regarding pub use. Please let me know what you think, thank you.

rust-highfive · 2020-03-09T22:28:13Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-09T20:56:05.7471664Z Prepare build directory.
2020-03-09T20:56:05.7840287Z Set build variables.
2020-03-09T20:56:05.7875618Z Download all required tasks.
2020-03-09T20:56:05.8002633Z Downloading task: Bash (3.163.1)
2020-03-09T20:56:06.6445370Z Checking job knob settings.
2020-03-09T20:56:06.6470080Z Finished checking job knob settings.
2020-03-09T20:56:06.7089162Z ##[section]Finishing: Initialize job
2020-03-09T20:56:06.7473911Z ##[section]Starting: Configure Job Name
2020-03-09T20:56:06.7711574Z ==============================================================================
2020-03-09T20:56:06.7712416Z Task : Bash
---
2020-03-09T20:56:08.1069084Z ========================== Starting Command Output ===========================
2020-03-09T20:56:08.1072678Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/c352b24a-9b4d-4444-971e-206b60c4b2dd.sh
2020-03-09T20:56:08.1073509Z 2020-03-09T20:56:08.1089694Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-09T20:56:08.1111114Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-09T20:56:08.1114686Z Task : Get sources
2020-03-09T20:56:08.1115023Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-09T20:56:08.1115298Z Version : 1.0.0
2020-03-09T20:56:08.1115486Z Author : Microsoft
---
2020-03-09T20:56:09.1059969Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-09T20:56:09.1069198Z ##[command]git config gc.auto 0
2020-03-09T20:56:09.1077320Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-09T20:56:09.1089768Z ##[command]git config --get-all http.proxy
2020-03-09T20:56:09.1097879Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69723/merge:refs/remotes/pull/69723/merge
---
2020-03-09T21:56:57.5399102Z .................................................................................................... 1700/9754
2020-03-09T21:57:01.8947811Z .................................................................................................... 1800/9754
2020-03-09T21:57:13.0625028Z ...........................................................i........................................ 1900/9754
2020-03-09T21:57:20.2202170Z .................................................................................................... 2000/9754
2020-03-09T21:57:34.2908759Z .................................................iiiii.............................................. 2100/9754
2020-03-09T21:57:44.0101747Z .................................................................................................... 2300/9754
2020-03-09T21:57:46.1227736Z .................................................................................................... 2400/9754
2020-03-09T21:57:49.4066544Z .................................................................................................... 2500/9754
2020-03-09T21:58:10.8107135Z .................................................................................................... 2600/9754
---
2020-03-09T22:00:43.2864958Z ....................i...............i............................................................... 5000/9754
2020-03-09T22:00:52.5775564Z .................................................................................................... 5100/9754
2020-03-09T22:00:58.0338067Z ...............................................................i.................................... 5200/9754
2020-03-09T22:01:04.2328800Z .................................................................................................... 5300/9754
2020-03-09T22:01:13.0203217Z ............................................ii.ii........i...i...................................... 5400/9754
2020-03-09T22:01:20.5609300Z .................................................................................................... 5600/9754
2020-03-09T22:01:29.9264109Z .................................................................................................... 5700/9754
2020-03-09T22:01:36.3208919Z ...................................i................................................................ 5800/9754
2020-03-09T22:01:41.8652295Z .................................................................................................... 5900/9754
2020-03-09T22:01:41.8652295Z .................................................................................................... 5900/9754
2020-03-09T22:01:51.9025681Z .................................................................................................... 6000/9754
2020-03-09T22:02:01.1220005Z ............................ii...i..ii...........i.................................................. 6100/9754
2020-03-09T22:02:17.5443826Z .................................................................................................... 6300/9754
2020-03-09T22:02:23.9560037Z .................................................................................................... 6400/9754
2020-03-09T22:02:23.9560037Z .................................................................................................... 6400/9754
2020-03-09T22:02:35.5925947Z ...........................................................i..ii.................................... 6500/9754
2020-03-09T22:03:02.2488191Z .................................................................................................... 6700/9754
2020-03-09T22:03:05.7646187Z .....................................................i.............................................. 6800/9754
2020-03-09T22:03:07.3990684Z .................................................................................................... 6900/9754
2020-03-09T22:03:09.2656211Z ....................................................................................i............... 7000/9754
---
2020-03-09T22:04:45.8872939Z .................................................................................................... 7700/9754
2020-03-09T22:04:49.6800112Z .................................................................................................... 7800/9754
2020-03-09T22:04:55.3085535Z .................................................................................................... 7900/9754
2020-03-09T22:05:02.0754566Z ..................................i................................................................. 8000/9754
2020-03-09T22:05:11.2919002Z ...................................................................................iiiiiiiiii.i..... 8100/9754
2020-03-09T22:05:26.1314142Z ...........................i......i................................................................. 8300/9754
2020-03-09T22:05:30.8233824Z .................................................................................................... 8400/9754
2020-03-09T22:05:41.8721434Z .................................................................................................... 8500/9754
2020-03-09T22:05:53.2794303Z .................................................................................................... 8600/9754
---
2020-03-09T22:08:11.7968203Z finished in 7.186
2020-03-09T22:08:11.8116620Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-09T22:08:12.0046246Z 2020-03-09T22:08:12.0047171Z running 179 tests
2020-03-09T22:08:14.7274968Z iiii......i...........ii..iiii....i....i...........i............i..i..................i....i........ 100/179
2020-03-09T22:08:16.9591530Z ....i.i.i...iii..iiiiiiiiiiiiiiii.......................iii............ii......
2020-03-09T22:08:16.9595377Z 2020-03-09T22:08:16.9600553Z finished in 5.148
2020-03-09T22:08:16.9799723Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-09T22:08:17.1521564Z ---
2020-03-09T22:08:19.3407334Z finished in 1.995
2020-03-09T22:08:19.3407986Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-09T22:08:19.3408445Z 2020-03-09T22:08:19.3417027Z running 9 tests
2020-03-09T22:08:19.3418924Z iiiiiiiii
2020-03-09T22:08:19.3420366Z 2020-03-09T22:08:19.3420630Z finished in 0.152
2020-03-09T22:08:19.3421539Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-09T22:08:19.3497279Z ---
2020-03-09T22:08:38.2913418Z finished in 19.131
2020-03-09T22:08:38.3123161Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-09T22:08:38.5122172Z 2020-03-09T22:08:38.5122995Z running 115 tests
2020-03-09T22:08:52.1554662Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-09T22:08:53.7380910Z ...iiii.....ii.
2020-03-09T22:08:53.7389533Z 2020-03-09T22:08:53.7389898Z finished in 15.426
2020-03-09T22:08:53.7397571Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-09T22:08:53.7398310Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-03-09T22:21:45.3716927Z 2020-03-09T22:21:45.3724403Z Doc-tests core
2020-03-09T22:21:50.0629140Z 2020-03-09T22:21:50.0629526Z running 2480 tests
2020-03-09T22:21:58.7718040Z ......iiiii......................................................................................... 100/2480
2020-03-09T22:22:07.3741314Z ....................................................................................ii.............. 200/2480
2020-03-09T22:22:27.1241019Z ...................i................................................................................ 400/2480
2020-03-09T22:22:27.1241019Z ...................i................................................................................ 400/2480
2020-03-09T22:22:36.4541222Z ........................................................................i..i..................iiii.. 500/2480
2020-03-09T22:22:51.8837577Z .................................................................................................... 700/2480
2020-03-09T22:23:00.0827681Z .................................................................................................... 800/2480
2020-03-09T22:23:07.8242272Z .................................................................................................... 900/2480
2020-03-09T22:23:15.8475770Z .................................................................................................... 1000/2480
---
2020-03-09T22:26:31.2805106Z .................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2741:22
2020-03-09T22:26:31.2849787Z ................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2766:17
2020-03-09T22:26:31.2860154Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2778:21
2020-03-09T22:26:31.2863071Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2645:13
2020-03-09T22:26:31.4846372Z ......................................thread '.<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1997:22
2020-03-09T22:26:31.4857620Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2022:17
2020-03-09T22:26:31.4872228Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2034:21
2020-03-09T22:26:31.4876679Z .thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1916:13
2020-03-09T22:26:33.5212209Z .......................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:633:13
2020-03-09T22:26:33.5219880Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:587:13
2020-03-09T22:26:33.5229742Z ....thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:563:13
2020-03-09T22:26:33.5230832Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:694:13
---
2020-03-09T22:26:42.4496180Z 2020-03-09T22:26:42.4496827Z running 1013 tests
2020-03-09T22:26:59.6073123Z i................................................................................................... 100/1013
2020-03-09T22:27:09.6482454Z .................................................................................................... 200/1013
2020-03-09T22:27:15.9064609Z ..................iii......i......i...i......i...................................................... 300/1013
2020-03-09T22:27:20.7070671Z .................................................................................................... 400/1013
2020-03-09T22:27:27.1597773Z ............................................i..i......................F..................ii......... 500/1013
2020-03-09T22:27:39.7409412Z .................................................................................................... 700/1013
2020-03-09T22:27:39.7409412Z .................................................................................................... 700/1013
2020-03-09T22:27:46.4698333Z .......................................iiii......................................................... 800/1013
2020-03-09T22:28:00.4541628Z .................................................................................................... 900/1013
2020-03-09T22:28:07.0387366Z .............................................................iiii................................... 1000/1013
2020-03-09T22:28:07.5305681Z failures:
2020-03-09T22:28:07.5306019Z 2020-03-09T22:28:07.5306019Z 2020-03-09T22:28:07.5306882Z ---- keyword_docs.rs - pub_keyword (line 937) stdout ----
2020-03-09T22:28:07.5307224Z error[E0433]: failed to resolve: use of undeclared type or module `primary_mod`
2020-03-09T22:28:07.5307709Z --> keyword_docs.rs:952:13
2020-03-09T22:28:07.5308130Z 17 | pub use primary_mod::public_inner_module::PublicStruct;
2020-03-09T22:28:07.5308472Z | ^^^^^^^^^^^ use of undeclared type or module `primary_mod`
2020-03-09T22:28:07.5308675Z 2020-03-09T22:28:07.5308675Z 2020-03-09T22:28:07.5308909Z error[E0432]: unresolved import `secondary_mod::PublicStruct`
2020-03-09T22:28:07.5309336Z --> keyword_docs.rs:963:9
2020-03-09T22:28:07.5309706Z 28 | use secondary_mod::PublicStruct;
2020-03-09T22:28:07.5309706Z 28 | use secondary_mod::PublicStruct;
2020-03-09T22:28:07.5310005Z | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `PublicStruct` in `secondary_mod`
2020-03-09T22:28:07.5310430Z error[E0425]: cannot find value `PublicStruct` in this scope
2020-03-09T22:28:07.5310849Z --> keyword_docs.rs:956:25
2020-03-09T22:28:07.5311016Z |
2020-03-09T22:28:07.5311016Z |
2020-03-09T22:28:07.5311191Z 21 | let foreignStruct = PublicStruct;
2020-03-09T22:28:07.5311878Z |
2020-03-09T22:28:07.5312128Z help: possible candidate is found in another module, you can import it into scope
2020-03-09T22:28:07.5312568Z |
2020-03-09T22:28:07.5312804Z 17 | use crate::primary_mod::public_inner_module::PublicStruct;
---
2020-03-09T22:28:07.5523937Z local time: Mon Mar 9 22:28:07 UTC 2020
2020-03-09T22:28:07.6528457Z network time: Mon, 09 Mar 2020 22:28:07 GMT
2020-03-09T22:28:07.6532300Z == end clock drift check ==
2020-03-09T22:28:08.0369193Z 2020-03-09T22:28:08.0458032Z ##[error]Bash exited with code '1'.
2020-03-09T22:28:08.0514730Z ##[section]Finishing: Run build
2020-03-09T22:28:08.0572237Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-09T22:28:08.0577737Z Task : Get sources
2020-03-09T22:28:08.0578094Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-09T22:28:08.0578442Z Version : 1.0.0
2020-03-09T22:28:08.0578669Z Author : Microsoft
2020-03-09T22:28:08.0578669Z Author : Microsoft
2020-03-09T22:28:08.0579033Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-09T22:28:08.0579921Z ==============================================================================
2020-03-09T22:28:08.4195024Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-09T22:28:08.4240165Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-09T22:28:08.4337634Z Cleaning up task key
2020-03-09T22:28:08.4338866Z Start cleaning up orphan processes.
2020-03-09T22:28:08.4507357Z Terminate orphan process: pid (3633) (python)
2020-03-09T22:28:08.4757367Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-03-10T20:17:53Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-10T18:53:31.0579652Z ========================== Starting Command Output ===========================
2020-03-10T18:53:31.0581920Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/696a3f62-7b61-44e7-a7dc-d3d498067301.sh
2020-03-10T18:53:31.0582208Z 2020-03-10T18:53:31.0585980Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-10T18:53:31.0605399Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-10T18:53:31.0608670Z Task : Get sources
2020-03-10T18:53:31.0608974Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-10T18:53:31.0609248Z Version : 1.0.0
2020-03-10T18:53:31.0609433Z Author : Microsoft
---
2020-03-10T18:53:32.0694718Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-10T18:53:32.0702577Z ##[command]git config gc.auto 0
2020-03-10T18:53:32.0707396Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-10T18:53:32.0711916Z ##[command]git config --get-all http.proxy
2020-03-10T18:53:32.0719817Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69723/merge:refs/remotes/pull/69723/merge
---
2020-03-10T19:48:52.1071409Z .................................................................................................... 1700/9755
2020-03-10T19:48:56.8086382Z .................................................................................................... 1800/9755
2020-03-10T19:49:07.6620572Z .............................................................i...................................... 1900/9755
2020-03-10T19:49:14.8375651Z .................................................................................................... 2000/9755
2020-03-10T19:49:28.2245326Z ...................................................iiiii............................................ 2100/9755
2020-03-10T19:49:38.1246364Z .................................................................................................... 2300/9755
2020-03-10T19:49:40.2115083Z .................................................................................................... 2400/9755
2020-03-10T19:49:43.2744635Z .................................................................................................... 2500/9755
2020-03-10T19:50:03.7208355Z .................................................................................................... 2600/9755
---
2020-03-10T19:52:30.7060101Z .....................i...............i.............................................................. 5000/9755
2020-03-10T19:52:39.8104320Z .................................................................................................... 5100/9755
2020-03-10T19:52:44.8965609Z ................................................................i................................... 5200/9755
2020-03-10T19:52:50.6186587Z .................................................................................................... 5300/9755
2020-03-10T19:52:59.0917219Z .............................................ii.ii........i...i..................................... 5400/9755
2020-03-10T19:53:06.5117298Z .................................................................................................... 5600/9755
2020-03-10T19:53:15.2843838Z .................................................................................................... 5700/9755
2020-03-10T19:53:21.5981539Z ....................................i............................................................... 5800/9755
2020-03-10T19:53:27.0763974Z .................................................................................................... 5900/9755
2020-03-10T19:53:27.0763974Z .................................................................................................... 5900/9755
2020-03-10T19:53:36.7930316Z .................................................................................................... 6000/9755
2020-03-10T19:53:45.1295740Z .............................ii...i..ii...........i................................................. 6100/9755
2020-03-10T19:54:01.3270426Z .................................................................................................... 6300/9755
2020-03-10T19:54:04.5121541Z .................................................................................................... 6400/9755
2020-03-10T19:54:04.5121541Z .................................................................................................... 6400/9755
2020-03-10T19:54:10.3489549Z ............................................................i..ii................................... 6500/9755
2020-03-10T19:54:34.0988252Z .................................................................................................... 6700/9755
2020-03-10T19:54:37.5697558Z ......................................................i............................................. 6800/9755
2020-03-10T19:54:39.4278094Z .................................................................................................... 6900/9755
2020-03-10T19:54:41.2846462Z .....................................................................................i.............. 7000/9755
---
2020-03-10T19:56:11.6314810Z .................................................................................................... 7700/9755
2020-03-10T19:56:15.4594069Z .................................................................................................... 7800/9755
2020-03-10T19:56:20.9395358Z .................................................................................................... 7900/9755
2020-03-10T19:56:27.2796244Z ...................................i................................................................ 8000/9755
2020-03-10T19:56:35.5666847Z ....................................................................................iiiiiiiiii.i.... 8100/9755
2020-03-10T19:56:50.1568854Z ............................i......i................................................................ 8300/9755
2020-03-10T19:56:54.5934846Z .................................................................................................... 8400/9755
2020-03-10T19:57:05.0000488Z .................................................................................................... 8500/9755
2020-03-10T19:57:15.8092207Z .................................................................................................... 8600/9755
---
2020-03-10T19:59:26.3371286Z finished in 6.715
2020-03-10T19:59:26.3558673Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T19:59:26.5399227Z 2020-03-10T19:59:26.5399769Z running 179 tests
2020-03-10T19:59:29.3020457Z iiii......i...........ii..iiii....i....i...........i............i..i..................i....i........ 100/179
2020-03-10T19:59:31.4312226Z ....i.i.i...iii..iiiiiiiiiiiiiiii.......................iii............ii......
2020-03-10T19:59:31.4315135Z 2020-03-10T19:59:31.4317416Z finished in 5.075
2020-03-10T19:59:31.4502809Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T19:59:31.6077729Z ---
2020-03-10T19:59:33.3803389Z finished in 1.930
2020-03-10T19:59:33.3989217Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T19:59:33.5486765Z 2020-03-10T19:59:33.5488902Z running 9 tests
2020-03-10T19:59:33.5489935Z iiiiiiiii
2020-03-10T19:59:33.5490946Z 2020-03-10T19:59:33.5491117Z finished in 0.149
2020-03-10T19:59:33.5670975Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T19:59:33.7468632Z ---
2020-03-10T19:59:51.8960722Z finished in 18.328
2020-03-10T19:59:51.9169702Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T19:59:52.0918091Z 2020-03-10T19:59:52.0918445Z running 115 tests
2020-03-10T20:00:04.4561359Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-10T20:00:06.0056741Z ...iiii.....ii.
2020-03-10T20:00:06.0058026Z 2020-03-10T20:00:06.0058239Z finished in 14.088
2020-03-10T20:00:06.0063737Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T20:00:06.0064492Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-03-10T20:11:43.5741046Z 2020-03-10T20:11:43.5742350Z Doc-tests core
2020-03-10T20:11:47.9122368Z 2020-03-10T20:11:47.9122793Z running 2480 tests
2020-03-10T20:11:56.3969622Z ......iiiii......................................................................................... 100/2480
2020-03-10T20:12:04.8617708Z ....................................................................................ii.............. 200/2480
2020-03-10T20:12:24.8155778Z ...................i................................................................................ 400/2480
2020-03-10T20:12:24.8155778Z ...................i................................................................................ 400/2480
2020-03-10T20:12:32.8991874Z ........................................................................i..i..................iiii.. 500/2480
2020-03-10T20:12:47.8676298Z .................................................................................................... 700/2480
2020-03-10T20:12:55.6863305Z .................................................................................................... 800/2480
2020-03-10T20:13:03.3852358Z .................................................................................................... 900/2480
2020-03-10T20:13:11.2204707Z .................................................................................................... 1000/2480
---
2020-03-10T20:16:28.0145621Z 2020-03-10T20:16:28.0146125Z running 1013 tests
2020-03-10T20:16:43.9155500Z i................................................................................................... 100/1013
2020-03-10T20:16:53.1146172Z .................................................................................................... 200/1013
2020-03-10T20:16:59.6125745Z ..................iii......i......i...i......i...................................................... 300/1013
2020-03-10T20:17:04.2133211Z .................................................................................................... 400/1013
2020-03-10T20:17:10.2542973Z ............................................i..i......................F..................ii......... 500/1013
2020-03-10T20:17:21.6459971Z .................................................................................................... 700/1013
2020-03-10T20:17:21.6459971Z .................................................................................................... 700/1013
2020-03-10T20:17:27.8926875Z .......................................iiii......................................................... 800/1013
2020-03-10T20:17:40.5747977Z .................................................................................................... 900/1013
2020-03-10T20:17:46.6301521Z .............................................................iiii................................... 1000/1013
2020-03-10T20:17:47.1095510Z failures:
2020-03-10T20:17:47.1095636Z 2020-03-10T20:17:47.1095636Z 2020-03-10T20:17:47.1097677Z ---- keyword_docs.rs - pub_keyword (line 937) stdout ----
2020-03-10T20:17:47.1098244Z error: variable `emptyStruct` should have a snake case name
2020-03-10T20:17:47.1098941Z --> keyword_docs.rs:966:9
2020-03-10T20:17:47.1099324Z |
2020-03-10T20:17:47.1099737Z 31 | let emptyStruct = PublicStruct;
2020-03-10T20:17:47.1100283Z | ^^^^^^^^^^^ help: convert the identifier to snake case: `empty_struct`
2020-03-10T20:17:47.1101138Z note: the lint level is defined here
2020-03-10T20:17:47.1101741Z --> keyword_docs.rs:936:9
2020-03-10T20:17:47.1102115Z |
2020-03-10T20:17:47.1102473Z 1 | #![deny(warnings)]
2020-03-10T20:17:47.1102473Z 1 | #![deny(warnings)]
2020-03-10T20:17:47.1102848Z | ^^^^^^^^
2020-03-10T20:17:47.1103315Z = note: `#[deny(non_snake_case)]` implied by `#[deny(warnings)]`
2020-03-10T20:17:47.1103705Z 2020-03-10T20:17:47.1104099Z error: variable `localStruct` should have a snake case name
2020-03-10T20:17:47.1104751Z --> keyword_docs.rs:945:9
2020-03-10T20:17:47.1105122Z |
2020-03-10T20:17:47.1105552Z 10 | let localStruct = public_inner_module::PublicStruct;
2020-03-10T20:17:47.1106164Z | ^^^^^^^^^^^ help: convert the identifier to snake case: `local_struct`
2020-03-10T20:17:47.1107024Z error: variable `foreignStruct` should have a snake case name
2020-03-10T20:17:47.1107784Z --> keyword_docs.rs:956:9
2020-03-10T20:17:47.1108799Z |
2020-03-10T20:17:47.1108799Z |
2020-03-10T20:17:47.1109252Z 21 | let foreignStruct = PublicStruct;
2020-03-10T20:17:47.1109869Z | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `foreign_struct`
2020-03-10T20:17:47.1111183Z error: aborting due to 3 previous errors
2020-03-10T20:17:47.1111511Z 2020-03-10T20:17:47.1112092Z Couldn't compile the test.
2020-03-10T20:17:47.1112376Z ---
2020-03-10T20:17:47.1298833Z local time: Tue Mar 10 20:17:47 UTC 2020
2020-03-10T20:17:47.4235951Z network time: Tue, 10 Mar 2020 20:17:47 GMT
2020-03-10T20:17:47.4238283Z == end clock drift check ==
2020-03-10T20:17:47.8210698Z 2020-03-10T20:17:47.8286511Z ##[error]Bash exited with code '1'.
2020-03-10T20:17:47.8310788Z ##[section]Finishing: Run build
2020-03-10T20:17:47.8359858Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-10T20:17:47.8365494Z Task : Get sources
2020-03-10T20:17:47.8365844Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-10T20:17:47.8366193Z Version : 1.0.0
2020-03-10T20:17:47.8366421Z Author : Microsoft
2020-03-10T20:17:47.8366421Z Author : Microsoft
2020-03-10T20:17:47.8366779Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-10T20:17:47.8367207Z ==============================================================================
2020-03-10T20:17:48.1589616Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-10T20:17:48.1632477Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-10T20:17:48.1718035Z Cleaning up task key
2020-03-10T20:17:48.1719286Z Start cleaning up orphan processes.
2020-03-10T20:17:48.1875421Z Terminate orphan process: pid (3805) (python)
2020-03-10T20:17:48.2090726Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Mark-Simulacrum · 2020-03-10T20:21:02Z

This is no longer used, so can be dropped.

Mark-Simulacrum · 2020-03-10T20:22:59Z

I think linking to https://doc.rust-lang.org/reference/visibility-and-privacy.html is a better fit here, it seems like the most exhaustive and best documentation we have right now.

Mark-Simulacrum · 2020-03-10T20:24:42Z

In thinking about this some more, I would personally prefer to drop the code examples from this documentation and primarily lead people towards the visibility documentation in the reference.
I think in practice that means leaving the first paragraph in, and then deleting the code examples and such up to the final paragraph. I think that this is just not the best place for long-form documentation like this.

ghost · 2020-03-10T21:30:24Z

Thanks, Mark.
That makes sense to me.

Mark-Simulacrum · 2020-03-10T21:32:20Z

These will need to be distinct identifiers; one option is to reword the above to be: please see the visibility sections of the [Reference] and examples in the [Rust by Example] collection..

rust-highfive · 2020-03-10T23:33:16Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-10T21:53:06.7669563Z ========================== Starting Command Output ===========================
2020-03-10T21:53:06.7673995Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/b133dd8d-f7c0-4e38-bb9b-64adc52a671b.sh
2020-03-10T21:53:06.7674437Z 2020-03-10T21:53:06.7679415Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-10T21:53:06.7700355Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-10T21:53:06.7703995Z Task : Get sources
2020-03-10T21:53:06.7704324Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-10T21:53:06.7705136Z Version : 1.0.0
2020-03-10T21:53:06.7705349Z Author : Microsoft
---
2020-03-10T21:53:07.7561049Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-10T21:53:07.7568477Z ##[command]git config gc.auto 0
2020-03-10T21:53:07.7574252Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-10T21:53:07.7579150Z ##[command]git config --get-all http.proxy
2020-03-10T21:53:07.7587800Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69723/merge:refs/remotes/pull/69723/merge
---
2020-03-10T22:48:37.3448405Z .................................................................................................... 1700/9755
2020-03-10T22:48:41.4011043Z .................................................................................................... 1800/9755
2020-03-10T22:48:51.5613185Z .............................................................i...................................... 1900/9755
2020-03-10T22:48:58.6215070Z .................................................................................................... 2000/9755
2020-03-10T22:49:11.9848829Z ...................................................iiiii............................................ 2100/9755
2020-03-10T22:49:21.7431731Z .................................................................................................... 2300/9755
2020-03-10T22:49:23.8182702Z .................................................................................................... 2400/9755
2020-03-10T22:49:26.8814526Z .................................................................................................... 2500/9755
2020-03-10T22:49:47.0699116Z .................................................................................................... 2600/9755
---
2020-03-10T22:52:14.9164952Z .....................i...............i.............................................................. 5000/9755
2020-03-10T22:52:24.6613692Z .................................................................................................... 5100/9755
2020-03-10T22:52:30.0260069Z ................................................................i................................... 5200/9755
2020-03-10T22:52:36.1427636Z .................................................................................................... 5300/9755
2020-03-10T22:52:45.0424041Z .............................................ii.ii........i...i..................................... 5400/9755
2020-03-10T22:52:53.1321537Z .................................................................................................... 5600/9755
2020-03-10T22:53:02.4880382Z .................................................................................................... 5700/9755
2020-03-10T22:53:09.2773046Z ....................................i............................................................... 5800/9755
2020-03-10T22:53:15.0932226Z .................................................................................................... 5900/9755
2020-03-10T22:53:15.0932226Z .................................................................................................... 5900/9755
2020-03-10T22:53:25.4628512Z .................................................................................................... 6000/9755
2020-03-10T22:53:34.3764124Z .............................ii...i..ii...........i................................................. 6100/9755
2020-03-10T22:53:50.2244257Z .................................................................................................... 6300/9755
2020-03-10T22:53:53.6014159Z .................................................................................................... 6400/9755
2020-03-10T22:53:53.6014159Z .................................................................................................... 6400/9755
2020-03-10T22:53:59.7432297Z ............................................................i..ii................................... 6500/9755
2020-03-10T22:54:22.8859492Z .................................................................................................... 6700/9755
2020-03-10T22:54:26.0946218Z ......................................................i............................................. 6800/9755
2020-03-10T22:54:27.8603848Z .................................................................................................... 6900/9755
2020-03-10T22:54:29.7854660Z .....................................................................................i.............. 7000/9755
---
2020-03-10T22:55:58.9901967Z .................................................................................................... 7700/9755
2020-03-10T22:56:02.9732004Z .................................................................................................... 7800/9755
2020-03-10T22:56:08.5997252Z .................................................................................................... 7900/9755
2020-03-10T22:56:15.4613385Z ...................................i................................................................ 8000/9755
2020-03-10T22:56:24.2417521Z ....................................................................................iiiiiiiiii.i.... 8100/9755
2020-03-10T22:56:39.3786715Z ............................i......i................................................................ 8300/9755
2020-03-10T22:56:44.0361075Z .................................................................................................... 8400/9755
2020-03-10T22:56:54.8351382Z .................................................................................................... 8500/9755
2020-03-10T22:57:06.2521797Z .................................................................................................... 8600/9755
---
2020-03-10T22:59:20.8935710Z finished in 6.803
2020-03-10T22:59:20.9128921Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T22:59:21.1019329Z 2020-03-10T22:59:21.1019716Z running 179 tests
2020-03-10T22:59:23.8978884Z iiii......i...........ii..iiii....i....i...........i............i..i..................i....i........ 100/179
2020-03-10T22:59:26.1032823Z ....i.i.i...iii..iiiiiiiiiiiiiiii.......................iii............ii......
2020-03-10T22:59:26.1035508Z 2020-03-10T22:59:26.1040262Z finished in 5.191
2020-03-10T22:59:26.1275543Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T22:59:26.2842729Z ---
2020-03-10T22:59:28.1273468Z finished in 2.002
2020-03-10T22:59:28.1486375Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T22:59:28.3057925Z 2020-03-10T22:59:28.3058886Z running 9 tests
2020-03-10T22:59:28.3060132Z iiiiiiiii
2020-03-10T22:59:28.3061465Z 2020-03-10T22:59:28.3064961Z finished in 0.158
2020-03-10T22:59:28.3257870Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T22:59:28.4969806Z ---
2020-03-10T22:59:47.2245961Z finished in 18.898
2020-03-10T22:59:47.7498470Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T22:59:47.9280433Z 2020-03-10T22:59:47.9280791Z running 115 tests
2020-03-10T23:00:00.5862557Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-10T23:00:02.0919924Z ...iiii.....ii.
2020-03-10T23:00:02.0921482Z 2020-03-10T23:00:02.0925468Z finished in 14.343
2020-03-10T23:00:02.0930720Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-10T23:00:02.0931658Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-03-10T23:11:54.2365265Z 2020-03-10T23:11:54.2366603Z Doc-tests core
2020-03-10T23:11:58.7779398Z 2020-03-10T23:11:58.7780060Z running 2480 tests
2020-03-10T23:12:07.4203470Z ......iiiii......................................................................................... 100/2480
2020-03-10T23:12:16.0404425Z ....................................................................................ii.............. 200/2480
2020-03-10T23:12:35.4135234Z ...................i................................................................................ 400/2480
2020-03-10T23:12:35.4135234Z ...................i................................................................................ 400/2480
2020-03-10T23:12:44.4920147Z ........................................................................i..i..................iiii.. 500/2480
2020-03-10T23:12:59.7374429Z .................................................................................................... 700/2480
2020-03-10T23:13:08.0100276Z .................................................................................................... 800/2480
2020-03-10T23:13:15.9144469Z .................................................................................................... 900/2480
2020-03-10T23:13:23.9560351Z .................................................................................................... 1000/2480
---
2020-03-10T23:16:47.6054274Z 2020-03-10T23:16:47.6054782Z running 1010 tests
2020-03-10T23:17:03.2758785Z i................................................................................................... 100/1010
2020-03-10T23:17:12.5163495Z .................................................................................................... 200/1010
2020-03-10T23:17:19.1795643Z ..................iii......i......i...i......i...................................................... 300/1010
2020-03-10T23:17:23.8678729Z .................................................................................................... 400/1010
2020-03-10T23:17:30.1905753Z ............................................i..i......................................ii............ 500/1010
2020-03-10T23:17:41.8696428Z .................................................................................................... 700/1010
2020-03-10T23:17:41.8696428Z .................................................................................................... 700/1010
2020-03-10T23:17:48.1444567Z ....................................iiii............................................................ 800/1010
2020-03-10T23:18:01.1314640Z .................................................................................................... 900/1010
2020-03-10T23:18:07.3714192Z ..........................................................iiii...................................... 1000/1010
2020-03-10T23:18:07.7842449Z test result: ok. 990 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-03-10T23:18:07.7842697Z 2020-03-10T23:18:07.7953746Z finished in 153.689
2020-03-10T23:18:07.7968370Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-10T23:33:00.2123652Z Checking backtrace v0.3.44
2020-03-10T23:33:02.3600627Z Checking rustc-std-workspace-alloc v1.99.0 (/checkout/src/tools/rustc-std-workspace-alloc)
2020-03-10T23:33:02.3601783Z Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
2020-03-10T23:33:03.1543969Z Documenting std v0.0.0 (/checkout/src/libstd)
2020-03-10T23:33:07.4962253Z error: `[Reference]` cannot be resolved, ignoring it.
2020-03-10T23:33:07.4964714Z --> src/libstd/keyword_docs.rs:932:64
2020-03-10T23:33:07.4966073Z |
2020-03-10T23:33:07.4967596Z 932 | /// For more information on the `pub` keyword, please see the [Reference] section
2020-03-10T23:33:07.4970954Z |
2020-03-10T23:33:07.4972069Z note: the lint level is defined here
2020-03-10T23:33:07.4974797Z --> src/libstd/lib.rs:211:9
2020-03-10T23:33:07.4977204Z |
2020-03-10T23:33:07.4977204Z |
2020-03-10T23:33:07.4980696Z 211 | #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
2020-03-10T23:33:07.4984962Z = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2020-03-10T23:33:07.4985578Z 2020-03-10T23:33:07.4985578Z 2020-03-10T23:33:07.4986341Z error: `[Reference]` cannot be resolved, ignoring it.
2020-03-10T23:33:07.4987326Z --> src/libstd/keyword_docs.rs:934:6
2020-03-10T23:33:07.4988106Z |
2020-03-10T23:33:07.4989348Z 934 | /// [Reference]: ../reference/visibility-and-privacy.html?highlight=pub#visibility-and-privacy
2020-03-10T23:33:07.4991757Z |
2020-03-10T23:33:07.4992862Z = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2020-03-10T23:33:07.4993439Z 2020-03-10T23:33:07.4993439Z 2020-03-10T23:33:07.5003241Z error: `[Reference]` cannot be resolved, ignoring it.
2020-03-10T23:33:07.5004266Z --> src/libstd/keyword_docs.rs:932:64
2020-03-10T23:33:07.5005037Z |
2020-03-10T23:33:07.5006162Z 932 | /// For more information on the `pub` keyword, please see the [Reference] section
2020-03-10T23:33:07.5008836Z |
2020-03-10T23:33:07.5009941Z = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2020-03-10T23:33:07.5010716Z 2020-03-10T23:33:07.7794872Z error: aborting due to 3 previous errors
2020-03-10T23:33:07.7794872Z error: aborting due to 3 previous errors
2020-03-10T23:33:07.7795231Z 2020-03-10T23:33:07.8022972Z error: Could not document `std`.
2020-03-10T23:33:07.8023256Z 2020-03-10T23:33:07.8023405Z Caused by:
2020-03-10T23:33:07.8030181Z process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-type dylib --crate-type rlib --crate-name std src/libstd/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/doc --cfg 'feature="backtrace"' --cfg 'feature="compiler-builtins-c"' --cfg 'feature="default"' --cfg 'feature="panic_unwind"' --cfg 'feature="std_detect_dlsym_getauxval"' --cfg 'feature="std_detect_file_io"' --error-format=json --json=diagnostic-rendered-ansi --markdown-css rust.css --markdown-no-toc --generate-redirect-pages --resource-suffix 1.43.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/liballoc-8176951eda628efd.rmeta --extern backtrace_rs=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libbacktrace-6c3cde2f3fa05ae1.rmeta --extern cfg_if=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libcfg_if-3d1332e0a777003d.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-b38d6b4fdd1ab358.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libcore-488a6c8f96495370.rmeta --extern hashbrown=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libhashbrown-b52ddaece6955c96.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/liblibc-95628d6792815695.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-e4d1532af96285a7.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-e200a5c99f1e2488.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libunwind-972b1d207d4e00af.rmeta` (exit code: 1)
2020-03-10T23:33:07.8041344Z 2020-03-10T23:33:07.8041344Z 2020-03-10T23:33:07.8055949Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-Z" "unstable-options" "-p" "std" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "--resource-suffix" "1.43.0" "--index-page" "/checkout/src/doc/index.md"
2020-03-10T23:33:07.8057340Z 2020-03-10T23:33:07.8057442Z 2020-03-10T23:33:07.8092058Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-03-10T23:33:07.8092450Z Build completed unsuccessfully in 1:34:10
2020-03-10T23:33:07.8092450Z Build completed unsuccessfully in 1:34:10
2020-03-10T23:33:07.8127030Z == clock drift check ==
2020-03-10T23:33:07.8150826Z local time: Tue Mar 10 23:33:07 UTC 2020
2020-03-10T23:33:08.1096806Z network time: Tue, 10 Mar 2020 23:33:08 GMT
2020-03-10T23:33:08.1097316Z == end clock drift check ==
2020-03-10T23:33:11.1450852Z 2020-03-10T23:33:11.1533526Z ##[error]Bash exited with code '1'.
2020-03-10T23:33:11.1548038Z ##[section]Finishing: Run build
2020-03-10T23:33:11.1598040Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-10T23:33:11.1602999Z Task : Get sources
2020-03-10T23:33:11.1603365Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-10T23:33:11.1603685Z Version : 1.0.0
2020-03-10T23:33:11.1603915Z Author : Microsoft
2020-03-10T23:33:11.1603915Z Author : Microsoft
2020-03-10T23:33:11.1604293Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-10T23:33:11.1604704Z ==============================================================================
2020-03-10T23:33:11.4995968Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-10T23:33:11.5045577Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-10T23:33:11.5134789Z Cleaning up task key
2020-03-10T23:33:11.5136087Z Start cleaning up orphan processes.
2020-03-10T23:33:11.5292892Z Terminate orphan process: pid (3793) (python)
2020-03-10T23:33:11.5516995Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-03-11T17:32:28Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-11T17:16:58.8329690Z ========================== Starting Command Output ===========================
2020-03-11T17:16:58.8332335Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/3788a8f2-78a9-4dca-abe5-7b529cc5b7c2.sh
2020-03-11T17:16:58.8332595Z 2020-03-11T17:16:58.8337320Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-11T17:16:58.8357656Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69723/merge to s
2020-03-11T17:16:58.8361441Z Task : Get sources
2020-03-11T17:16:58.8361732Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-11T17:16:58.8362008Z Version : 1.0.0
2020-03-11T17:16:58.8362196Z Author : Microsoft
---
2020-03-11T17:16:59.8485393Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-11T17:16:59.8491022Z ##[command]git config gc.auto 0
2020-03-11T17:16:59.8494692Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-11T17:16:59.8498714Z ##[command]git config --get-all http.proxy
2020-03-11T17:16:59.8505194Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69723/merge:refs/remotes/pull/69723/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Mark-Simulacrum

I think the blank line in between was actually the problem though not sure :)

ghost · 2020-03-11T19:32:15Z

I think the blank line in between was actually the problem though not sure :)

I'm not sure either! Always exciting to see what Tina has to say. :D

Mark-Simulacrum · 2020-03-11T22:28:24Z

This is looking great! I think the last thing to do is to squash the commits into one. I would recommend to use git rebase -i origin/master (if origin is your rust-lang/rust remote) and then change "pick" to "f" on all but the first line. Once that's done, you should have just one commit left which you can then git push -f up to this branch.

If you want I can also do this for you and push up to this branch, or alternatively feel free to ping me on Zulip or Discord (@simulacrum) too.

ghost · 2020-03-13T14:47:58Z

Hi, Mark. Thanks so much for your help!
I am not very familiar with git, and have been mostly using the browser. In my next pull request I'll definitely be using the terminal more, but if you could help me rebase this one I'd appreciate it.

Mark-Simulacrum · 2020-03-13T15:10:31Z

No problem!

@bors r+ rollup=always

bors · 2020-03-13T15:10:33Z

📌 Commit b27a77ee7310dc7bd5044898388dc00a0464c886 has been approved by Mark-Simulacrum

bors · 2020-03-13T15:10:34Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

Mark-Simulacrum · 2020-03-13T15:14:28Z

@bors r+ rollup=always

bors · 2020-03-13T15:14:29Z

📌 Commit 87f8ee6 has been approved by Mark-Simulacrum

bors · 2020-03-13T15:14:30Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

…acrum Added doc on keyword Pub. Hi, this is my first pull request. I hope it's OK. Please let me know if it would benefit from any changes. Thank you.

@ghost

Rollup of 12 pull requests Successful merges: - #69403 (Implement `Copy` for `IoSlice`) - #69460 (Move some `build-pass` tests to `check-pass`) - #69723 (Added doc on keyword Pub.) - #69802 (fix more clippy findings) - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes)) - #69947 (Clean up E0423 explanation) - #69949 (triagebot.toml: add ping aliases) - #69954 (rename panic_if_ intrinsics to assert_) - #69960 (miri engine: fix treatment of abort intrinsic) - #69966 (Add more regression tests) - #69973 (Update stable-since version for const_int_conversion) - #69974 (Clean up E0434 explanation) Failed merges: r? @ghost

rust-highfive assigned nikomatsakis Mar 5, 2020

rust-highfive assigned Mark-Simulacrum and unassigned nikomatsakis Mar 5, 2020

JohnTitor added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 5, 2020

Mark-Simulacrum reviewed Mar 8, 2020
View reviewed changes

Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated

Mark-Simulacrum reviewed Mar 10, 2020
View reviewed changes

Comment threadsrc/libstd/keyword_docs.rs Outdated

Mark-Simulacrum reviewed Mar 11, 2020
View reviewed changes

Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2020

Add documentation for pub keyword
87f8ee6

Centril mentioned this pull request Mar 13, 2020
Rollup of 11 pull requests #69979
Closed

JohnTitor mentioned this pull request Mar 13, 2020
Rollup of 12 pull requests #69986
Merged

bors merged commit 35df9cc into rust-lang:masterMar 13, 2020

ghost deleted the sjud-doc-request branch March 15, 2020 23:01

Uh oh!

Uh oh!

Conversation

ghost commented Mar 5, 2020

Uh oh!

Dylan-DPC-zz commented Mar 5, 2020

Uh oh!

Mark-Simulacrum commented Mar 5, 2020

Uh oh!

ghost commented Mar 6, 2020

Uh oh!

rust-highfive commented Mar 6, 2020

Uh oh!

rust-highfive commented Mar 7, 2020

Uh oh!

rust-highfive commented Mar 7, 2020

Uh oh!

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 9, 2020

Uh oh!

rust-highfive commented Mar 9, 2020

Uh oh!

rust-highfive commented Mar 10, 2020

Uh oh!

Mark-SimulacrumMar 10, 2020

Choose a reason for hiding this comment

Uh oh!

Mark-SimulacrumMar 10, 2020

Choose a reason for hiding this comment

Uh oh!

Mark-SimulacrumMar 10, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Mar 10, 2020

Uh oh!

Mark-SimulacrumMar 10, 2020

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented Mar 10, 2020

Uh oh!

Uh oh!

rust-highfive commented Mar 11, 2020

Uh oh!

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 11, 2020• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mark-Simulacrum commented Mar 11, 2020

Uh oh!

ghost commented Mar 13, 2020

Uh oh!

Mark-Simulacrum commented Mar 13, 2020

Uh oh!

bors commented Mar 13, 2020

Uh oh!

bors commented Mar 13, 2020

Uh oh!

Mark-Simulacrum commented Mar 13, 2020

Uh oh!

bors commented Mar 13, 2020

Uh oh!

bors commented Mar 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

ghost commented Mar 11, 2020•
edited by ghost
Loading