Uh oh!
There was an error while loading. Please reload this page.
miri engine: fix treatment of abort intrinsic - #69960
Merged
Merged
Conversation
oli-obk
commented
Mar 12, 2020
Contributor
@bors r+ |
bors
commented
Mar 12, 2020
Collaborator
📌 Commit e9c9657 has been approved by |
This comment has been minimized.
This comment has been minimized.
RalfJung
commented
Mar 13, 2020
MemberAuthor
@bors r- |
RalfJung
commented
Mar 13, 2020
MemberAuthor
Blessed tests. |
bors
commented
Mar 13, 2020
Collaborator
📌 Commit 13ea774 has been approved by |
emilyalbini
commented
Mar 13, 2020
Member
Had to kill the PR build to get CI back up and running, sorry for the trouble. |
RalfJung
commented
Mar 13, 2020
MemberAuthor
@pietroalbini no problem; can I close and re-open the PR to get CI here? |
emilyalbini
commented
Mar 13, 2020
Member
Please wait a bit before doing that (like an hour), thanks! |
RalfJung
commented
Mar 13, 2020
MemberAuthor
@bors rollup |
bors added a commit
that referenced
this pull request
Mar 13, 2020
Rollup of 12 pull requests Successful merges: - #69403 (Implement `Copy` for `IoSlice`) - #69460 (Move some `build-pass` tests to `check-pass`) - #69723 (Added doc on keyword Pub.) - #69802 (fix more clippy findings) - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes)) - #69947 (Clean up E0423 explanation) - #69949 (triagebot.toml: add ping aliases) - #69954 (rename panic_if_ intrinsics to assert_) - #69960 (miri engine: fix treatment of abort intrinsic) - #69966 (Add more regression tests) - #69973 (Update stable-since version for const_int_conversion) - #69974 (Clean up E0434 explanation) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I screwed up in #69830 and added
abortto the wrong block of intrinsics, namely the one that actually has a return place. So that branch was never actually reached.r? @oli-obk