Skip to content

bootstrap: Use hash to determine if sanitizers needs to be rebuilt - #69735

Merged
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:bootstrap-sanitizers-hash
Mar 17, 2020
Merged

bootstrap: Use hash to determine if sanitizers needs to be rebuilt#69735
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:bootstrap-sanitizers-hash

Conversation

@tmiasko

Copy link
Copy Markdown
Contributor
  • Rebuild sanitizers runtimes when LLVM submodule commit changes.
  • When rebuilding LLVM / sanitizers, remove the stamp file before
    starting the build process to invalidate previous build output.

* Rebuild sanitizers runtimes when LLVM submodule commit changes.
* When rebuilding LLVM / sanitizers, remove the stamp file before
starting the build process to invalidate previous build output.

@Mark-SimulacrumMark-Simulacrum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks predominantly correct to me.

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 726d518 has been approved by Mark-Simulacrum

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 5, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2020
…r=Mark-Simulacrum
bootstrap: Use hash to determine if sanitizers needs to be rebuilt
* Rebuild sanitizers runtimes when LLVM submodule commit changes.
* When rebuilding LLVM / sanitizers, remove the stamp file before
starting the build process to invalidate previous build output.
Centril added a commit to Centril/rust that referenced this pull request Mar 17, 2020
…r=Mark-Simulacrum
bootstrap: Use hash to determine if sanitizers needs to be rebuilt
* Rebuild sanitizers runtimes when LLVM submodule commit changes.
* When rebuilding LLVM / sanitizers, remove the stamp file before
starting the build process to invalidate previous build output.
@CentrilCentril mentioned this pull request Mar 17, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 17, 2020
…r=Mark-Simulacrum
bootstrap: Use hash to determine if sanitizers needs to be rebuilt
* Rebuild sanitizers runtimes when LLVM submodule commit changes.
* When rebuilding LLVM / sanitizers, remove the stamp file before
starting the build process to invalidate previous build output.
@CentrilCentril mentioned this pull request Mar 17, 2020
@CentrilCentril mentioned this pull request Mar 17, 2020
bors added a commit that referenced this pull request Mar 17, 2020
Rollup of 7 pull requests
Successful merges:
- #68746 (Make macro metavars respect (non-)hygiene)
- #69688 (Move tidy check to mingw-check)
- #69735 (bootstrap: Use hash to determine if sanitizers needs to be rebuilt)
- #69922 (implement zeroed and uninitialized with MaybeUninit)
- #69956 (Ensure HAS_FREE_LOCAL_NAMES is set for ReFree)
- #70061 (Cosmetic fixes in documentation)
- #70064 (Update books)
Failed merges:
r? @ghost
@bors
bors merged commit c4a900f into rust-lang:masterMar 17, 2020
@tmiasko
tmiasko deleted the bootstrap-sanitizers-hash branch March 17, 2020 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tmiasko@Mark-Simulacrum@bors