Skip to content

Ensure HAS_FREE_LOCAL_NAMES is set for ReFree - #69956

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:fix-region-flags
Mar 17, 2020
Merged

Ensure HAS_FREE_LOCAL_NAMES is set for ReFree#69956
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:fix-region-flags

Conversation

@matthewjasper

Copy link
Copy Markdown
Contributor

This fixes a bug introduced by #69469.
I don't have any ideas on how to reate a regression test for this.

@matthewjaspermatthewjasper added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2020
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2020
@ecstatic-morse

Copy link
Copy Markdown
Contributor

Reassigning to the first suggested reviewer.

r? @nikomatsakis

@nikomatsakis

Copy link
Copy Markdown
Contributor

Seems reasonable

@bors r+

@bors

bors commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f4eb6ed has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 17, 2020
…ikomatsakis
Ensure HAS_FREE_LOCAL_NAMES is set for ReFree
This fixes a bug introduced by rust-lang#69469.
I don't have any ideas on how to reate a regression test for this.
Centril added a commit to Centril/rust that referenced this pull request Mar 17, 2020
…ikomatsakis
Ensure HAS_FREE_LOCAL_NAMES is set for ReFree
This fixes a bug introduced by rust-lang#69469.
I don't have any ideas on how to reate a regression test for this.
@CentrilCentril mentioned this pull request Mar 17, 2020
@CentrilCentril mentioned this pull request Mar 17, 2020
bors added a commit that referenced this pull request Mar 17, 2020
Rollup of 7 pull requests
Successful merges:
- #68746 (Make macro metavars respect (non-)hygiene)
- #69688 (Move tidy check to mingw-check)
- #69735 (bootstrap: Use hash to determine if sanitizers needs to be rebuilt)
- #69922 (implement zeroed and uninitialized with MaybeUninit)
- #69956 (Ensure HAS_FREE_LOCAL_NAMES is set for ReFree)
- #70061 (Cosmetic fixes in documentation)
- #70064 (Update books)
Failed merges:
r? @ghost
@bors
bors merged commit 98295f7 into rust-lang:masterMar 17, 2020
@matthewjasper
matthewjasper deleted the fix-region-flags branch March 17, 2020 18:30
@CentrilCentril added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 25, 2020
@pnkfelix

Copy link
Copy Markdown
Contributor

Discussed in T-compiler meeting. Somewhat reluctantly accepted for beta-backport.

@pnkfelixpnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2020
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 3, 2020
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Apr 3, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2020
…ulacrum
[beta] backport 4 PRs
This backports the following PRs:
* parse_and_disallow_postfix_after_cast: account for `ExprKind::Err`. rust-lang#70556
* Account for bad placeholder types in where clauses rust-lang#70294
* Fix "since" field for `Once::is_complete`'s `#[stable]` attribute rust-lang#70018
* Ensure HAS_FREE_LOCAL_NAMES is set for ReFree rust-lang#69956
All commits cherry picked cleanly.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@matthewjasper@rust-highfive@ecstatic-morse@nikomatsakis@bors@pnkfelix@Centril@Mark-Simulacrum