[stable] Release 1.42.0 by emilyalbini · Pull Request #69854 · rust-lang/rust

emilyalbini · 2020-03-09T14:34:15Z

This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs:

Update deprecation version to 1.42 for Error::description #69754: Update deprecation version to 1.42 for Error::description
Do not ICE when matching an uninhabited enum's field #69753: Do not ICE when matching an uninhabited enum's field
error_derive_forbidden_on_non_adt: be more graceful #69522 / [beta] error_derive_forbidden_on_non_adt: be more graceful #69853: error_derive_forbidden_on_non_adt: be more graceful
Fix null synthetic_implementors error #68598: Fix null synthetic_implementors error

In addition, the release notes are updated to include the remaining compatibility notes.

r? @Centril

Error::description is deprecated as of version 1.42, as the commit was not in the release for 1.41.

…lf). (And added Ralf's suggested test.) Added my own three-variant multi-variant as well.

Centril · 2020-03-09T14:37:38Z

🎉 🚀 🎈 🥂

@bors r+ p=2000 rollup=never

cc @Mark-Simulacrum

bors · 2020-03-09T14:37:40Z

📌 Commit 133f659 has been approved by Centril

bors · 2020-03-09T14:37:41Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

bors · 2020-03-09T15:16:55Z

⌛ Testing commit 133f659 with merge 96ba21ae93f86d9f22afaeb25aa5dbfaf36d08b7...

rust-highfive · 2020-03-09T15:20:36Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-09T15:17:40.5045127Z Prepare build directory.
2020-03-09T15:17:40.5381321Z Set build variables.
2020-03-09T15:17:40.5417314Z Download all required tasks.
2020-03-09T15:17:40.5545121Z Downloading task: Bash (3.163.1)
2020-03-09T15:17:41.5086890Z Checking job knob settings.
2020-03-09T15:17:41.5106799Z Finished checking job knob settings.
2020-03-09T15:17:41.5567283Z ##[section]Finishing: Initialize job
2020-03-09T15:17:41.5917198Z ##[section]Starting: Configure Job Name
2020-03-09T15:17:41.7279241Z ==============================================================================
2020-03-09T15:17:41.7279933Z Task : Bash

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-03-09T15:20:48Z

💔 Test failed - checks-azure

Centril · 2020-03-09T15:25:25Z

@bors retry

bors · 2020-03-09T15:25:36Z

⌛ Testing commit 133f659 with merge 49137562b518c8cbcb88ea7ae31ce2ce0da8e6ff...

rust-highfive · 2020-03-09T15:28:42Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-09T15:26:45.3094924Z Prepare build directory.
2020-03-09T15:26:45.3710876Z Set build variables.
2020-03-09T15:26:45.3749011Z Download all required tasks.
2020-03-09T15:26:45.3905588Z Downloading task: Bash (3.163.1)
2020-03-09T15:26:47.2776916Z Checking job knob settings.
2020-03-09T15:26:47.2800580Z Finished checking job knob settings.
2020-03-09T15:26:47.3396623Z ##[section]Finishing: Initialize job
2020-03-09T15:26:47.3827146Z ##[section]Starting: Configure Job Name
2020-03-09T15:26:47.5374036Z ==============================================================================
2020-03-09T15:26:47.5375081Z Task : Bash

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-03-09T15:28:53Z

💔 Test failed - checks-azure

emilyalbini · 2020-03-09T16:30:17Z

@bors retry

bors · 2020-03-09T16:30:30Z

⌛ Testing commit 133f659 with merge 39ac5ed...

@Centril

[stable] Release 1.42.0 This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs: * #69754: Update deprecation version to 1.42 for Error::description * #69753: Do not ICE when matching an uninhabited enum's field * #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful * #68598: Fix null synthetic_implementors error In addition, the release notes are updated to include the remaining compatibility notes. r? @Centril

bors · 2020-03-09T16:36:08Z

💔 Test failed - checks-azure

rust-highfive · 2020-03-09T16:36:11Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-09T16:31:17.8829269Z Prepare build directory.
2020-03-09T16:31:17.9204481Z Set build variables.
2020-03-09T16:31:17.9244094Z Download all required tasks.
2020-03-09T16:31:17.9377270Z Downloading task: Bash (3.163.1)
2020-03-09T16:31:19.2623547Z Checking job knob settings.
2020-03-09T16:31:19.2648342Z Finished checking job knob settings.
2020-03-09T16:31:19.3179566Z ##[section]Finishing: Initialize job
2020-03-09T16:31:19.3560962Z ##[section]Starting: Configure Job Name
2020-03-09T16:31:19.5032667Z ==============================================================================
2020-03-09T16:31:19.5033601Z Task : Bash

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

emilyalbini · 2020-03-09T17:53:55Z

@bors retry

bors · 2020-03-09T17:54:09Z

⌛ Testing commit 133f659 with merge 6b84fdc2aab24371c5c9c5c41bd2c588a0ac600f...

bors · 2020-03-09T22:09:08Z

💥 Test timed out

emilyalbini · 2020-03-09T22:09:45Z

@bors retry

bors · 2020-03-09T22:09:57Z

⌛ Testing commit 133f659 with merge b8cedc0...

bors · 2020-03-10T01:17:05Z

☀️ Test successful - checks-azure
Approved by: Centril
Pushing b8cedc0 to stable...

dylnugeand others added 8 commits March 9, 2020 13:07

Update deprecation version to 1.42 for Error::description
21e4fa6
Error::description is deprecated as of version 1.42, as the commit was not in the release for 1.41.

Fixrust-lang#69191
158e421

Add FIXME
ffaa73f

Added oli's multivariant test case (alpha renaming the enum name itse…
c7118d4
…lf). (And added Ralf's suggested test.) Added my own three-variant multi-variant as well.

Fix null synthetic_implementors error
153e002

error_derive_forbidden_on_non_adt: be more graceful
c12687b

include compatibility notes for 1.42.0
182b777

1.42.0 stable release
133f659

rust-highfive assigned Centril Mar 9, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 9, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2020

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 9, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 10, 2020

bors merged commit b8cedc0 into rust-lang:stableMar 10, 2020

emilyalbini deleted the stable-next branch March 10, 2020 09:49

Uh oh!

Uh oh!

Conversation

emilyalbini commented Mar 9, 2020• edited by Centril Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Centril commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

rust-highfive commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

Centril commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

rust-highfive commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

emilyalbini commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

rust-highfive commented Mar 9, 2020

Uh oh!

emilyalbini commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

emilyalbini commented Mar 9, 2020

Uh oh!

bors commented Mar 9, 2020

Uh oh!

bors commented Mar 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

emilyalbini commented Mar 9, 2020•
edited by Centril
Loading