Uh oh!
There was an error while loading. Please reload this page.
Update deprecation version to 1.42 for Error::description - #69754
Conversation
Error::description is deprecated as of version 1.42, as the commit was not in the release for 1.41.
rust-highfive
commented
Mar 6, 2020
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
emilyalbini
commented
Mar 6, 2020
Mark-Simulacrum
commented
Mar 6, 2020
@bors r+ |
bors
commented
Mar 6, 2020
📌 Commit 9afbf28 has been approved by |
bors
commented
Mar 6, 2020
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
emilyalbini
commented
Mar 6, 2020
Ping @rust-lang/libs, this needs to be beta-accepted in the next 3 days if you want to include it in stable 1.42.0. |
sfackler
commented
Mar 6, 2020
IMO that's more up to how the release folks feel about landing more backports. It seems pretty low risk, but also fairly low benefit. |
emilyalbini
commented
Mar 6, 2020
If you say it's low risk we can just bundle it in the stable promotion PR. |
Mark-Simulacrum
commented
Mar 6, 2020
I'm marking as beta accepted, it's a trivial change. |
…-Simulacrum Update deprecation version to 1.42 for Error::description Error::description is deprecated as of version 1.42, as the commit was not in the release for 1.41. Fixesrust-lang#69751
Rollup of 9 pull requests Successful merges: - #67741 (When encountering an Item in a pat context, point at the item def) - #68985 (Parse & reject postfix operators after casts) - #69656 (Use .next() instead of .nth(0) on iterators.) - #69680 (rustc_expand: Factor out `Annotatable::into_tokens` to a separate method) - #69690 (test(pattern): add tests for combinations of pattern features) - #69706 (Use subslice patterns in slice methods) - #69727 (Avoid using `unwrap()` in suggestions) - #69754 (Update deprecation version to 1.42 for Error::description) - #69782 (Don't redundantly repeat field names (clippy::redundant_field_names)) Failed merges: r? @ghost
[stable] Release 1.42.0 This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs: * #69754: Update deprecation version to 1.42 for Error::description * #69753: Do not ICE when matching an uninhabited enum's field * #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful * #68598: Fix null synthetic_implementors error In addition, the release notes are updated to include the remaining compatibility notes. r? @Centril
[stable] Release 1.42.0 This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs: * #69754: Update deprecation version to 1.42 for Error::description * #69753: Do not ICE when matching an uninhabited enum's field * #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful * #68598: Fix null synthetic_implementors error In addition, the release notes are updated to include the remaining compatibility notes. r? @Centril
Error::description is deprecated as of version 1.42, as the commit was
not in the release for 1.41.
Fixes#69751