Skip to content

Add long error explanation for E0634 - #69998

Merged
bors merged 3 commits into
rust-lang:masterfrom
ayushmishra2005:doc/61137-add-long-error-code-e0634
Mar 16, 2020
Merged

Add long error explanation for E0634#69998
bors merged 3 commits into
rust-lang:masterfrom
ayushmishra2005:doc/61137-add-long-error-code-e0634

Conversation

@ayushmishra2005

@ayushmishra2005ayushmishra2005 commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

Add long explanation for the E0634 error code
Part of #61137

r? @GuillaumeGomez

@rust-highfive

rust-highfive commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

rust-highfive commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2020
Dylan-DPC-zz
Dylan-DPC-zz suggested changes Mar 14, 2020
View reviewed changes
Comment threadsrc/librustc_error_codes/error_codes/E0634.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0634.md Outdated
GuillaumeGomez
GuillaumeGomez approved these changes Mar 14, 2020
View reviewed changes

@GuillaumeGomezGuillaumeGomez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (minus the corrections @Dylan-DPC asked for)!

@GuillaumeGomezGuillaumeGomez mentioned this pull request Mar 14, 2020
Closed
100 tasks
ayushmishra2005and others added 2 commits March 15, 2020 06:49
@ayushmishra2005@Dylan-DPC
Update src/librustc_error_codes/error_codes/E0634.md
5760db1
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
@ayushmishra2005@Dylan-DPC
Update src/librustc_error_codes/error_codes/E0634.md
2974685
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
@GuillaumeGomez

GuillaumeGomez commented Mar 15, 2020

Copy link
Copy Markdown
Member

Thanks!

@bors: r=Dylan-DPC,GuillaumeGomez rollup

@bors

bors commented Mar 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2974685 has been approved by Dylan-DPC,GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 15, 2020
@Dylan-DPC
Rollup merge ofrust-lang#69998- ayushmishra2005:doc/61137-add-long-…
d733285
…error-code-e0634, r=Dylan-DPC,GuillaumeGomez
Add long error explanation for E0634
Add long explanation for the E0634 error code
Part of rust-lang#61137
r? @GuillaumeGomez
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 15, 2020
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 16, 2020
Merged
bors added a commit that referenced this pull request Mar 16, 2020
@bors
Auto merge of#70034- Dylan-DPC:rollup-5yg771j, r=Dylan-DPC
97eda01
Rollup of 8 pull requests
Successful merges:
- #69686 (Use `pprust` to print attributes in rustdoc)
- #69858 (std: on Windows, use GetSystemTimePreciseAsFileTime if it is available)
- #69917 (Cleanup E0412 and E0422)
- #69964 (Add Node.js to PR CI image)
- #69992 (Block version-specific docs from search engines)
- #69995 (Add more context to the literal overflow message)
- #69998 (Add long error explanation for E0634)
- #70014 (Small fixes in rustdoc book)
Failed merges:
r? @ghost
@bors
bors merged commit 9296d77 into rust-lang:masterMar 16, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes
@Dylan-DPC-zzDylan-DPC-zzAwaiting requested review from Dylan-DPC-zz

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ayushmishra2005@rust-highfive@GuillaumeGomez@bors@Dylan-DPC-zz