Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #70034
Merged
Merged
Conversation
This should allow the `rustdoc-js` and `rustdoc-js-std` test suites to run automatically on PRs.
Stable, beta and nightly URLs remain
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
…umeGomez Use `pprust` to print attributes in rustdoc Fixesrust-lang#69559. I'm not sure what the original motivation was for the `render_attribute`, so I may be missing something, but replacing it with `pprust::attribute_to_string` seems to give the intended output (modulo some spacing idiosyncrasies). r? @GuillaumeGomez
std: on Windows, use GetSystemTimePreciseAsFileTime if it is available This implements rust-lang#67266.
…an-DPC Cleanup E0412 and E0422 r? @Dylan-DPC
…m,GuillaumeGomez Add Node.js to PR CI image This should allow the `rustdoc-js` and `rustdoc-js-std` test suites to run automatically on PRs.
Block version-specific docs from search engines Latest stable, beta and nightly URLs remain accessible because their URLs don't start with a version number. Robots.txt uses simple path prefixes, so it's OK that the disallow rules aren't full directory paths. Direct links to old docs remain accessible to users, because robots.txt only affects crawlers. With this change old docs for specific old versions of Rust won't pop up in search results. This is good, because users won't be getting obsolete documentation by accident.
…flow, r=ecstatic-morse Add more context to the literal overflow message related to issue rust-lang#63733
…error-code-e0634, r=Dylan-DPC,GuillaumeGomez Add long error explanation for E0634 Add long explanation for the E0634 error code Part of rust-lang#61137 r? @GuillaumeGomez
…ok, r=Dylan-DPC
Small fixes in rustdoc book
I read the `rustdoc` book today and noticed some small typos/problems. Mainly:
- `# fn foo() {}` was displayed when not needed because fenced block code type was `text` instead of `rust`;
- two path separators were missing and some Windows-style separators were not consistent with the rest of them (mainly Linux-style).
Here are my proposed fixes. It is my first PR for the rust project. Don't hesitate to tell me if I am doing it wrong or if you need anything else.
Have a nice day!Dylan-DPC-zz
commented
Mar 16, 2020
Author
@bors r+ rollup=never p=8 |
bors
commented
Mar 16, 2020
Collaborator
📌 Commit 6b50a4c has been approved by |
bors
commented
Mar 16, 2020
Collaborator
bors
commented
Mar 16, 2020
Collaborator
☀️ Test successful - checks-azure |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
pprustto print attributes in rustdoc #69686 (Usepprustto print attributes in rustdoc)Failed merges:
r? @ghost