Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #70053
Closed
Centril wants to merge 17 commits into
Closed
Conversation
…y` in a buggy manner
expand: Implement something similar to `#[cfg(accessible(path))]` cc rust-lang#64797 The feature is implemented as a `#[cfg_accessible(path)]` attribute macro rather than as `#[cfg(accessible(path))]` because it needs to wait until `path` becomes resolvable, and `cfg` cannot wait, but macros can wait. Later we can think about desugaring or not desugaring `#[cfg(accessible(path))]` into `#[cfg_accessible(path)]`. This implementation is also incomplete in the sense that it never returns "false" from `cfg_accessible(path)`, it requires some tweaks to resolve, which is not quite ready to answer queries like this during early resolution. However, the most important part of this PR is not `cfg_accessible` itself, but expansion infrastructure for retrying expansions. Before this PR we could say "we cannot resolve this macro path, let's try it later", with this PR we can say "we cannot expand this macro, let's try it later" as well. This is a pre-requisite for - turning `#[derive(...)]` into a regular attribute macro, - properly supporting eager expansion for macros that cannot yet be resolved like ``` fn main() { println!(not_available_yet!()); } macro_rules! make_available { () => { #[macro_export] macro_rules! not_available_yet { () => { "Hello world!" } }} } make_available!(); ```
VariantSizeDifferences: bail on SizeOverflow Fixesrust-lang#69485. r? @oli-obk
resolve: Fix regression in resolution of raw keywords in paths Fixesrust-lang#63882.
Bump the bootstrap compiler
Use sublice patterns to avoid computing the len r? @Centril
…unimplemented, r=eddyb Fiddle `ParamEnv` through to a place that used to use `ParamEnv::empty` in a buggy manner cc rust-lang#69981 (comment) r? @eddyb
Allow `hir().find` to return `None` Fixesrust-lang#70041 r? @eddyb
Centril
commented
Mar 16, 2020
ContributorAuthor
@bors r+ p=7 rollup=never |
bors
commented
Mar 16, 2020
Collaborator
📌 Commit 9d325cf has been approved by |
bors
commented
Mar 16, 2020
Collaborator
⌛ Testing commit 9d325cf with merge b9fa22199c2a75e48c17f5d5cbbd04b3d52af2d7... |
rust-highfive
commented
Mar 16, 2020
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Mar 16, 2020
Collaborator
💔 Test failed - checks-azure |
Dylan-DPC-zz
commented
Mar 16, 2020
@bors retry |
bors
commented
Mar 16, 2020
Collaborator
bors added a commit
that referenced
this pull request
Mar 16, 2020
Rollup of 7 pull requests Successful merges: - #69870 (expand: Implement something similar to `#[cfg(accessible(path))]`) - #69881 (VariantSizeDifferences: bail on SizeOverflow) - #70000 (resolve: Fix regression in resolution of raw keywords in paths) - #70029 (Bump the bootstrap compiler) - #70046 (Use sublice patterns to avoid computing the len) - #70049 (Fiddle `ParamEnv` through to a place that used to use `ParamEnv::empty` in a buggy manner) - #70051 (Allow `hir().find` to return `None`) Failed merges: r? @ghost
rust-highfive
commented
Mar 16, 2020
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
jonas-schievink
commented
Mar 16, 2020
Contributor
@bors r- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[cfg(accessible(path))]#69870 (expand: Implement something similar to#[cfg(accessible(path))])ParamEnvthrough to a place that used to useParamEnv::emptyin a buggy manner #70049 (FiddleParamEnvthrough to a place that used to useParamEnv::emptyin a buggy manner)hir().findto returnNone#70051 (Allowhir().findto returnNone)Failed merges:
r? @ghost