Update the description of the ticket to point at RFC 1721 by 0xPoe · Pull Request #70576 · rust-lang/rust

0xPoe · 2020-03-30T17:05:05Z

My first PR to rust. So please let me know if I'm doing something wrong.

rust-highfive · 2020-03-30T17:05:09Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

eddyb · 2020-03-30T17:16:03Z

r? @rust-lang/compiler (I wish we had a reassignment command)

jonas-schievink · 2020-03-30T17:36:00Z

@Rustin-Liu I think the text should be changed to actually point out what's unstable. The link you added can be added to the tracking issue #37406 instead (someone with editing permissions can add it).

rust-highfive · 2020-03-30T18:14:21Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-30T17:05:45.7363242Z ========================== Starting Command Output ===========================
2020-03-30T17:05:45.7367108Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/9c7dcd20-c25b-4848-8ea3-e18f91f838bd.sh
2020-03-30T17:05:45.7367389Z 2020-03-30T17:05:45.7371367Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-30T17:05:45.7390575Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70576/merge to s
2020-03-30T17:05:45.7393827Z Task : Get sources
2020-03-30T17:05:45.7394151Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-30T17:05:45.7394446Z Version : 1.0.0
2020-03-30T17:05:45.7394646Z Author : Microsoft
---
2020-03-30T17:05:47.0056739Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-30T17:05:47.0062578Z ##[command]git config gc.auto 0
2020-03-30T17:05:47.0066303Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-30T17:05:47.0069730Z ##[command]git config --get-all http.proxy
2020-03-30T17:05:47.0077409Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70576/merge:refs/remotes/pull/70576/merge
---
2020-03-30T17:08:38.1763113Z ---> 3fc1b512c57b
2020-03-30T17:08:38.1763376Z Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
2020-03-30T17:08:38.1766591Z ---> Using cache
2020-03-30T17:08:38.1766961Z ---> 5ee4295733f4
2020-03-30T17:08:38.1768346Z Step 7/7 : ENV SCRIPT python2.7 ../x.py test src/tools/expand-yaml-anchors && python2.7 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu && python2.7 ../x.py build --stage 0 src/tools/build-manifest && python2.7 ../x.py test --stage 0 src/tools/compiletest && python2.7 ../x.py test src/tools/tidy && /scripts/validate-toolstate.sh
2020-03-30T17:08:38.1772660Z ---> 3d07a0fa42fe
2020-03-30T17:08:38.1807337Z Successfully built 3d07a0fa42fe
2020-03-30T17:08:38.1831277Z Successfully tagged rust-ci:latest
2020-03-30T17:08:38.2287192Z Built container sha256:3d07a0fa42feb5754fc13bb2f7010ebe13e4b8b8cdbebed0c75d8da320c8c8ad
---
2020-03-30T17:12:18.2448717Z Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-30T17:12:18.3461211Z Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-30T17:12:18.5270171Z Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-30T17:12:18.6936618Z Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-30T17:12:19.1556660Z Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-30T17:12:21.3175200Z Checking rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-30T17:12:21.7612435Z Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-30T17:12:23.6561682Z Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-30T17:12:24.0682098Z Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-30T17:14:07.1359985Z configure: build.locked-deps := True
2020-03-30T17:14:07.1360415Z configure: llvm.ccache := sccache
2020-03-30T17:14:07.1361016Z configure: build.cargo-native-static := True
2020-03-30T17:14:07.1361629Z configure: dist.missing-tools := True
2020-03-30T17:14:07.1362345Z configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
2020-03-30T17:14:07.1363635Z configure: writing `config.toml` in current directory
2020-03-30T17:14:07.1363975Z configure: 2020-03-30T17:14:07.1364526Z configure: run `python /checkout/x.py --help`
2020-03-30T17:14:07.1364892Z configure: ---
2020-03-30T17:15:25.6229399Z Hugepagesize: 2048 kB
2020-03-30T17:15:25.6229630Z DirectMap4k: 128960 kB
2020-03-30T17:15:25.6229846Z DirectMap2M: 4065280 kB
2020-03-30T17:15:25.6230060Z DirectMap1G: 5242880 kB
2020-03-30T17:15:25.6269130Z + python2.7 ../x.py test src/tools/expand-yaml-anchors
2020-03-30T17:15:26.9361396Z Ensuring the YAML anchors in the GitHub Actions config were expanded
2020-03-30T17:15:26.9361396Z Ensuring the YAML anchors in the GitHub Actions config were expanded
2020-03-30T17:15:26.9373045Z Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu)
2020-03-30T17:15:27.1692235Z Compiling unicode-xid v0.2.0
2020-03-30T17:15:27.2871137Z Compiling syn v1.0.11
2020-03-30T17:15:28.0853471Z Compiling linked-hash-map v0.5.2
2020-03-30T17:15:28.1372567Z Compiling lazy_static v1.4.0
2020-03-30T17:15:28.1372567Z Compiling lazy_static v1.4.0
2020-03-30T17:15:28.3045702Z Compiling yaml-rust v0.4.3
2020-03-30T17:15:32.4755355Z Compiling quote v1.0.2
2020-03-30T17:15:46.0773171Z Compiling thiserror-impl v1.0.5
2020-03-30T17:15:50.6048808Z Compiling thiserror v1.0.5
2020-03-30T17:15:50.6626872Z Compiling yaml-merge-keys v0.4.0
2020-03-30T17:15:51.7719912Z Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors)
2020-03-30T17:15:53.4896495Z Build completed successfully in 0:00:27
2020-03-30T17:15:53.4907558Z + python2.7 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
2020-03-30T17:15:53.7274474Z Finished dev [unoptimized] target(s) in 0.17s
2020-03-30T17:15:54.8087983Z Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
---
2020-03-30T17:17:54.3278859Z Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-30T17:17:54.4165653Z Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-30T17:17:54.6041714Z Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-30T17:17:54.7121136Z Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-30T17:17:55.1855400Z Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-30T17:17:57.3782014Z Checking rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-30T17:17:57.8343942Z Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-30T17:17:59.8353673Z Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-30T17:18:00.2721569Z Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-30T17:21:52.4639249Z skip untracked path src/llvm-project/ during rustfmt invocations
2020-03-30T17:21:54.4026691Z Diff in /checkout/src/librustc_metadata/native_libs.rs at line 162:
2020-03-30T17:21:54.4027012Z }
2020-03-30T17:21:54.4027176Z }
2020-03-30T17:21:54.4027665Z if lib.cfg.is_some() && !self.tcx.features().link_cfg {
2020-03-30T17:21:54.4029488Z - feature_err(&self.tcx.sess.parse_sess, sym::link_cfg, span.unwrap(), "is unstable, see https://github.com/rust-lang/rfcs/pull/1721")
2020-03-30T17:21:54.4030185Z - .emit();
2020-03-30T17:21:54.4030628Z + &self.tcx.sess.parse_sess,
2020-03-30T17:21:54.4030894Z + sym::link_cfg,
2020-03-30T17:21:54.4031128Z + span.unwrap(),
2020-03-30T17:21:54.4031670Z + "is unstable, see https://github.com/rust-lang/rfcs/pull/1721",
2020-03-30T17:21:54.4031670Z + "is unstable, see https://github.com/rust-lang/rfcs/pull/1721",
2020-03-30T17:21:54.4031964Z + )
2020-03-30T17:21:54.4032159Z + .emit();
2020-03-30T17:21:54.4032326Z }
2020-03-30T17:21:54.4032636Z if lib.kind == cstore::NativeStaticNobundle && !self.tcx.features().static_nobundle {
2020-03-30T17:21:54.4032992Z feature_err(
2020-03-30T17:21:54.4033907Z Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/librustc_metadata/native_libs.rs"` failed.
2020-03-30T17:21:54.4034872Z If you're running `tidy`, try again with `--bless` flag. Or, you just want to format code, run `./x.py fmt` instead.
2020-03-30T17:21:54.4043517Z Build completed unsuccessfully in 0:00:36
2020-03-30T17:21:54.4096481Z == clock drift check ==
2020-03-30T17:21:54.4111252Z local time: Mon Mar 30 17:21:54 UTC 2020
2020-03-30T17:21:54.5078833Z network time: Mon, 30 Mar 2020 17:21:54 GMT
2020-03-30T17:21:54.5078833Z network time: Mon, 30 Mar 2020 17:21:54 GMT
2020-03-30T17:21:54.5084345Z == end clock drift check ==
2020-03-30T17:21:56.0249534Z 2020-03-30T17:21:56.0316797Z ##[error]Bash exited with code '1'.
2020-03-30T17:21:56.0332157Z ##[section]Finishing: Run build
2020-03-30T17:21:56.0377536Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70576/merge to s
2020-03-30T17:21:56.0382433Z Task : Get sources
2020-03-30T17:21:56.0382788Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-30T17:21:56.0383106Z Version : 1.0.0
2020-03-30T17:21:56.0383327Z Author : Microsoft
2020-03-30T17:21:56.0383327Z Author : Microsoft
2020-03-30T17:21:56.0383693Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-30T17:21:56.0384090Z ==============================================================================
2020-03-30T17:21:56.3650855Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-30T17:21:56.3697429Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70576/merge to s
2020-03-30T17:21:56.3783852Z Cleaning up task key
2020-03-30T17:21:56.3785121Z Start cleaning up orphan processes.
2020-03-30T17:21:56.3958681Z Terminate orphan process: pid (3450) (python)
2020-03-30T17:21:56.4094563Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-03-31T00:33:13Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-30T23:33:23.6755379Z ========================== Starting Command Output ===========================
2020-03-30T23:33:23.6757986Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/35a9938c-8785-4d53-9c0b-ba7189de7cbf.sh
2020-03-30T23:33:23.6758252Z 2020-03-30T23:33:23.6761608Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-30T23:33:23.6779582Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70576/merge to s
2020-03-30T23:33:23.6783102Z Task : Get sources
2020-03-30T23:33:23.6783411Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-30T23:33:23.6783723Z Version : 1.0.0
2020-03-30T23:33:23.6783923Z Author : Microsoft
---
2020-03-30T23:33:24.9755589Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-30T23:33:24.9835941Z ##[command]git config gc.auto 0
2020-03-30T23:33:24.9839259Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-30T23:33:24.9841856Z ##[command]git config --get-all http.proxy
2020-03-30T23:33:24.9846891Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70576/merge:refs/remotes/pull/70576/merge
---
2020-03-30T23:40:01.7168987Z Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-30T23:40:02.9262168Z Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-30T23:40:04.2918922Z Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-30T23:40:04.6209994Z Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-30T23:40:13.1418421Z Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-30T23:40:14.6033436Z Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-30T23:40:18.3704200Z Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-30T23:40:21.8771339Z Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-30T23:40:30.7529487Z Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-30T23:59:58.2253895Z Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-30T23:59:59.7770410Z Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-31T00:00:01.6591927Z Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-31T00:00:03.0913315Z Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-31T00:00:13.0229231Z Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-31T00:00:15.6596969Z Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-31T00:00:20.3591549Z Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-31T00:00:25.3599590Z Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-31T00:00:35.3645589Z Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-31T00:23:12.6193017Z .................................................................................................... 1700/9856
2020-03-31T00:23:16.0533615Z .................................................................................................... 1800/9856
2020-03-31T00:23:25.1791188Z ..........................................................................................i......... 1900/9856
2020-03-31T00:23:31.1328874Z .................................................................................................... 2000/9856
2020-03-31T00:23:36.6047153Z ................................................................................iiiii............... 2100/9856
2020-03-31T00:23:54.6383019Z .................................................................................................... 2300/9856
2020-03-31T00:23:56.5597913Z .................................................................................................... 2400/9856
2020-03-31T00:23:58.5900332Z .................................................................................................... 2500/9856
2020-03-31T00:24:04.3472482Z .................................................................................................... 2600/9856
2020-03-31T00:24:04.3472482Z .................................................................................................... 2600/9856
2020-03-31T00:24:20.1739166Z .................................................................................................... 2700/9856
2020-03-31T00:24:20.4523639Z .............- error[E0658]: is unstable
2020-03-31T00:24:20.4525876Z + error[E0658]: kind="link_cfg" is unstable, see https://github.com/rust-lang/rfcs/pull/1721
2020-03-31T00:24:20.4529074Z 3 |
2020-03-31T00:24:20.4529074Z 3 |
2020-03-31T00:24:20.4530255Z 4 LL | #[link(name = "foo", cfg(foo))]
2020-03-31T00:24:23.6492161Z F...................................................................................... 2800/9856
2020-03-31T00:24:32.5951124Z .................................................i.................................................. 2900/9856
2020-03-31T00:24:37.9624399Z .................................................................................................... 3000/9856
2020-03-31T00:24:44.5154676Z .................................................................................................... 3100/9856
---
2020-03-31T00:26:41.1549261Z ......................................................i...............i............................. 5000/9856
2020-03-31T00:26:48.2565665Z .................................................................................................... 5100/9856
2020-03-31T00:26:54.7077556Z ...................................................................................................i 5200/9856
2020-03-31T00:26:59.3793979Z .................................................................................................... 5300/9856
2020-03-31T00:27:09.7410680Z .....................................................................................ii.ii........i. 5400/9856
2020-03-31T00:27:13.3193987Z ..i................................................................................................. 5500/9856
2020-03-31T00:27:22.1748886Z ..............................i..................................................................... 5700/9856
2020-03-31T00:27:31.4920391Z ................................................ii....................................i............. 5800/9856
2020-03-31T00:27:38.8666532Z .................................................................................................... 5900/9856
2020-03-31T00:27:43.8445002Z .................................................................................................... 6000/9856
2020-03-31T00:27:43.8445002Z .................................................................................................... 6000/9856
2020-03-31T00:27:52.5377139Z ................................................................................ii...i..ii.......... 6100/9856
2020-03-31T00:28:03.6091227Z .i.................................................................................................. 6200/9856
2020-03-31T00:28:15.7411766Z .................................................................................................... 6400/9856
2020-03-31T00:28:18.8916142Z .................................................................................................... 6500/9856
2020-03-31T00:28:18.8916142Z .................................................................................................... 6500/9856
2020-03-31T00:28:30.1140492Z ..........i..ii..................................................................................... 6600/9856
2020-03-31T00:28:48.1850360Z .................................................................................................... 6800/9856
2020-03-31T00:28:50.1550069Z ..........i......................................................................................... 6900/9856
2020-03-31T00:28:52.0285587Z .................................................................................................... 7000/9856
2020-03-31T00:28:53.9483212Z ...............................................i.................................................... 7100/9856
---
2020-03-31T00:30:22.3315213Z .................................................................................................... 7800/9856
2020-03-31T00:30:27.6257637Z .................................................................................................... 7900/9856
2020-03-31T00:30:33.3690823Z .................................................................................................... 8000/9856
2020-03-31T00:30:40.7570798Z .......i............................................................................................ 8100/9856
2020-03-31T00:30:48.4562306Z ........................................................iiiiiiiiii.i................................ 8200/9856
2020-03-31T00:31:01.1038499Z i......i............................................................................................ 8400/9856
2020-03-31T00:31:05.8372871Z .................................................................................................... 8500/9856
2020-03-31T00:31:17.3991797Z .................................................................................................... 8600/9856
2020-03-31T00:31:26.5682547Z .................................................................................................... 8700/9856
---
2020-03-31T00:33:07.2049819Z diff of stderr:
2020-03-31T00:33:07.2050066Z 2020-03-31T00:33:07.2050286Z 2020-03-31T00:33:07.2050620Z The actual stderr differed from the expected stderr.
2020-03-31T00:33:07.2051526Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-link_cfg/feature-gate-link_cfg.stderr
2020-03-31T00:33:07.2052364Z To update references, rerun the tests and pass the `--bless` flag
2020-03-31T00:33:07.2053347Z To only update this specific test, also pass `--test-args feature-gates/feature-gate-link_cfg.rs`
2020-03-31T00:33:07.2053947Z error: 1 errors occurred comparing output.
2020-03-31T00:33:07.2054251Z status: exit code: 1
2020-03-31T00:33:07.2054251Z status: exit code: 1
2020-03-31T00:33:07.2056041Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/feature-gates/feature-gate-link_cfg.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-link_cfg" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-link_cfg/auxiliary"
2020-03-31T00:33:07.2057737Z ------------------------------------------
2020-03-31T00:33:07.2057986Z 2020-03-31T00:33:07.2058427Z ------------------------------------------
2020-03-31T00:33:07.2058701Z stderr:
2020-03-31T00:33:07.2058701Z stderr:
2020-03-31T00:33:07.2059120Z ------------------------------------------
2020-03-31T00:33:07.2059753Z error[E0658]: kind="link_cfg" is unstable, see https://github.com/rust-lang/rfcs/pull/1721
2020-03-31T00:33:07.2060751Z |
2020-03-31T00:33:07.2060751Z |
2020-03-31T00:33:07.2061007Z LL | #[link(name = "foo", cfg(foo))]
2020-03-31T00:33:07.2061796Z |
2020-03-31T00:33:07.2061796Z |
2020-03-31T00:33:07.2062498Z = note: see issue #37406 <***/issues/37406> for more information
2020-03-31T00:33:07.2062916Z = help: add `#![feature(link_cfg)]` to the crate attributes to enable
2020-03-31T00:33:07.2063455Z error: aborting due to previous error
2020-03-31T00:33:07.2063703Z 2020-03-31T00:33:07.2064190Z For more information about this error, try `rustc --explain E0658`.
2020-03-31T00:33:07.2064477Z ---
2020-03-31T00:33:07.2072258Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-03-31T00:33:07.2072788Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-31T00:33:07.2084484Z 2020-03-31T00:33:07.2084783Z 2020-03-31T00:33:07.2090792Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-03-31T00:33:07.2093095Z 2020-03-31T00:33:07.2093942Z 2020-03-31T00:33:07.2098561Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-03-31T00:33:07.2099770Z Build completed unsuccessfully in 0:56:13
2020-03-31T00:33:07.2099770Z Build completed unsuccessfully in 0:56:13
2020-03-31T00:33:07.2144675Z == clock drift check ==
2020-03-31T00:33:07.2162630Z local time: Tue Mar 31 00:33:07 UTC 2020
2020-03-31T00:33:07.4893571Z network time: Tue, 31 Mar 2020 00:33:07 GMT
2020-03-31T00:33:07.4902670Z == end clock drift check ==
2020-03-31T00:33:07.9842655Z 2020-03-31T00:33:07.9884383Z ##[error]Bash exited with code '1'.
2020-03-31T00:33:07.9896726Z ##[section]Finishing: Run build
2020-03-31T00:33:07.9939451Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70576/merge to s
2020-03-31T00:33:07.9943772Z Task : Get sources
2020-03-31T00:33:07.9944036Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-31T00:33:07.9944266Z Version : 1.0.0
2020-03-31T00:33:07.9944444Z Author : Microsoft
2020-03-31T00:33:07.9944444Z Author : Microsoft
2020-03-31T00:33:07.9944698Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-31T00:33:07.9945005Z ==============================================================================
2020-03-31T00:33:08.2868056Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-31T00:33:08.2912530Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70576/merge to s
2020-03-31T00:33:08.2992143Z Cleaning up task key
2020-03-31T00:33:08.2993050Z Start cleaning up orphan processes.
2020-03-31T00:33:08.3131458Z Terminate orphan process: pid (4444) (python)
2020-03-31T00:33:08.3275106Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

0xPoe · 2020-03-31T00:42:52Z

r?@estebank

0xPoe · 2020-04-03T15:36:30Z

@estebank could you please take a look?

varkor

@Rustin-Liu: after the suggested change, could you flatten your commits into one? Then everything looks good! I think we should be pointing to the tracking issue, but RFC 1721 should be more prominently displayed: I'll try to sort that out.

varkor · 2020-04-03T17:02:06Z

I don't think we need to mention rust-lang/rfcs#1721 here — we already mention the relevant issue below. However, #37406 seems to be closed, so maybe we'll need to open it.
Suggested change
"kind=\"link_cfg\" is unstable, see https://github.com/rust-lang/rfcs/pull/1721",
"kind=\"link_cfg\" is unstable",

Thanks for your review. Removed.

Fmt code Update tests Modify msg Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>

varkor · 2020-04-03T18:25:31Z

@Rustin-Liu: perfect, thank you!

@bors r+ rollup

bors · 2020-04-03T18:25:33Z

📌 Commit d2ad9f4 has been approved by varkor

@ghost

Rollup of 9 pull requests Successful merges: - rust-lang#69860 (Use associated numeric consts in documentation) - rust-lang#70576 (Update the description of the ticket to point at RFC 1721) - rust-lang#70597 (Fix double-free and undefined behaviour in libstd::syn::unix::Thread::new) - rust-lang#70640 (Hide `task_context` when lowering body) - rust-lang#70641 (Remove duplicated code in trait selection) - rust-lang#70707 (Remove unused graphviz emitter) - rust-lang#70720 (Place TLS initializers with relocations in .tdata) - rust-lang#70735 (Clean up E0502 explanation) - rust-lang#70741 (Add test for rust-lang#59023) Failed merges: r? @ghost

rust-highfive assigned eddyb Mar 30, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2020

rust-highfive unassigned eddyb Mar 30, 2020

0xPoe force-pushed the rustin-patch-link-cfg branch from d74f5b5 to 0d3d9cfCompare March 30, 2020 23:32

0xPoe marked this pull request as ready for review March 31, 2020 00:40

rust-highfive assigned estebank Mar 31, 2020

varkor suggested changes Apr 3, 2020
View reviewed changes

varkor assigned varkor and unassigned estebank Apr 3, 2020

Update the description of link_cfg unstable
d2ad9f4
Fmt code Update tests Modify msg Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>

0xPoe force-pushed the rustin-patch-link-cfg branch from 8a566e2 to d2ad9f4Compare April 3, 2020 17:44

0xPoe requested a review from varkor April 3, 2020 17:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2020

Centril mentioned this pull request Apr 3, 2020
Rollup of 9 pull requests #70747
Merged

bors merged commit 17a59fb into rust-lang:masterApr 3, 2020

Navigation Menu

Uh oh!

Uh oh!

Update the description of the ticket to point at RFC 1721 - #70576

Update the description of the ticket to point at RFC 1721#70576
bors merged 1 commit into
rust-lang:masterfrom
0xPoe:rustin-patch-link-cfg

0xPoe commented Mar 30, 2020•
edited
Loading

Uh oh!

rust-highfive commented Mar 30, 2020

Uh oh!

eddyb commented Mar 30, 2020

Uh oh!

jonas-schievink commented Mar 30, 2020

Uh oh!

rust-highfive commented Mar 30, 2020

Uh oh!

rust-highfive commented Mar 31, 2020

Uh oh!

0xPoe commented Mar 31, 2020

Uh oh!

0xPoe commented Apr 3, 2020

Uh oh!

varkor left a comment

Uh oh!

varkorApr 3, 2020

Uh oh!

0xPoeApr 3, 2020•
edited
Loading

Uh oh!

varkor commented Apr 3, 2020

Uh oh!

bors commented Apr 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	"kind=\"link_cfg\" is unstable, see https://github.com/rust-lang/rfcs/pull/1721",
	"kind=\"link_cfg\" is unstable",

Uh oh!

Uh oh!

Conversation

0xPoe commented Mar 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Mar 30, 2020

Uh oh!

eddyb commented Mar 30, 2020

Uh oh!

jonas-schievink commented Mar 30, 2020

Uh oh!

rust-highfive commented Mar 30, 2020

Uh oh!

rust-highfive commented Mar 31, 2020

Uh oh!

0xPoe commented Mar 31, 2020

Uh oh!

0xPoe commented Apr 3, 2020

Uh oh!

varkor left a comment

Choose a reason for hiding this comment

Uh oh!

varkorApr 3, 2020

Choose a reason for hiding this comment

Uh oh!

0xPoeApr 3, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

varkor commented Apr 3, 2020

Uh oh!

bors commented Apr 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

0xPoe commented Mar 30, 2020•
edited
Loading

0xPoeApr 3, 2020•
edited
Loading