Skip to content

Hide task_context when lowering body - #70640

Merged
bors merged 1 commit into
rust-lang:masterfrom
jonas-schievink:async-ice
Apr 3, 2020
Merged

Hide task_context when lowering body#70640
bors merged 1 commit into
rust-lang:masterfrom
jonas-schievink:async-ice

Conversation

@jonas-schievink

@jonas-schievinkjonas-schievink commented Mar 31, 2020

Copy link
Copy Markdown
Contributor

Fixes#70594

@rust-highfive

rust-highfive commented Mar 31, 2020

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@jonas-schievinkjonas-schievink mentioned this pull request Mar 31, 2020
Closed
@cramertj

cramertj commented Apr 1, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit c7d9d89 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2020
Centril added a commit to Centril/rust that referenced this pull request Apr 1, 2020
@Centril
Rollup merge ofrust-lang#70640- jonas-schievink:async-ice, r=cramertj
5a0c0b3
Hide `task_context` when lowering body
Fixesrust-lang#70594
@CentrilCentril mentioned this pull request Apr 1, 2020
Closed
@Centril

Centril commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

Failed in #70648 (comment), @bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2020
@jonas-schievink

jonas-schievink commented Apr 1, 2020

Copy link
Copy Markdown
ContributorAuthor

This part of the diagnostic is missing:

 ::: $SRC_DIR/libcore/future/mod.rs:LL:COL
|
LL | F: Future,
| ------ required by this bound in `std::future::poll_with_context`

No clue why though, it passes on the PR builder

@jonas-schievink

jonas-schievink commented Apr 1, 2020

Copy link
Copy Markdown
ContributorAuthor

Running that Docker container locally, the UI test also passes (though the std::net tests seem to fail, probably due to some misconfiguration). Not sure what else to do here now, does anyone have an idea?

@jonas-schievinkjonas-schievink added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2020
@jonas-schievink

jonas-schievink commented Apr 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Ah it's just #53081. There's a fix for that in the pipeline (#70642) so I can just wait until that lands.

@jonas-schievink

jonas-schievink commented Apr 3, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors r=cramertj

@bors

bors commented Apr 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit c7d9d89 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 3, 2020
@Dylan-DPC
Rollup merge ofrust-lang#70640- jonas-schievink:async-ice, r=cramertj
0b4f8fc
Hide `task_context` when lowering body
Fixesrust-lang#70594
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 3, 2020
Closed
@CentrilCentril mentioned this pull request Apr 3, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2020
@bors
Auto merge ofrust-lang#70747- Centril:rollup-2vx9bve, r=Centril
74bd074
Rollup of 9 pull requests
Successful merges:
- rust-lang#69860 (Use associated numeric consts in documentation)
- rust-lang#70576 (Update the description of the ticket to point at RFC 1721)
- rust-lang#70597 (Fix double-free and undefined behaviour in libstd::syn::unix::Thread::new)
- rust-lang#70640 (Hide `task_context` when lowering body)
- rust-lang#70641 (Remove duplicated code in trait selection)
- rust-lang#70707 (Remove unused graphviz emitter)
- rust-lang#70720 (Place TLS initializers with relocations in .tdata)
- rust-lang#70735 (Clean up E0502 explanation)
- rust-lang#70741 (Add test for rust-lang#59023)
Failed merges:
r? @ghost
@bors
bors merged commit a928f64 into rust-lang:masterApr 3, 2020
@jonas-schievink
jonas-schievink deleted the async-ice branch April 3, 2020 23:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cramertjcramertj

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

internal compiler error: no type for local variable

5 participants

@jonas-schievink@rust-highfive@cramertj@bors@Centril