Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #70648
Closed
Centril wants to merge 39 commits into
Closed
Conversation
This diff improves error messages around raw strings in a few ways: - Catch extra trailing `#` in the parser. This can't be handled in the lexer because we could be in a macro that actually expects another # (see test) - Refactor & unify error handling in the lexer between ByteStrings and RawByteStrings - Detect potentially intended terminators (longest sequence of "#*" is suggested)
This is a pure refactoring with no behavior changes.
This is a follow-up to rust-lang#70123, which added `llvm-config --libdir` to the `LIBRARY_PATH` for rustc tools. We need the same for "run-make-fulldeps" and "ui-fulldeps" tests which depend on compiler libraries, implicitly needing to link to `-lLLVM` as well.
…z, r=davidtwco Add `-Z dump-mir-dataflow` flag for dumping dataflow results visualization Previously, to visualize the results of a MIR dataflow pass, one had to add a `#[rustc_mir(borrowck_graphviz_postflow)]` attribute to functions of interest. However, there is no way to specify this attribute on closures and generators, so it was impossible to view results for these MIR bodies. This PR adds a flag, `-Z dump-mir-dataflow`, which will output the dataflow results for any functions specified in `-Z dump-mir` to the output directory specified by `-Z dump-mir-dir`. This behavior is modeled on the `-Z dump-mir-graphviz` flag.
…rochenkov Improve error messages for raw strings (rust-lang#60762) This diff improves error messages around raw strings in a few ways: - Catch extra trailing `#` in the parser. This can't be handled in the lexer because we could be in a macro that actually expects another # (see test) - Refactor & unify error handling in the lexer between ByteStrings and RawByteStrings - Detect potentially intended terminators (longest sequence of "#*" is suggested) Fixesrust-lang#60762 cc @estebank who reviewed the original (abandoned) PR for the same ticket. r? @Centril
…ddyb Add `can_unwind` field to `FnAbi` This is a pure refactoring with no behavior changes. Extracted out of rust-lang#70467 r? @eddyb
…rk-Simulacrum Ensure LLVM is in the link path for "fulldeps" tests This is a follow-up to rust-lang#70123, which added `llvm-config --libdir` to the `LIBRARY_PATH` for rustc tools. We need the same for "run-make-fulldeps" and "ui-fulldeps" tests which depend on compiler libraries, implicitly needing to link to `-lLLVM` as well.
…opy, r=oli-obk Use place directly its copy r? @oli-obk
Hide `task_context` when lowering body Fixesrust-lang#70594
ContributorAuthor
@bors r+ p=6 rollup=never |
bors
commented
Apr 1, 2020
Collaborator
📌 Commit 5a0c0b3 has been approved by |
bors
commented
Apr 1, 2020
Collaborator
⌛ Testing commit 5a0c0b3 with merge 725736274a8013fe2ae63a507455534834b4b893... |
bors
commented
Apr 1, 2020
Collaborator
💔 Test failed - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Z dump-mir-dataflowflag for dumping dataflow results visualization #70511 (Add-Z dump-mir-dataflowflag for dumping dataflow results visualization)can_unwindfield toFnAbi#70547 (Addcan_unwindfield toFnAbi)task_contextwhen lowering body #70640 (Hidetask_contextwhen lowering body)Failed merges:
rustc_middle#70634 (Remove some reexports inrustc_middle)r? @ghost