Uh oh!
There was an error while loading. Please reload this page.
Improve docs in AllocRef - #70691
Merged
Merged
Conversation
RalfJung
commented
Apr 2, 2020
Member
LGTM but keep in mind that I have no involvement with the allocator WG and didn't know about the new API until 5h ago. |
TimDiekmann
commented
Apr 2, 2020
ContributorAuthor
The changes do not affect the allocator-wg directly, only the trait. You are the expert on undefined behavior and As I'm not a team member I can't r=you. |
RalfJung
commented
Apr 2, 2020
Member
Okay. @bors r+ |
bors
commented
Apr 2, 2020
Collaborator
📌 Commit 0b61239 has been approved by |
RalfJung
commented
Apr 2, 2020
Member
@bors rollup |
ContributorAuthor
Thanks. |
Centril added a commit
to Centril/rust
that referenced
this pull request
Apr 2, 2020
Improve docs in `AllocRef` r? @RalfJung
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#70487 (Stabilize float::to_int_unchecked) - rust-lang#70595 (Remove unused discriminant reads from MIR bodies) - rust-lang#70691 (Improve docs in `AllocRef`) - rust-lang#70694 (Use Self over specific type in return position) - rust-lang#70700 (Expand on platform details of `include_xxx` macros) - rust-lang#70708 (Fix typo in u8::to_ascii_uppercase and u8::to_ascii_lowercase) - rust-lang#70716 (Unerase regions in infer_placeholder_type) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @RalfJung