Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #70722
Merged
Merged
Conversation
This renames and stabilizes unsafe floating point to integer casts, which are intended to be the substitute for the currently unsound `as` behavior, once that changes to safe-but-slower saturating casts.
Allow the `SimplifyLocals` pass to remove reads of discriminants if the read is never used.
…ts, r=SimonSapin Stabilize float::to_int_unchecked This renames and stabilizes unsafe floating point to integer casts, which are intended to be the substitute for the currently unsound `as` behavior, once that changes to safe-but-slower saturating casts. As such, I believe this also likely unblocks rust-lang#10184 (our oldest I-unsound issue!), as once this rolls out to stable it would be far easier IMO to change the behavior of `as` to be safe by default. This does not stabilize the trait or the associated method, as they are deemed internal implementation details (and consumers should not, generally, want to expose them, as in practice all callers likely know statically/without generics what the return type is). Closesrust-lang#67058
…ant_reads, r=oli-obk Remove unused discriminant reads from MIR bodies Allow the `SimplifyLocals` pass to remove reads of discriminants if the read is never used. Fixesrust-lang#70531 r? @oli-obk
Improve docs in `AllocRef` r? @RalfJung
Use Self over specific type in return position
…n-DPC Expand on platform details of `include_xxx` macros This is a small detail that is not explicitly mentioned, but it left me scratching my head for a while until I looked into its implementation details. Maybe worth mentioning.
… r=sfackler Fix typo in u8::to_ascii_uppercase and u8::to_ascii_lowercase Corrects misspelling of fifth.
…ons, r=eddyb Unerase regions in infer_placeholder_type closesrust-lang#70608
Centril
commented
Apr 2, 2020
ContributorAuthor
@bors r+ p=7 rollup=never |
bors
commented
Apr 2, 2020
Collaborator
📌 Commit 98cf9d9 has been approved by |
bors
commented
Apr 2, 2020
Collaborator
bors
commented
Apr 3, 2020
Collaborator
☀️ Test successful - checks-azure |
This was referenced Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
AllocRef#70691 (Improve docs inAllocRef)include_xxxmacros #70700 (Expand on platform details ofinclude_xxxmacros)Failed merges:
r? @ghost