Skip to content

Stabilize UNICODE_VERSION (feature unicode_version) - #71068

Merged
bors merged 1 commit into
rust-lang:masterfrom
pyfisch:unicode-version-stable
Apr 24, 2020
Merged

Stabilize UNICODE_VERSION (feature unicode_version)#71068
bors merged 1 commit into
rust-lang:masterfrom
pyfisch:unicode-version-stable

Conversation

@pyfisch

@pyfischpyfisch commented Apr 12, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Tracking issue: #49726

r? @sfackler

#71020 changed the definition of UNICODE_VERSION just yesterday from a struct to a tuple. Maybe you want to wait some more before stabilizing this constant, on the other hand this is a very small and simple addition.

CC @behnam@SimonSapin@Serentty

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2020
@jonas-schievinkjonas-schievink added A-Unicode Area: Unicode needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api [DEPRECATED; DO NOT USE] labels Apr 12, 2020
@jonas-schievinkjonas-schievink added this to the 1.44 milestone Apr 12, 2020
@Serentty

Serentty commented Apr 12, 2020

Copy link
Copy Markdown
Contributor

Using a u8 to store the version number seems like a bit of a premature optimization to me, but given that it will take hundreds of years before that integer is too small to hold the latest Unicode version, I would support stabilizing this, since I think that not having this functionality is a larger issue than any nitpicks like that.

@sfackler

sfackler commented Apr 12, 2020

Copy link
Copy Markdown
Member

@Serentty the version numbers are defined by the standard to always be one byte each: #49726 (comment).

@sfackler

sfackler commented Apr 12, 2020

Copy link
Copy Markdown
Member

@rfcbot fcp merge

@rfcbot

rfcbot commented Apr 12, 2020•
edited by dtolnay
Loading

Copy link
Copy Markdown

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 12, 2020
@Serentty

Serentty commented Apr 12, 2020

Copy link
Copy Markdown
Contributor

@sfackler I should have checked to see if there was anything like that before commenting. This seems like a perfect solution then.

@rfcbotrfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Apr 13, 2020
@rfcbot

rfcbot commented Apr 13, 2020

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@Mark-Simulacrum

Mark-Simulacrum commented Apr 13, 2020

Copy link
Copy Markdown
Member

I would like to see an explicit note in the documentation that says something about this version number changing over time, and that the value is as such not covered by our stability policy.

@pyfisch

pyfisch commented Apr 13, 2020

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum I've added a note explaining that Rust regularly updates to the most recent Unicode version and that therefore the version number will change.

@Dylan-DPC-zzDylan-DPC-zz modified the milestones: 1.44, 1.45Apr 21, 2020
@rfcbot

rfcbot commented Apr 23, 2020

Copy link
Copy Markdown

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbotrfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 23, 2020
SimonSapin
SimonSapin reviewed Apr 23, 2020
View reviewed changes
Comment threadsrc/libcore/char/mod.rs Outdated

@SimonSapinSimonSapinApr 23, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beta has branched to 1.44: https://github.com/rust-lang/rust/blob/beta/src/bootstrap/channel.rs#L15-L16

So this needs to be 1.45.0, same with the const item below. r=me with this.

@pyfisch
Stabilize UNICODE_VERSION (feature unicode_version)
aa0175c
The feature will become stable in Rust 1.45.
Noted that the value of UNICODE_VERSION is expected to change.
@pyfisch

pyfisch commented Apr 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Changed version to 1.45 and squashed everything into one commit.

r? @SimonSapin

@SimonSapin

SimonSapin commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

Looks good, thanks!

@bors r+

@bors

bors commented Apr 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit aa0175c has been approved by SimonSapin

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 24, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2020
@bors
Auto merge ofrust-lang#71496- Dylan-DPC:rollup-gwxejmk, r=Dylan-DPC
45c7838
Rollup of 6 pull requests
Successful merges:
- rust-lang#70845 (Make the `structural_match` error diagnostic for const generics clearer)
- rust-lang#71063 (Document unsafety in core::{option, hash})
- rust-lang#71068 (Stabilize UNICODE_VERSION (feature unicode_version))
- rust-lang#71426 (fix error code in E0751.md)
- rust-lang#71459 (Add leading 0x to offset in Debug fmt of Pointer)
- rust-lang#71492 (Document unsafety in core::{panicking, alloc::layout, hint, iter::adapters::zip})
Failed merges:
r? @ghost
@bors
bors merged commit c33deb9 into rust-lang:masterApr 24, 2020
@Serentty

Serentty commented Apr 24, 2020

Copy link
Copy Markdown
Contributor

Yay! This is perfect for static asserts in software that needs a certain new version of Unicode.

@pyfisch
pyfisch deleted the unicode-version-stable branch April 25, 2020 15:08
@jplattejplatte mentioned this pull request Apr 26, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonSapinSimonSapinSimonSapin left review comments

Assignees

@SimonSapinSimonSapin

Labels

A-UnicodeArea: Unicodedisposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.needs-fcpThis change is insta-stable, or significant enough to need a team FCP to proceed.relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.45

Development

Successfully merging this pull request may close these issues.

10 participants

@pyfisch@Serentty@sfackler@rfcbot@Mark-Simulacrum@SimonSapin@bors@jonas-schievink@rust-highfive@Dylan-DPC-zz