Skip to content

Document unsafety in core::{panicking, alloc::layout, hint, iter::adapters::zip} - #71492

Merged
bors merged 1 commit into
rust-lang:masterfrom
LeSeulArtichaut:document-unsafe-2
Apr 24, 2020
Merged

Document unsafety in core::{panicking, alloc::layout, hint, iter::adapters::zip}#71492
bors merged 1 commit into
rust-lang:masterfrom
LeSeulArtichaut:document-unsafe-2

Conversation

@LeSeulArtichaut

@LeSeulArtichautLeSeulArtichaut commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

Helps with #66219.
r? @Mark-Simulacrum do you want to continue reading safety comments? :D

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2020
@LeSeulArtichautLeSeulArtichaut mentioned this pull request Apr 23, 2020
Closed
Mark-Simulacrum
Mark-Simulacrum reviewed Apr 23, 2020
View reviewed changes
Comment threadsrc/libcore/alloc/layout.rs Outdated
Comment threadsrc/libcore/alloc/layout.rs Outdated
Comment threadsrc/libcore/hint.rs Outdated

@Mark-SimulacrumMark-SimulacrumApr 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this setup so strangely? Can we "unwrap" these inner cfg's?

AFAICT we should also be able to do the same for the x86/x86_64 cfg's, just gating on target_feature = "sse2" in the wrapper (or inlining that).

@LeSeulArtichautLeSeulArtichautApr 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be done in a separate PR?

@Mark-SimulacrumMark-SimulacrumApr 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just leaving feedback in case you're up for making that PR :)

@LeSeulArtichautLeSeulArtichautApr 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a low-effort low-hanging fruit. Yum!

Comment threadsrc/libcore/iter/adapters/zip.rs Outdated
@LeSeulArtichaut

LeSeulArtichaut commented Apr 23, 2020

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum Resolved your review comments!

@Mark-Simulacrum

Mark-Simulacrum commented Apr 23, 2020

Copy link
Copy Markdown
Member

r=me with commits squashed

@LeSeulArtichaut

LeSeulArtichaut commented Apr 23, 2020

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum Rebased! (I can't r+ myself I believe)

@LeSeulArtichaut

LeSeulArtichaut commented Apr 23, 2020

Copy link
Copy Markdown
ContributorAuthor

I'll try anyway :D
@bors r=Mark-Simulacrum rollup

@bors

bors commented Apr 23, 2020

Copy link
Copy Markdown
Collaborator

@LeSeulArtichaut: 🔑 Insufficient privileges: Not in reviewers

@bors

bors commented Apr 23, 2020

Copy link
Copy Markdown
Collaborator

@LeSeulArtichaut: 🔑 Insufficient privileges: not in try users

@Mark-Simulacrum

Mark-Simulacrum commented Apr 23, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d515168 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 24, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2020
@bors
Auto merge ofrust-lang#71496- Dylan-DPC:rollup-gwxejmk, r=Dylan-DPC
45c7838
Rollup of 6 pull requests
Successful merges:
- rust-lang#70845 (Make the `structural_match` error diagnostic for const generics clearer)
- rust-lang#71063 (Document unsafety in core::{option, hash})
- rust-lang#71068 (Stabilize UNICODE_VERSION (feature unicode_version))
- rust-lang#71426 (fix error code in E0751.md)
- rust-lang#71459 (Add leading 0x to offset in Debug fmt of Pointer)
- rust-lang#71492 (Document unsafety in core::{panicking, alloc::layout, hint, iter::adapters::zip})
Failed merges:
r? @ghost
@bors
bors merged commit 8a0e88e into rust-lang:masterApr 24, 2020
@LeSeulArtichaut
LeSeulArtichaut deleted the document-unsafe-2 branch April 24, 2020 08:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LeSeulArtichaut@Mark-Simulacrum@bors@rust-highfive