Skip to content

Explain why we shouldn't add inline attr to into_vec - #71287

Merged
bors merged 1 commit into
rust-lang:masterfrom
JohnTitor:comment-vec
Apr 19, 2020
Merged

Explain why we shouldn't add inline attr to into_vec#71287
bors merged 1 commit into
rust-lang:masterfrom
JohnTitor:comment-vec

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

Follow-up of #71204
r? @RalfJung

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2020
@RalfJung

Copy link
Copy Markdown
Member

Thanks!
@bors r+ rollup

@bors

bors commented Apr 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1a46159 has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 18, 2020
Explain why we shouldn't add inline attr to into_vec
Follow-up of rust-lang#71204
r? @RalfJung
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 18, 2020
Explain why we shouldn't add inline attr to into_vec
Follow-up of rust-lang#71204
r? @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2020
Rollup of 5 pull requests
Successful merges:
- rust-lang#71271 (Move `MapInPlace` to rustc_data_structures)
- rust-lang#71276 (miri-unleashed: test that we detect heap allocations)
- rust-lang#71283 (Minor improvements to -Zprofile)
- rust-lang#71287 (Explain why we shouldn't add inline attr to into_vec)
- rust-lang#71303 (remove build warnings)
Failed merges:
r? @ghost
@bors
bors merged commit dfdfc76 into rust-lang:masterApr 19, 2020
@JohnTitor
JohnTitor deleted the comment-vec branch April 19, 2020 02:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnTitor@RalfJung@bors@rust-highfive