Skip to content

remove build warnings - #71303

Merged
bors merged 1 commit into
rust-lang:masterfrom
tshepang:master
Apr 19, 2020
Merged

remove build warnings#71303
bors merged 1 commit into
rust-lang:masterfrom
tshepang:master

Conversation

@tshepang

@tshepangtshepang commented Apr 18, 2020

Copy link
Copy Markdown
Member

Code blocks that are not annotated are assumed to be Rust

@tshepang
remove build warnings
fcbefae
Code blocks that are not annotated are assumed to be Rust
@rust-highfive

rust-highfive commented Apr 18, 2020

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Apr 18, 2020

Copy link
Copy Markdown
Member

It sounds like there's an underlying bug here as well, as we should always be running with warnings denied in CI. Can you say which command you're running that's printing warnings?

r? @Mark-Simulacrum

@tshepang

tshepang commented Apr 18, 2020

Copy link
Copy Markdown
MemberAuthor

It probably was ./x.py --incremental build --stage 1

@Mark-Simulacrum

Mark-Simulacrum commented Apr 18, 2020

Copy link
Copy Markdown
Member

Hm. Odd. Anyway, @bors r+ rollup for now, but would be good to track that down.

@bors

bors commented Apr 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit fcbefae has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2020
@tshepang

tshepang commented Apr 18, 2020

Copy link
Copy Markdown
MemberAuthor

@Mark-Simulacrum I was actually surprised by the warnings, given there's no rust annotation, making me curious where the default is set.

@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 18, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2020
@bors
Auto merge ofrust-lang#71306- Dylan-DPC:rollup-kvzc1da, r=Dylan-DPC
8001b96
Rollup of 5 pull requests
Successful merges:
- rust-lang#71271 (Move `MapInPlace` to rustc_data_structures)
- rust-lang#71276 (miri-unleashed: test that we detect heap allocations)
- rust-lang#71283 (Minor improvements to -Zprofile)
- rust-lang#71287 (Explain why we shouldn't add inline attr to into_vec)
- rust-lang#71303 (remove build warnings)
Failed merges:
r? @ghost
@bors
bors merged commit f6fb931 into rust-lang:masterApr 19, 2020
@tshepang

tshepang commented Apr 22, 2020

Copy link
Copy Markdown
MemberAuthor

Hm. Odd. Anyway, @bors r+ rollup for now, but would be good to track that down.

Actually I think I saw those warnings because I was running x.py doc, not .x.py build.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tshepang@rust-highfive@Mark-Simulacrum@bors@varkor