Skip to content

Decode qualifs for associated const defaults - #71813

Merged
bors merged 2 commits into
rust-lang:masterfrom
ecstatic-morse:issue-71734
May 3, 2020
Merged

Decode qualifs for associated const defaults#71813
bors merged 2 commits into
rust-lang:masterfrom
ecstatic-morse:issue-71734

Conversation

@ecstatic-morse

Copy link
Copy Markdown
Contributor

Fixes#71734.

We encode qualifs for associated constants, but never expected to decode the qualifs for defaulted associated consts. Fix this, and test that associated const defaults have the correct qualifs cross-crate.

r? @tmandry

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2020
@tmandry

Copy link
Copy Markdown
Member

Thanks for fixing this so quickly!

@bors r+ rollup

@bors

bors commented May 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 14a2c8d has been approved by tmandry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 3, 2020
Decode qualifs for associated const defaults
Fixesrust-lang#71734.
We encode qualifs for associated constants, but never expected to decode the qualifs for defaulted associated consts. Fix this, and test that associated const defaults have the correct qualifs cross-crate.
r? @tmandry
This was referenced May 3, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2020
Rollup of 5 pull requests
Successful merges:
- rust-lang#71165 (`slice::fill`: use `T` instead of generic arg)
- rust-lang#71314 (Implement RFC 2523, `#[cfg(version(..))]`)
- rust-lang#71542 (Implement `confusable_idents` lint.)
- rust-lang#71806 (typo)
- rust-lang#71813 (Decode qualifs for associated const defaults)
Failed merges:
r? @ghost
@bors
bors merged commit e48a7b8 into rust-lang:masterMay 3, 2020
@ecstatic-morse
ecstatic-morse deleted the issue-71734 branch October 6, 2020 01:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: rmeta/decoder.rs:1130: impossible case reached

4 participants

@ecstatic-morse@tmandry@bors@rust-highfive