Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #71828
Merged
Merged
Conversation
This also tests for the ICE in rust-lang#71734
`slice::fill`: use `T` instead of generic arg implements rust-lang#70758 (comment) As the discussion in rust-lang#70758 has shifted, I now use `T` instead of `&T`.
Implement RFC 2523, `#[cfg(version(..))]`
Hi! This is my first contribution to rust, I hope I didn't miss anything. I tried to implement this feature so that `#[cfg(version(1.44.0))]` works but the parser was printing an error that I wasn't sure how to fix so I just opted for implementing `#[cfg(version("1.44.0"))]` (note the quotes).
Tracking issue: rust-lang#64796…chenkov Implement `confusable_idents` lint. This collects all identifier symbols into `ParseSession` and examines them within the non-ascii-idents lint. The skeleton generation part needs to be added to `unicode-security` crate. Will update this PR when the crate is updated. r? @petrochenkov EDIT: also included the `concat_idents` part.
Decode qualifs for associated const defaults Fixesrust-lang#71734. We encode qualifs for associated constants, but never expected to decode the qualifs for defaulted associated consts. Fix this, and test that associated const defaults have the correct qualifs cross-crate. r? @tmandry
Dylan-DPC-zz
commented
May 3, 2020
Author
@bors r+ rollup=never p=5 |
bors
commented
May 3, 2020
Collaborator
📌 Commit e48a7b8 has been approved by |
Dylan-DPC-zz
commented
May 3, 2020
Author
@bors r+ rollup=never p=5 |
bors
commented
May 3, 2020
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
May 3, 2020
Collaborator
📌 Commit e48a7b8 has been approved by |
bors
commented
May 3, 2020
Collaborator
bors
commented
May 3, 2020
Collaborator
☀️ Test successful - checks-azure |
This was referenced May 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
slice::fill: useTinstead of generic arg #71165 (slice::fill: useTinstead of generic arg)#[cfg(version(..))]#71314 (Implement RFC 2523,#[cfg(version(..))])confusable_identslint. #71542 (Implementconfusable_identslint.)Failed merges:
r? @ghost