Skip to content

Remove noisy suggestion of hash_map - #73023

Merged
bors merged 1 commit into
rust-lang:masterfrom
ayushmishra2005:remove_noisy_suggestion
Jun 11, 2020
Merged

Remove noisy suggestion of hash_map #73023
bors merged 1 commit into
rust-lang:masterfrom
ayushmishra2005:remove_noisy_suggestion

Conversation

@ayushmishra2005

@ayushmishra2005ayushmishra2005 commented Jun 5, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Remove noisy suggestion of hash_map #72642

fixes#72642

@rust-highfive

rust-highfive commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2020
@ayushmishra2005

ayushmishra2005 commented Jun 5, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

r? @davidtwco Sorry to bother you again. Can you please review and approve this PR?

@ayushmishra2005

ayushmishra2005 commented Jun 5, 2020

Copy link
Copy Markdown
ContributorAuthor

@Dylan-DPC@lzutao@lcnr I have raised new PR and closed #72947. Please take a look.

lcnr
lcnr approved these changes Jun 5, 2020
View reviewed changes

@lcnrlcnr left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Please add fixes #72642 to the description of this PR.
This automatically closes that issue once this PR is merged.

edit: what was the reason for closing the original PR?

@davidtwco

davidtwco commented Jun 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Will r+ once CI passes!

@ayushmishra2005

ayushmishra2005 commented Jun 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks

Please add fixes #72642 to the description of this PR.
This automatically closes that issue once this PR is merged.

edit: what was the reason for closing the original PR?

@lcnr I did something wrong while squashing the commit. That's why I raised fresh PR.

@davidtwco

davidtwco commented Jun 5, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 9d1a883 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2020
@chrissimpkinschrissimpkins mentioned this pull request Jun 5, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2020
@Dylan-DPC
Rollup merge ofrust-lang#73023- ayushmishra2005:remove_noisy_sugges…
aa99f19
…tion, r=davidtwco
Remove noisy suggestion of hash_map
Remove noisy suggestion of hash_map rust-lang#72642fixesrust-lang#72642
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 5, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2020
@Dylan-DPC
Rollup merge ofrust-lang#73023- ayushmishra2005:remove_noisy_sugges…
5ef591e
…tion, r=davidtwco
Remove noisy suggestion of hash_map
Remove noisy suggestion of hash_map rust-lang#72642fixesrust-lang#72642
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 5, 2020
Closed
@ayushmishra2005
ayushmishra2005force-pushed the remove_noisy_suggestion branch 2 times, most recently from 7edbb63 to b786296CompareJune 7, 2020 10:50
@ayushmishra2005

ayushmishra2005 commented Jun 7, 2020

Copy link
Copy Markdown
ContributorAuthor

@Dylan-DPC Please let me know if anything is pending from my side. I rebased my PR with the master branch. CI pipeline is working fine.

@davidtwco

davidtwco commented Jun 7, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 7, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit b7862969bf3671b767693d8f31d58424c6592d91 has been approved by davidtwco

Ayush Kumar Mishra
Remove noisy suggestion of hash_maprust-lang#72642
b055552
Fixed failing test-cases
Remove noisy suggestion of hash_map rust-lang#72642
Fixed failing test-cases
@ayushmishra2005
ayushmishra2005force-pushed the remove_noisy_suggestion branch from b786296 to b055552CompareJune 9, 2020 03:28
@ayushmishra2005

ayushmishra2005 commented Jun 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@Dylan-DPC Please let me know if there is anything stopping this PR to be merged in master. This PR has been approved by the reviewer @davidtwco . I have been rebasing with master on daily basis and CI pipeline is also green.

Please let me know if there is anything pending from my side. I would address it asap.
Thanks

@davidtwco

davidtwco commented Jun 9, 2020

Copy link
Copy Markdown
Member

@ayushmishra2005 Unless there are conflicts or CI failures while merging, you don’t need to rebase - every time you do, I need to reapprove. It’s in the merge queue.

@bors r+

@bors

bors commented Jun 9, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit b055552 has been approved by davidtwco

@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2020
@bors
Auto merge ofrust-lang#73206- Dylan-DPC:rollup-rha9g8q, r=Dylan-DPC
ec42485
Rollup of 9 pull requests
Successful merges:
- rust-lang#72706 (Add windows group to triagebot)
- rust-lang#72789 (resolve: Do not suggest imports from the same module in which we are resolving)
- rust-lang#72890 (improper ctypes: normalize return types and transparent structs)
- rust-lang#72897 (normalize adt fields during structural match checking)
- rust-lang#73005 (Don't create impl candidates when obligation contains errors)
- rust-lang#73023 (Remove noisy suggestion of hash_map )
- rust-lang#73070 (Add regression test for const generic ICE in rust-lang#72819)
- rust-lang#73157 (Don't lose empty `where` clause when pretty-printing)
- rust-lang#73184 (Reoder order in which MinGW libs are linked to fix recent breakage)
Failed merges:
r? @ghost
@bors
bors merged commit e1cd8c4 into rust-lang:masterJun 11, 2020
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes
@lcnrlcnrlcnr approved these changes

Assignees

@davidtwcodavidtwco

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.46

Development

Successfully merging this pull request may close these issues.

Do not suggest importing hash_map::HashMap or btree_map::BTreeMap

7 participants

@ayushmishra2005@rust-highfive@davidtwco@bors@lcnr@cuviper@ecstatic-morse